From 96da21df05fe62f3da7a6798e3c8f7197818610b Mon Sep 17 00:00:00 2001 From: Vikrant Gupta Date: Tue, 17 Dec 2024 00:00:15 +0530 Subject: [PATCH] fix: correlation time stamps for APM to traces and logs (#6632) --- .../src/container/MetricsApplication/Tabs/Overview.tsx | 8 ++++---- frontend/src/container/MetricsApplication/Tabs/util.ts | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/frontend/src/container/MetricsApplication/Tabs/Overview.tsx b/frontend/src/container/MetricsApplication/Tabs/Overview.tsx index 6decf72b39..24e47041d7 100644 --- a/frontend/src/container/MetricsApplication/Tabs/Overview.tsx +++ b/frontend/src/container/MetricsApplication/Tabs/Overview.tsx @@ -185,6 +185,7 @@ function Application(): JSX.Element { panelTypes: PANEL_TYPES.TIME_SERIES, yAxisUnit: '%', id: SERVICE_CHART_ID.errorPercentage, + fillSpans: true, }), [servicename, tagFilterItems, topLevelOperationsRoute], ); @@ -222,12 +223,11 @@ function Application(): JSX.Element { apmToTraceQuery: Query, isViewLogsClicked?: boolean, ): (() => void) => (): void => { - const currentTime = timestamp; - const endTime = timestamp + stepInterval; - console.log(endTime, stepInterval); + const endTime = timestamp; + const startTime = timestamp - stepInterval; const urlParams = new URLSearchParams(search); - urlParams.set(QueryParams.startTime, currentTime.toString()); + urlParams.set(QueryParams.startTime, startTime.toString()); urlParams.set(QueryParams.endTime, endTime.toString()); urlParams.delete(QueryParams.relativeTime); const avialableParams = routeConfig[ROUTES.TRACE]; diff --git a/frontend/src/container/MetricsApplication/Tabs/util.ts b/frontend/src/container/MetricsApplication/Tabs/util.ts index e6d58831a0..e1f8164b09 100644 --- a/frontend/src/container/MetricsApplication/Tabs/util.ts +++ b/frontend/src/container/MetricsApplication/Tabs/util.ts @@ -65,11 +65,11 @@ export function onViewTracePopupClick({ stepInterval, }: OnViewTracePopupClickProps): VoidFunction { return (): void => { - const currentTime = timestamp; - const endTime = timestamp + (stepInterval || 60); + const endTime = timestamp; + const startTime = timestamp - (stepInterval || 60); const urlParams = new URLSearchParams(window.location.search); - urlParams.set(QueryParams.startTime, currentTime.toString()); + urlParams.set(QueryParams.startTime, startTime.toString()); urlParams.set(QueryParams.endTime, endTime.toString()); urlParams.delete(QueryParams.relativeTime); const avialableParams = routeConfig[ROUTES.TRACE];