GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-12 18:19:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: fixed logEvent breaking page due to lack of null checks (#5511)

Browse Source 
* fix: fixed logEvent breaking page due to lack of null checks

* fix: fixed logEvent breaking page due to lack of null checks
This commit is contained in:
SagarRajput-7 2024-07-18 13:54:05 +05:30 committed by GitHub
parent adfe20e88a
commit add2d19614
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
13 changed files with 32 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/container/AllError/index.tsx
View File

@ -423,9 +423,9 @@ function AllErrors(): JSX.Element {
)?.tagValue; )?.tagValue;
logEvent('Exception: List page visited', { logEvent('Exception: List page visited', {
numberOfExceptions: errorCountResponse.data?.payload, numberOfExceptions: errorCountResponse?.data?.payload,
selectedEnvironments, selectedEnvironments,
resourceAttributeUsed: !!queries.length, resourceAttributeUsed: !!queries?.length,
}); });
logEventCalledRef.current = true; logEventCalledRef.current = true;
} }

8
frontend/src/container/CreateAlertChannels/index.tsx
View File

@ -449,8 +449,8 @@ function CreateAlertChannels({
const result = await functionToCall(); const result = await functionToCall();
logEvent('Alert Channel: Save channel', { logEvent('Alert Channel: Save channel', {
type: value, type: value,
sendResolvedAlert: selectedConfig.send_resolved, sendResolvedAlert: selectedConfig?.send_resolved,
name: selectedConfig.name, name: selectedConfig?.name,
new: 'true', new: 'true',
status: result?.status, status: result?.status,
statusMessage: result?.statusMessage, statusMessage: result?.statusMessage,
@ -530,8 +530,8 @@ function CreateAlertChannels({
logEvent('Alert Channel: Test notification', { logEvent('Alert Channel: Test notification', {
type: channelType, type: channelType,
sendResolvedAlert: selectedConfig.send_resolved, sendResolvedAlert: selectedConfig?.send_resolved,
name: selectedConfig.name, name: selectedConfig?.name,
new: 'true', new: 'true',
status: status:
response && response.statusCode === 200 ? 'Test success' : 'Test failed', response && response.statusCode === 200 ? 'Test success' : 'Test failed',

8
frontend/src/container/EditAlertChannels/index.tsx
View File

@ -370,8 +370,8 @@ function EditAlertChannels({
} }
logEvent('Alert Channel: Save channel', { logEvent('Alert Channel: Save channel', {
type: value, type: value,
sendResolvedAlert: selectedConfig.send_resolved, sendResolvedAlert: selectedConfig?.send_resolved,
name: selectedConfig.name, name: selectedConfig?.name,
new: 'false', new: 'false',
status: result?.status, status: result?.status,
statusMessage: result?.statusMessage, statusMessage: result?.statusMessage,
@ -441,8 +441,8 @@ function EditAlertChannels({
} }
logEvent('Alert Channel: Test notification', { logEvent('Alert Channel: Test notification', {
type: channelType, type: channelType,
sendResolvedAlert: selectedConfig.send_resolved, sendResolvedAlert: selectedConfig?.send_resolved,
name: selectedConfig.name, name: selectedConfig?.name,
new: 'false', new: 'false',
status: status:
response && response.statusCode === 200 ? 'Test success' : 'Test failed', response && response.statusCode === 200 ? 'Test success' : 'Test failed',

8
frontend/src/container/ErrorDetails/index.tsx
View File

@ -114,10 +114,10 @@ function ErrorDetails(props: ErrorDetailsProps): JSX.Element {
const onClickTraceHandler = (): void => { const onClickTraceHandler = (): void => {
logEvent('Exception: Navigate to trace detail page', { logEvent('Exception: Navigate to trace detail page', {
groupId: errorDetail.groupID, groupId: errorDetail?.groupID,
spanId: errorDetail.spanID, spanId: errorDetail.spanID,
traceId: errorDetail.traceID, traceId: errorDetail.traceID,
exceptionId: errorDetail.errorId, exceptionId: errorDetail?.errorId,
}); });
history.push(`/trace/${errorDetail.traceID}?spanId=${errorDetail.spanID}`); history.push(`/trace/${errorDetail.traceID}?spanId=${errorDetail.spanID}`);
}; };
@ -126,10 +126,10 @@ function ErrorDetails(props: ErrorDetailsProps): JSX.Element {
useEffect(() => { useEffect(() => {
if (!logEventCalledRef.current && !isUndefined(data)) { if (!logEventCalledRef.current && !isUndefined(data)) {
logEvent('Exception: Detail page visited', { logEvent('Exception: Detail page visited', {
groupId: errorDetail.groupID, groupId: errorDetail?.groupID,
spanId: errorDetail.spanID, spanId: errorDetail.spanID,
traceId: errorDetail.traceID, traceId: errorDetail.traceID,
exceptionId: errorDetail.errorId, exceptionId: errorDetail?.errorId,
}); });
logEventCalledRef.current = true; logEventCalledRef.current = true;
} }

4
frontend/src/container/ExplorerOptions/ExplorerOptions.tsx
View File

@ -256,12 +256,12 @@ function ExplorerOptions({
if (sourcepage === DataSource.TRACES) { if (sourcepage === DataSource.TRACES) {
logEvent('Traces Explorer: Select view', { logEvent('Traces Explorer: Select view', {
panelType, panelType,
viewName: option.value, viewName: option?.value,
}); });
} else if (sourcepage === DataSource.LOGS) { } else if (sourcepage === DataSource.LOGS) {
logEvent('Logs Explorer: Select view', { logEvent('Logs Explorer: Select view', {
panelType, panelType,
viewName: option.value, viewName: option?.value,
}); });
} }
if (ref.current) { if (ref.current) {

2
frontend/src/container/FormAlertRules/BasicInfo.tsx
View File

@ -88,7 +88,7 @@ function BasicInfo({
if (!channels.loading && isNewRule) { if (!channels.loading && isNewRule) {
logEvent('Alert: New alert creation page visited', { logEvent('Alert: New alert creation page visited', {
dataSource: ALERTS_DATA_SOURCE_MAP[alertDef?.alertType as AlertTypes], dataSource: ALERTS_DATA_SOURCE_MAP[alertDef?.alertType as AlertTypes],
numberOfChannels: channels.payload?.length, numberOfChannels: channels?.payload?.length,
}); });
} }
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps

4
frontend/src/container/ListAlertRules/utils.ts
View File

@ -49,9 +49,9 @@ export const alertActionLogEvent = (
break; break;
} }
logEvent('Alert: Action', { logEvent('Alert: Action', {
ruleId: record.id, ruleId: record?.id,
dataSource: ALERTS_DATA_SOURCE_MAP[record.alertType as AlertTypes], dataSource: ALERTS_DATA_SOURCE_MAP[record.alertType as AlertTypes],
name: record.alert, name: record?.alert,
action: actionValue, action: actionValue,
}); });
}; };

2
frontend/src/container/MetricsApplication/Tabs/DBCall.tsx
View File

@ -108,7 +108,7 @@ function DBCall(): JSX.Element {
logEvent('APM: Service detail page visited', { logEvent('APM: Service detail page visited', {
selectedEnvironments, selectedEnvironments,
resourceAttributeUsed: !!queries.length, resourceAttributeUsed: !!queries?.length,
section: 'dbMetrics', section: 'dbMetrics',
}); });
logEventCalledRef.current = true; logEventCalledRef.current = true;

2
frontend/src/container/MetricsApplication/Tabs/External.tsx
View File

@ -124,7 +124,7 @@ function External(): JSX.Element {
logEvent('APM: Service detail page visited', { logEvent('APM: Service detail page visited', {
selectedEnvironments, selectedEnvironments,
resourceAttributeUsed: !!queries.length, resourceAttributeUsed: !!queries?.length,
section: 'externalMetrics', section: 'externalMetrics',
}); });
logEventCalledRef.current = true; logEventCalledRef.current = true;

2
frontend/src/container/MetricsApplication/Tabs/Overview.tsx
View File

@ -91,7 +91,7 @@ function Application(): JSX.Element {
logEvent('APM: Service detail page visited', { logEvent('APM: Service detail page visited', {
selectedEnvironments, selectedEnvironments,
resourceAttributeUsed: !!queries.length, resourceAttributeUsed: !!queries?.length,
section: 'overview', section: 'overview',
}); });
logEventCalledRef.current = true; logEventCalledRef.current = true;

2
frontend/src/container/ServiceApplication/ServiceTraces/index.tsx
View File

@ -59,7 +59,7 @@ function ServiceTraces(): JSX.Element {
logEvent('APM: List page visited', { logEvent('APM: List page visited', {
numberOfServices: data?.length, numberOfServices: data?.length,
selectedEnvironments, selectedEnvironments,
resourceAttributeUsed: !!queries.length, resourceAttributeUsed: !!queries?.length,
rps, rps,
}); });
logEventCalledRef.current = true; logEventCalledRef.current = true;

14
frontend/src/container/SideNav/SideNav.tsx
View File

@ -324,8 +324,8 @@ function SideNav({
onClickHandler(item?.key as string, event); onClickHandler(item?.key as string, event);
} }
logEvent('Sidebar: Menu clicked', { logEvent('Sidebar: Menu clicked', {
menuRoute: item.key, menuRoute: item?.key,
menuLabel: item.label, menuLabel: item?.label,
}); });
}; };
@ -455,8 +455,8 @@ function SideNav({
onClick={(event: MouseEvent): void => { onClick={(event: MouseEvent): void => {
handleUserManagentMenuItemClick(item?.key as string, event); handleUserManagentMenuItemClick(item?.key as string, event);
logEvent('Sidebar: Menu clicked', { logEvent('Sidebar: Menu clicked', {
menuRoute: item.key, menuRoute: item?.key,
menuLabel: item.label, menuLabel: item?.label,
}); });
}} }}
/> />
@ -475,8 +475,8 @@ function SideNav({
history.push(`${inviteMemberMenuItem.key}`); history.push(`${inviteMemberMenuItem.key}`);
} }
logEvent('Sidebar: Menu clicked', { logEvent('Sidebar: Menu clicked', {
menuRoute: inviteMemberMenuItem.key, menuRoute: inviteMemberMenuItem?.key,
menuLabel: inviteMemberMenuItem.label, menuLabel: inviteMemberMenuItem?.label,
}); });
}} }}
/> />
@ -493,7 +493,7 @@ function SideNav({
event, event,
); );
logEvent('Sidebar: Menu clicked', { logEvent('Sidebar: Menu clicked', {
menuRoute: userSettingsMenuItem.key, menuRoute: userSettingsMenuItem?.key,
menuLabel: 'User', menuLabel: 'User',
}); });
}} }}

4
frontend/src/pages/SaveView/index.tsx
View File

@ -149,11 +149,11 @@ function SaveView(): JSX.Element {
if (!logEventCalledRef.current && !isLoading) { if (!logEventCalledRef.current && !isLoading) {
if (sourcepage === DataSource.TRACES) { if (sourcepage === DataSource.TRACES) {
logEvent('Traces Views: Views visited', { logEvent('Traces Views: Views visited', {
number: viewsData?.data.data.length, number: viewsData?.data?.data?.length,
}); });
} else if (sourcepage === DataSource.LOGS) { } else if (sourcepage === DataSource.LOGS) {
logEvent('Logs Views: Views visited', { logEvent('Logs Views: Views visited', {
number: viewsData?.data.data.length, number: viewsData?.data?.data?.length,
}); });
} }
logEventCalledRef.current = true; logEventCalledRef.current = true;