GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-12 20:49:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: handle traceID search 404 performance issue (#5654)

Browse Source 
By setting max and min timestamp filter same as current timestamp when traceIDs are not found
This commit is contained in:
Vishal Sharma 2024-08-08 08:32:11 +05:30 committed by GitHub
parent fd6f0574f5
commit ae325ec1ca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/query-service/app/clickhouseReader/reader.go
View File

@ -5016,9 +5016,10 @@ func (r *ClickHouseReader) GetMinAndMaxTimestampForTraceID(ctx context.Context,
return 0, 0, err return 0, 0, err
} }
// return current time if traceID not found
if minTime.IsZero() || maxTime.IsZero() { if minTime.IsZero() || maxTime.IsZero() {
zap.L().Debug("minTime or maxTime is zero") zap.L().Debug("minTime or maxTime is zero, traceID not found")
return 0, 0, nil return time.Now().UnixNano(), time.Now().UnixNano(), nil
} }
zap.L().Debug("GetMinAndMaxTimestampForTraceID", zap.Any("minTime", minTime), zap.Any("maxTime", maxTime)) zap.L().Debug("GetMinAndMaxTimestampForTraceID", zap.Any("minTime", minTime), zap.Any("maxTime", maxTime))

2
pkg/query-service/app/traces/v3/utils.go
View File

@ -127,7 +127,7 @@ func AddTimestampFilters(minTime int64, maxTime int64, params *v3.QueryRangePara
if compositeQuery == nil { if compositeQuery == nil {
return return
} }
// Build queries for each builder query // Build queries for each builder query and apply timestamp filter only if TraceID is present
for queryName, query := range compositeQuery.BuilderQueries { for queryName, query := range compositeQuery.BuilderQueries {
if query.Expression != queryName && query.DataSource != v3.DataSourceTraces { if query.Expression != queryName && query.DataSource != v3.DataSourceTraces {
continue continue