GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-14 08:15:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: pr comments - used useSafeNavigate hook

Browse Source
This commit is contained in:
sawhil 2025-04-14 01:44:32 +05:30 committed by Sahil Khan
parent 9a580915e6
commit afb18b8142
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend/src/container/TraceWaterfall/SpanLineActionButtons/SpanLineActionButtons.styles.scss
View File

@ -32,9 +32,6 @@
border: 1px solid var(--bg-vanilla-400);
background: var(--bg-vanilla-400);
.ant-btn-default {
}
.copy-span-btn {
border-color: var(--bg-vanilla-400) !important;
}

15
frontend/src/container/TraceWaterfall/TraceWaterfallStates/Success/Success.tsx
View File

@ -11,6 +11,8 @@ import { themeColors } from 'constants/theme';
import { convertTimeToRelevantUnit } from 'container/TraceDetail/utils';
import SpanLineActionButtons from 'container/TraceWaterfall/SpanLineActionButtons';
import { IInterestedSpan } from 'container/TraceWaterfall/TraceWaterfall';
import { useSafeNavigate } from 'hooks/useSafeNavigate';
import useUrlQuery from 'hooks/useUrlQuery';
import { generateColor } from 'lib/uPlotLib/utils/generateColor';
import {
AlertCircle,
@ -28,7 +30,6 @@ import {
useRef,
useState,
} from 'react';
import { useHistory, useLocation } from 'react-router-dom';
import { Span } from 'types/api/trace/getTraceV2';
import { toFixed } from 'utils/toFixed';
@ -169,9 +170,8 @@ function SpanDuration({
const leftOffset = ((span.timestamp - traceMetadata.startTime) * 1e2) / spread;
const width = (span.durationNano * 1e2) / (spread * 1e6);
const { search } = useLocation();
const history = useHistory();
const searchParams = new URLSearchParams(search);
const urlQuery = useUrlQuery();
const { safeNavigate } = useSafeNavigate();
let color = generateColor(span.serviceName, themeColors.traceDetailColors);
@ -199,8 +199,11 @@ function SpanDuration({
onMouseLeave={handleMouseLeave}
onClick={(): void => {
setSelectedSpan(span);
searchParams.set('spanId', span.spanId);
history.replace({ search: searchParams.toString() });
if (span?.spanId) {
urlQuery.set('spanId', span?.spanId);
}
safeNavigate({ search: urlQuery.toString() });
}}
>
<div