diff --git a/frontend/src/api/metricsExplorer/getMetricDetails.ts b/frontend/src/api/metricsExplorer/getMetricDetails.ts index 8ce73c67f2..2cea70a2af 100644 --- a/frontend/src/api/metricsExplorer/getMetricDetails.ts +++ b/frontend/src/api/metricsExplorer/getMetricDetails.ts @@ -27,8 +27,8 @@ export interface MetricDetails { } export enum Temporality { - CUMULATIVE = 'cumulative', - DELTA = 'delta', + CUMULATIVE = 'Cumulative', + DELTA = 'Delta', } export interface MetricDetailsAttribute { diff --git a/frontend/src/api/metricsExplorer/getMetricsList.ts b/frontend/src/api/metricsExplorer/getMetricsList.ts index f1cb81da62..63fd5e4da4 100644 --- a/frontend/src/api/metricsExplorer/getMetricsList.ts +++ b/frontend/src/api/metricsExplorer/getMetricsList.ts @@ -30,8 +30,8 @@ export interface MetricsListItemData { description: string; type: MetricType; unit: string; - [TreemapViewType.CARDINALITY]: number; - [TreemapViewType.DATAPOINTS]: number; + [TreemapViewType.TIMESERIES]: number; + [TreemapViewType.SAMPLES]: number; lastReceived: string; } diff --git a/frontend/src/api/metricsExplorer/getMetricsTreeMap.ts b/frontend/src/api/metricsExplorer/getMetricsTreeMap.ts index 0370d2f275..ce2d28527f 100644 --- a/frontend/src/api/metricsExplorer/getMetricsTreeMap.ts +++ b/frontend/src/api/metricsExplorer/getMetricsTreeMap.ts @@ -14,18 +14,18 @@ export interface MetricsTreeMapPayload { export interface MetricsTreeMapResponse { status: string; data: { - [TreemapViewType.CARDINALITY]: CardinalityData[]; - [TreemapViewType.DATAPOINTS]: DatapointsData[]; + [TreemapViewType.TIMESERIES]: TimeseriesData[]; + [TreemapViewType.SAMPLES]: SamplesData[]; }; } -export interface CardinalityData { +export interface TimeseriesData { percentage: number; total_value: number; metric_name: string; } -export interface DatapointsData { +export interface SamplesData { percentage: number; metric_name: string; } diff --git a/frontend/src/api/metricsExplorer/updateMetricMetadata.ts b/frontend/src/api/metricsExplorer/updateMetricMetadata.ts index c841f9c9a1..a739646690 100644 --- a/frontend/src/api/metricsExplorer/updateMetricMetadata.ts +++ b/frontend/src/api/metricsExplorer/updateMetricMetadata.ts @@ -6,7 +6,6 @@ import { MetricType } from './getMetricsList'; export interface UpdateMetricMetadataProps { description: string; - unit: string; metricType: MetricType; temporality: Temporality; isMonotonic?: boolean; @@ -21,7 +20,7 @@ const updateMetricMetadata = async ( metricName: string, props: UpdateMetricMetadataProps, ): Promise | ErrorResponse> => { - const response = await axios.put(`/metrics/${metricName}/metadata`, { + const response = await axios.post(`/metrics/${metricName}/metadata`, { ...props, }); diff --git a/frontend/src/container/MetricsExplorer/MetricDetails/Metadata.tsx b/frontend/src/container/MetricsExplorer/MetricDetails/Metadata.tsx index 6bbd48186b..9d087d1ce1 100644 --- a/frontend/src/container/MetricsExplorer/MetricDetails/Metadata.tsx +++ b/frontend/src/container/MetricsExplorer/MetricDetails/Metadata.tsx @@ -11,7 +11,10 @@ import { useNotifications } from 'hooks/useNotifications'; import { Edit2, Save } from 'lucide-react'; import { useCallback, useMemo, useState } from 'react'; -import { METRIC_TYPE_LABEL_MAP } from '../Summary/constants'; +import { + METRIC_TYPE_LABEL_MAP, + METRIC_TYPE_VALUES_MAP, +} from '../Summary/constants'; import { MetricTypeRenderer } from '../Summary/utils'; import { METRIC_METADATA_KEYS } from './constants'; import { MetadataProps } from './types'; @@ -29,7 +32,6 @@ function Metadata({ ] = useState({ metricType: metadata?.metric_type || MetricType.SUM, description: metadata?.description || '', - unit: metadata?.unit || '', temporality: metadata?.temporality || Temporality.CUMULATIVE, }); const { notifications } = useNotifications(); @@ -82,7 +84,7 @@ function Metadata({ ellipsis: true, className: 'metric-metadata-value', render: (field: { value: string; key: string }): JSX.Element => { - if (!isEditing) { + if (!isEditing || field.key === 'unit') { if (field.key === 'metric_type') { return (
@@ -95,9 +97,9 @@ function Metadata({ if (field.key === 'metric_type') { return (