From b49ed913c754a2c4c010c266d6833ae6a0797a15 Mon Sep 17 00:00:00 2001 From: Srikanth Chekuri Date: Tue, 24 Sep 2024 10:56:49 +0530 Subject: [PATCH] chore: handle error before using task (#6055) --- pkg/query-service/rules/manager.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/query-service/rules/manager.go b/pkg/query-service/rules/manager.go index 09eb7ad367..75b2b5fade 100644 --- a/pkg/query-service/rules/manager.go +++ b/pkg/query-service/rules/manager.go @@ -476,15 +476,15 @@ func (m *Manager) addTask(rule *PostableRule, taskName string) error { UseLogsNewSchema: m.opts.UseLogsNewSchema, }) - for _, r := range newTask.Rules() { - m.rules[r.ID()] = r - } - if err != nil { zap.L().Error("creating rule task failed", zap.String("name", taskName), zap.Error(err)) return errors.New("error loading rules, previous rule set restored") } + for _, r := range newTask.Rules() { + m.rules[r.ID()] = r + } + // If there is an another task with the same identifier, raise an error _, ok := m.tasks[taskName] if ok {