From b557ca5519863a0873fe52c9f6cf7f31885c6f59 Mon Sep 17 00:00:00 2001 From: Yunus M Date: Tue, 12 Dec 2023 16:30:22 +0530 Subject: [PATCH] =?UTF-8?q?fix:=20use=20updated=20query=20value=20on=20tes?= =?UTF-8?q?t=20query,=20restrict=20direct=20commit=20to=E2=80=A6=20(#4210)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: use updated query value on test query, restrict direct commit to develop,main * fix: reset error preview on success --- frontend/.husky/commit-msg | 16 ++++++++++++++++ .../Variables/VariableItem/VariableItem.tsx | 3 ++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/frontend/.husky/commit-msg b/frontend/.husky/commit-msg index be422b654c..cb50d87a2d 100755 --- a/frontend/.husky/commit-msg +++ b/frontend/.husky/commit-msg @@ -2,3 +2,19 @@ . "$(dirname "$0")/_/husky.sh" cd frontend && yarn run commitlint --edit $1 + +branch="$(git rev-parse --abbrev-ref HEAD)" + +color_red="$(tput setaf 1)" +bold="$(tput bold)" +reset="$(tput sgr0)" + +if [ "$branch" = "main" ]; then + echo "${color_red}${bold}You can't commit directly to the main branch${reset}" + exit 1 +fi + +if [ "$branch" = "develop" ]; then + echo "${color_red}${bold}You can't commit directly to the develop branch${reset}" + exit 1 +fi \ No newline at end of file diff --git a/frontend/src/container/NewDashboard/DashboardSettings/Variables/VariableItem/VariableItem.tsx b/frontend/src/container/NewDashboard/DashboardSettings/Variables/VariableItem/VariableItem.tsx index 91faea4fcc..76f0464bd2 100644 --- a/frontend/src/container/NewDashboard/DashboardSettings/Variables/VariableItem/VariableItem.tsx +++ b/frontend/src/container/NewDashboard/DashboardSettings/Variables/VariableItem/VariableItem.tsx @@ -140,11 +140,12 @@ function VariableItem({ enabled: false, queryFn: () => dashboardVariablesQuery({ - query: variableData.queryValue || '', + query: variableQueryValue || '', variables: variablePropsToPayloadVariables(existingVariables), }), refetchOnWindowFocus: false, onSuccess: (response) => { + setErrorPreview(null); handleQueryResult(response); }, onError: (error: {