GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-14 08:55:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: add limits to suggestion query (#5984)

Browse Source
This commit is contained in:
Nityananda Gohain 2024-09-16 23:04:39 +05:30 committed by GitHub
parent 1b59719891
commit b78ade2cf2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/query-service/app/clickhouseReader/reader.go
View File

@ -4364,6 +4364,9 @@ func (r *ClickHouseReader) getValuesForLogAttributes(
) ([][]any, *model.ApiError) { ) ([][]any, *model.ApiError) {
// query top `limit` distinct values seen for `tagKey`s of interest // query top `limit` distinct values seen for `tagKey`s of interest
// ordered by timestamp when the value was seen // ordered by timestamp when the value was seen
// we added the settings max_rows_to_group_by=100, group_by_overflow_mode = 'break'
// to avoid query from taking up all the resources when value is high cardinality.
query := fmt.Sprintf( query := fmt.Sprintf(
` `
select tagKey, stringTagValue, int64TagValue, float64TagValue select tagKey, stringTagValue, int64TagValue, float64TagValue
@ -4383,7 +4386,7 @@ func (r *ClickHouseReader) getValuesForLogAttributes(
max(timestamp) as ts max(timestamp) as ts
from %s.%s from %s.%s
where tagKey in $1 where tagKey in $1
group by (tagKey, stringTagValue, int64TagValue, float64TagValue) group by (tagKey, stringTagValue, int64TagValue, float64TagValue) SETTINGS max_rows_to_group_by = 100, group_by_overflow_mode = 'break', max_threads=4
) )
) )
where rank <= %d where rank <= %d