mirror of
https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz
synced 2025-08-14 04:35:58 +08:00
chore: update default feature flag and error response for formula (#6184)
This commit is contained in:
parent
dd097821d1
commit
bf4c792cdb
@ -53,7 +53,11 @@ func (aH *APIHandler) queryRangeV4(w http.ResponseWriter, r *http.Request) {
|
|||||||
if anomalyQueryExists {
|
if anomalyQueryExists {
|
||||||
// ensure all queries have metric data source, and there should be only one anomaly query
|
// ensure all queries have metric data source, and there should be only one anomaly query
|
||||||
for _, query := range queryRangeParams.CompositeQuery.BuilderQueries {
|
for _, query := range queryRangeParams.CompositeQuery.BuilderQueries {
|
||||||
if query.DataSource != v3.DataSourceMetrics {
|
// What is query.QueryName == query.Expression doing here?
|
||||||
|
// In the current implementation, the way to recognize if a query is a formula is by
|
||||||
|
// checking if the expression is the same as the query name. if the expression is different
|
||||||
|
// then it is a formula. otherwise, it is simple builder query.
|
||||||
|
if query.DataSource != v3.DataSourceMetrics && query.QueryName == query.Expression {
|
||||||
RespondError(w, &model.ApiError{Typ: model.ErrorBadData, Err: fmt.Errorf("all queries must have metric data source")}, nil)
|
RespondError(w, &model.ApiError{Typ: model.ErrorBadData, Err: fmt.Errorf("all queries must have metric data source")}, nil)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@ -100,6 +104,13 @@ func (aH *APIHandler) queryRangeV4(w http.ResponseWriter, r *http.Request) {
|
|||||||
anomaly.WithReader[*anomaly.HourlyProvider](aH.opts.DataConnector),
|
anomaly.WithReader[*anomaly.HourlyProvider](aH.opts.DataConnector),
|
||||||
anomaly.WithFeatureLookup[*anomaly.HourlyProvider](aH.opts.FeatureFlags),
|
anomaly.WithFeatureLookup[*anomaly.HourlyProvider](aH.opts.FeatureFlags),
|
||||||
)
|
)
|
||||||
|
default:
|
||||||
|
provider = anomaly.NewDailyProvider(
|
||||||
|
anomaly.WithCache[*anomaly.DailyProvider](aH.opts.Cache),
|
||||||
|
anomaly.WithKeyGenerator[*anomaly.DailyProvider](queryBuilder.NewKeyGenerator()),
|
||||||
|
anomaly.WithReader[*anomaly.DailyProvider](aH.opts.DataConnector),
|
||||||
|
anomaly.WithFeatureLookup[*anomaly.DailyProvider](aH.opts.FeatureFlags),
|
||||||
|
)
|
||||||
}
|
}
|
||||||
anomalies, err := provider.GetAnomalies(r.Context(), &anomaly.GetAnomaliesRequest{Params: queryRangeParams})
|
anomalies, err := provider.GetAnomalies(r.Context(), &anomaly.GetAnomaliesRequest{Params: queryRangeParams})
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
@ -373,7 +373,7 @@ var EnterprisePlan = basemodel.FeatureSet{
|
|||||||
},
|
},
|
||||||
basemodel.Feature{
|
basemodel.Feature{
|
||||||
Name: basemodel.AnomalyDetection,
|
Name: basemodel.AnomalyDetection,
|
||||||
Active: true,
|
Active: false,
|
||||||
Usage: 0,
|
Usage: 0,
|
||||||
UsageLimit: -1,
|
UsageLimit: -1,
|
||||||
Route: "",
|
Route: "",
|
||||||
|
Loading…
x
Reference in New Issue
Block a user