GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-12 16:58:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove points with negative timestamps (#4007)

Browse Source
This commit is contained in:
Srikanth Chekuri 2023-11-21 14:49:34 +05:30 committed by GitHub
parent 84f2885533
commit c0226ab584
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/query-service/app/querier/querier.go
View File

@ -91,7 +91,26 @@ func (q *querier) execClickHouseQuery(ctx context.Context, query string) ([]*v3.
if q.testingMode && q.reader == nil { if q.testingMode && q.reader == nil {
return q.returnedSeries, q.returnedErr return q.returnedSeries, q.returnedErr
} }
return q.reader.GetTimeSeriesResultV3(ctx, query) result, err := q.reader.GetTimeSeriesResultV3(ctx, query)
var pointsWithNegativeTimestamps int
// Filter out the points with negative or zero timestamps
for idx := range result {
series := result[idx]
points := make([]v3.Point, 0)
for pointIdx := range series.Points {
point := series.Points[pointIdx]
if point.Timestamp > 0 {
points = append(points, point)
} else {
pointsWithNegativeTimestamps++
}
}
series.Points = points
}
if pointsWithNegativeTimestamps > 0 {
zap.S().Errorf("found points with negative timestamps for query %s", query)
}
return result, err
} }
func (q *querier) execPromQuery(ctx context.Context, params *model.QueryRangeParams) ([]*v3.Series, error) { func (q *querier) execPromQuery(ctx context.Context, params *model.QueryRangeParams) ([]*v3.Series, error) {