GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-12 18:29:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: theme analytics not getting reported as user is being fetched delayed (#5162)

Browse Source
This commit is contained in:
Vikrant Gupta 2024-06-06 17:04:00 +05:30 committed by GitHub
parent 35c054835a
commit c53e6de689
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/AppRoutes/index.tsx
View File

@ -178,9 +178,10 @@ function App(): JSX.Element {
}, [pathname]); }, [pathname]);
useEffect(() => { useEffect(() => {
if (user && user?.email && user?.userId && user?.name) {
try { try {
const isThemeAnalyticsSent = getLocalStorageApi( const isThemeAnalyticsSent = getLocalStorageApi(
LOCALSTORAGE.THEME_ANALYTICS, LOCALSTORAGE.THEME_ANALYTICS_V1,
); );
if (!isThemeAnalyticsSent) { if (!isThemeAnalyticsSent) {
trackEvent('Theme Analytics', { trackEvent('Theme Analytics', {
@ -188,13 +189,14 @@ function App(): JSX.Element {
user: pick(user, ['email', 'userId', 'name']), user: pick(user, ['email', 'userId', 'name']),
org, org,
}); });
setLocalStorageApi(LOCALSTORAGE.THEME_ANALYTICS, 'true'); setLocalStorageApi(LOCALSTORAGE.THEME_ANALYTICS_V1, 'true');
} }
} catch { } catch {
console.error('Failed to parse local storage theme analytics event'); console.error('Failed to parse local storage theme analytics event');
} }
}
// eslint-disable-next-line react-hooks/exhaustive-deps // eslint-disable-next-line react-hooks/exhaustive-deps
}, []); }, [user]);
return ( return (
<ConfigProvider theme={themeConfig}> <ConfigProvider theme={themeConfig}>

2
frontend/src/constants/localStorage.ts
View File

@ -18,5 +18,5 @@ export enum LOCALSTORAGE {
DASHBOARD_VARIABLES = 'DASHBOARD_VARIABLES', DASHBOARD_VARIABLES = 'DASHBOARD_VARIABLES',
SHOW_EXPLORER_TOOLBAR = 'SHOW_EXPLORER_TOOLBAR', SHOW_EXPLORER_TOOLBAR = 'SHOW_EXPLORER_TOOLBAR',
PINNED_ATTRIBUTES = 'PINNED_ATTRIBUTES', PINNED_ATTRIBUTES = 'PINNED_ATTRIBUTES',
THEME_ANALYTICS = 'THEME_ANALYTICS', THEME_ANALYTICS_V1 = 'THEME_ANALYTICS_V1',
} }

2
frontend/src/hooks/useDarkMode/index.tsx
View File

@ -30,7 +30,7 @@ export function ThemeProvider({ children }: ThemeProviderProps): JSX.Element {
setTheme(THEME_MODE.LIGHT); setTheme(THEME_MODE.LIGHT);
set(LOCALSTORAGE.THEME, THEME_MODE.LIGHT); set(LOCALSTORAGE.THEME, THEME_MODE.LIGHT);
} }
set(LOCALSTORAGE.THEME_ANALYTICS, ''); set(LOCALSTORAGE.THEME_ANALYTICS_V1, '');
}, [theme]); }, [theme]);
const value = useMemo( const value = useMemo(