From c55be0e392ecc1fa885b50ee6d49c8705f5d4279 Mon Sep 17 00:00:00 2001 From: Srikanth Chekuri Date: Wed, 25 Oct 2023 20:42:18 +0530 Subject: [PATCH] fix: promql alert expr formatting for composite queries with join/unless (#3784) Co-authored-by: Ankit Nayan --- pkg/query-service/rules/promRule.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/query-service/rules/promRule.go b/pkg/query-service/rules/promRule.go index 47c56d858c..25209b21c8 100644 --- a/pkg/query-service/rules/promRule.go +++ b/pkg/query-service/rules/promRule.go @@ -309,7 +309,7 @@ func (r *PromRule) getPqlQuery() (string, error) { if r.ruleCondition.Target != nil && r.ruleCondition.CompareOp != CompareOpNone { unitConverter := converter.FromUnit(converter.Unit(r.ruleCondition.TargetUnit)) value := unitConverter.Convert(converter.Value{F: *r.ruleCondition.Target, U: converter.Unit(r.ruleCondition.TargetUnit)}, converter.Unit(r.Unit())) - query = fmt.Sprintf("%s %s %f", query, ResolveCompareOp(r.ruleCondition.CompareOp), value.F) + query = fmt.Sprintf("(%s) %s %f", query, ResolveCompareOp(r.ruleCondition.CompareOp), value.F) return query, nil } else { return query, nil