GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-13 06:19:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: update page titles for dashboards and alerts (#6706)

Browse Source
This commit is contained in:
Nishanth Arcot 2025-01-17 14:32:41 +05:30 committed by GitHub
parent e9618d64bc
commit c66cd3ce4e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/pages/AlertDetails/AlertDetails.tsx
View File

@ -8,7 +8,7 @@ import RouteTab from 'components/RouteTab';
import Spinner from 'components/Spinner'; import Spinner from 'components/Spinner';
import ROUTES from 'constants/routes'; import ROUTES from 'constants/routes';
import history from 'lib/history'; import history from 'lib/history';
import { useMemo } from 'react'; import { useEffect, useMemo } from 'react';
import { useTranslation } from 'react-i18next'; import { useTranslation } from 'react-i18next';
import { useLocation } from 'react-router-dom'; import { useLocation } from 'react-router-dom';
@ -80,6 +80,11 @@ function AlertDetails(): JSX.Element {
alertDetailsResponse, alertDetailsResponse,
} = useGetAlertRuleDetails(); } = useGetAlertRuleDetails();
useEffect(() => {
const alertTitle = alertDetailsResponse?.payload?.data.alert;
document.title = alertTitle || document.title;
}, [alertDetailsResponse?.payload?.data.alert, isRefetching]);
if ( if (
isError || isError ||
!isValidRuleId || !isValidRuleId ||

6
frontend/src/pages/NewDashboard/DashboardPage.tsx
View File

@ -4,6 +4,7 @@ import NotFound from 'components/NotFound';
import Spinner from 'components/Spinner'; import Spinner from 'components/Spinner';
import NewDashboard from 'container/NewDashboard'; import NewDashboard from 'container/NewDashboard';
import { useDashboard } from 'providers/Dashboard/Dashboard'; import { useDashboard } from 'providers/Dashboard/Dashboard';
import { useEffect } from 'react';
import { ErrorType } from 'types/common'; import { ErrorType } from 'types/common';
function DashboardPage(): JSX.Element { function DashboardPage(): JSX.Element {
@ -17,6 +18,11 @@ function DashboardPage(): JSX.Element {
(dashboardResponse?.error as AxiosError)?.response?.data?.errorType (dashboardResponse?.error as AxiosError)?.response?.data?.errorType
: 'Something went wrong'; : 'Something went wrong';
useEffect(() => {
const dashboardTitle = dashboardResponse.data?.data.title;
document.title = dashboardTitle || document.title;
}, [dashboardResponse.data?.data.title, isFetching]);
if (isError && !isFetching && errorMessage === ErrorType.NotFound) { if (isError && !isFetching && errorMessage === ErrorType.NotFound) {
return <NotFound />; return <NotFound />;
} }