From c77ad88f90c4ea7ab777224d52e2cece02df766a Mon Sep 17 00:00:00 2001 From: Palash gupta Date: Fri, 20 May 2022 14:12:13 +0530 Subject: [PATCH] fix: getActiveKey is refactoring into switch --- .../container/MetricsApplication/index.tsx | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/frontend/src/container/MetricsApplication/index.tsx b/frontend/src/container/MetricsApplication/index.tsx index f72fa1c04b..9922fbb8c2 100644 --- a/frontend/src/container/MetricsApplication/index.tsx +++ b/frontend/src/container/MetricsApplication/index.tsx @@ -55,19 +55,20 @@ function ServiceMetrics(): JSX.Element { const externalMetrics = 'External Calls'; const getActiveKey = (): string => { - if (tab === null) { - return overMetrics; + switch (tab) { + case null: { + return overMetrics; + } + case dbCallMetrics: { + return dbCallMetrics; + } + case externalMetrics: { + return externalMetrics; + } + default: { + return overMetrics; + } } - - if (tab === dbCallMetrics) { - return dbCallMetrics; - } - - if (tab === externalMetrics) { - return externalMetrics; - } - - return overMetrics; }; const activeKey = getActiveKey();