GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-12 15:49:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: incorrect formula for apdex (#6460)

Browse Source
This commit is contained in:
Srikanth Chekuri 2024-11-19 11:12:04 +05:30 committed by GitHub
parent 98a350692b
commit c93cf1ce95
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/container/MetricsApplication/constant.ts
View File

@ -38,11 +38,12 @@ export enum FORMULA {
// query C => durationNano <= 2000ms // query C => durationNano <= 2000ms
// Since <= 2000ms includes <= 500ms, we over count, to correct we subtract B/2 // Since <= 2000ms includes <= 500ms, we over count, to correct we subtract B/2
// so the full expression would be (B + C/2) - B/2 = (B+C)/2 // so the full expression would be (B + C/2) - B/2 = (B+C)/2
// However, if you add a filter on durationNano > 500ms, (filterItemC in overviewQueries) the query would be
// B + C/2
APDEX_TRACES = '((B + C)/2)/A', APDEX_TRACES = '((B + C)/2)/A',
// Does the same not apply for delta span metrics? // The delta span metrics store delta compared to previous reporting interval
// No, because the delta metrics store the counts just for the current bucket // but not the counts for the current interval. The bucket counts are cumulative
// so we don't need to subtract anything APDEX_DELTA_SPAN_METRICS = '((B + C)/2)/A',
APDEX_DELTA_SPAN_METRICS = '(B + C)/A',
// Cumulative span metrics store the counts for all buckets // Cumulative span metrics store the counts for all buckets
// so we need to subtract B/2 to correct the over counting // so we need to subtract B/2 to correct the over counting
APDEX_CUMULATIVE_SPAN_METRICS = '((B + C)/2)/A', APDEX_CUMULATIVE_SPAN_METRICS = '((B + C)/2)/A',