From c480b3c56320873407ea7dc6a6efbafd6fde23fa Mon Sep 17 00:00:00 2001 From: Srikanth Chekuri Date: Thu, 19 May 2022 22:24:59 +0530 Subject: [PATCH 1/2] Add section outlining ideal workflow for significant features/changes (#1111) --- CONTRIBUTING.md | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 60aebdab98..54ff60451b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -143,6 +143,33 @@ curl -sL https://github.com/SigNoz/signoz/raw/main/sample-apps/hotrod/hotrod-del ## General Instructions +**Before making any significant changes, please open an issue**. Each issue +should describe the following: + +* Requirement - what kind of use case are you trying to solve? +* Proposal - what do you suggest to solve the problem or improve the existing + situation? +* Any open questions to address + +Discussing your proposed changes ahead of time will make the contribution +process smooth for everyone. Once the approach is agreed upon, make your changes +and open a pull request(s). Unless your change is small, Please consider submitting different PRs: + +* First PR should include the overall structure of the new component: + * Readme, configuration, interfaces or base classes etc... + * This PR is usually trivial to review, so the size limit does not apply to + it. +* Second PR should include the concrete implementation of the component. If the + size of this PR is larger than the recommended size consider splitting it in + multiple PRs. +* If there are multiple sub-component then ideally each one should be implemented as + a separate pull request. +* Last PR should include changes to any user facing documentation. And should include + end to end tests if applicable. The component must be enabled + only after sufficient testing, and there is enough confidence in the + stability and quality of the component. + + You can always reach out to `ankit@signoz.io` to understand more about the repo and product. We are very responsive over email and [slack](https://signoz.io/slack). - If you find any bugs, please create an issue From 3cc4fb9c30bb0fa740b84b8f48cc30919a0b6526 Mon Sep 17 00:00:00 2001 From: Palash gupta Date: Thu, 19 May 2022 23:15:12 +0530 Subject: [PATCH 2/2] fix: tsc is fixed --- .../NewWidget/LeftContainer/WidgetGraph/index.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/frontend/src/container/NewWidget/LeftContainer/WidgetGraph/index.tsx b/frontend/src/container/NewWidget/LeftContainer/WidgetGraph/index.tsx index df58ca6cf1..dc0945be84 100644 --- a/frontend/src/container/NewWidget/LeftContainer/WidgetGraph/index.tsx +++ b/frontend/src/container/NewWidget/LeftContainer/WidgetGraph/index.tsx @@ -5,6 +5,7 @@ import React, { memo } from 'react'; import { useSelector } from 'react-redux'; import { useLocation } from 'react-router-dom'; import { AppState } from 'store/reducers'; +import AppReducer from 'types/reducer/app'; import DashboardReducer from 'types/reducer/dashboards'; import { NewWidgetProps } from '../../index'; @@ -18,6 +19,7 @@ function WidgetGraph({ const { dashboards, isQueryFired } = useSelector( (state) => state.dashboards, ); + const { isDarkMode } = useSelector((state) => state.app); const [selectedDashboard] = dashboards; const { search } = useLocation(); @@ -31,7 +33,11 @@ function WidgetGraph({ const selectedWidget = widgets.find((e) => e.id === widgetId); if (selectedWidget === undefined) { - return Invalid widget; + return ( + + Invalid widget + + ); } const { queryData } = selectedWidget;