fix: tsc fixes

This commit is contained in:
Pranshu Chittora 2022-03-25 12:03:57 +05:30
parent ac70240b72
commit cc47f02ebf
No known key found for this signature in database
GPG Key ID: 3A9E57A016CC0626
18 changed files with 51 additions and 32 deletions

View File

@ -1,5 +1,6 @@
import { Chart, ChartType, Plugin } from 'chart.js'; import { Chart, ChartType, Plugin } from 'chart.js';
import { colors } from 'lib/getRandomColor'; import { colors } from 'lib/getRandomColor';
import { get } from 'lodash-es';
const getOrCreateLegendList = ( const getOrCreateLegendList = (
chart: Chart, chart: Chart,
@ -40,9 +41,20 @@ export const legend = (id: string, isLonger: boolean): Plugin<ChartType> => {
} }
// Reuse the built-in legendItems generator // Reuse the built-in legendItems generator
const items = chart?.options?.plugins?.legend?.labels?.generateLabels(chart); const items = get(chart, [
'options',
'plugins',
'legend',
'labels',
'generateLabels',
])
? get(chart, ['options', 'plugins', 'legend', 'labels', 'generateLabels'])(
chart,
)
: null;
items?.forEach((item, index) => { // eslint-disable-next-line @typescript-eslint/no-explicit-any
items?.forEach((item: Record<any, any>, index: number) => {
const li = document.createElement('li'); const li = document.createElement('li');
li.style.alignItems = 'center'; li.style.alignItems = 'center';
li.style.cursor = 'pointer'; li.style.cursor = 'pointer';
@ -66,8 +78,8 @@ export const legend = (id: string, isLonger: boolean): Plugin<ChartType> => {
// Color box // Color box
const boxSpan = document.createElement('span'); const boxSpan = document.createElement('span');
boxSpan.style.background = item.strokeStyle || colors[0]; boxSpan.style.background = `${item.strokeStyle}` || `${colors[0]}`;
boxSpan.style.borderColor = item?.strokeStyle; boxSpan.style.borderColor = `${item?.strokeStyle}`;
boxSpan.style.borderWidth = `${item.lineWidth}px`; boxSpan.style.borderWidth = `${item.lineWidth}px`;
boxSpan.style.display = 'inline-block'; boxSpan.style.display = 'inline-block';
boxSpan.style.minHeight = '20px'; boxSpan.style.minHeight = '20px';

View File

@ -6,8 +6,8 @@ import styled, { FlattenSimpleInterpolation } from 'styled-components';
import { IStyledClass } from './types'; import { IStyledClass } from './types';
const styledClass = (props: IStyledClass): FlattenSimpleInterpolation => const styledClass = (props: IStyledClass): FlattenSimpleInterpolation | null =>
props.styledclass; props.styledclass || null;
type TStyledCol = AntD.ColProps & IStyledClass; type TStyledCol = AntD.ColProps & IStyledClass;
const StyledCol = styled(AntD.Col)<TStyledCol>` const StyledCol = styled(AntD.Col)<TStyledCol>`

View File

@ -1,6 +1,7 @@
import { css, FlattenSimpleInterpolation } from 'styled-components'; import { css, FlattenSimpleInterpolation } from 'styled-components';
const cssProprty = (key: string, value): FlattenSimpleInterpolation => // eslint-disable-next-line @typescript-eslint/no-explicit-any
const cssProperty = (key: any, value: any): FlattenSimpleInterpolation =>
key && key &&
value && value &&
css` css`
@ -15,8 +16,8 @@ export const Flex = ({
flexDirection, flexDirection,
flex, flex,
}: IFlexProps): FlattenSimpleInterpolation => css` }: IFlexProps): FlattenSimpleInterpolation => css`
${cssProprty('flex-direction', flexDirection)} ${cssProperty('flex-direction', flexDirection)}
${cssProprty('flex', flex)} ${cssProperty('flex', flex)}
`; `;
interface IDisplayProps { interface IDisplayProps {
@ -25,7 +26,7 @@ interface IDisplayProps {
export const Display = ({ export const Display = ({
display, display,
}: IDisplayProps): FlattenSimpleInterpolation => css` }: IDisplayProps): FlattenSimpleInterpolation => css`
${cssProprty('display', display)} ${cssProperty('display', display)}
`; `;
interface ISpacingProps { interface ISpacingProps {
@ -36,6 +37,6 @@ export const Spacing = ({
margin, margin,
padding, padding,
}: ISpacingProps): FlattenSimpleInterpolation => css` }: ISpacingProps): FlattenSimpleInterpolation => css`
${cssProprty('margin', margin)} ${cssProperty('margin', margin)}
${cssProprty('padding', padding)} ${cssProperty('padding', padding)}
`; `;

View File

@ -1,5 +1,5 @@
import { FlattenSimpleInterpolation } from 'styled-components'; import { FlattenSimpleInterpolation } from 'styled-components';
export interface IStyledClass { export interface IStyledClass {
styledclass: FlattenSimpleInterpolation[]; styledclass?: FlattenSimpleInterpolation[];
} }

View File

@ -30,7 +30,7 @@ function Delete({ notifications, setChannels, id }: DeleteProps): JSX.Element {
} catch (error) { } catch (error) {
notifications.error({ notifications.error({
message: 'Error', message: 'Error',
description: error.toString() || 'Something went wrong', description: error instanceof Error ? error.toString() : 'Something went wrong',
}); });
setLoading(false); setLoading(false);
} }

View File

@ -60,6 +60,7 @@ function EmptyGraph({
return ( return (
<Graph <Graph
name=""
{...{ {...{
type: 'line', type: 'line',
onClickHandler, onClickHandler,

View File

@ -154,7 +154,8 @@ function GridGraph(): JSX.Element {
}); });
} catch (error) { } catch (error) {
notification.error({ notification.error({
message: error.toString() || 'Something went wrong', message:
error instanceof Error ? error.toString() : 'Something went wrong',
}); });
} }
} }

View File

@ -19,11 +19,11 @@ function YAxisUnitSelector({
fieldLabel, fieldLabel,
}: { }: {
defaultValue: string; defaultValue: string;
onSelect: (e: string | undefined) => void; onSelect: React.Dispatch<React.SetStateAction<string>>;
fieldLabel: string; fieldLabel: string;
}): JSX.Element { }): JSX.Element {
const onSelectHandler = (selectedValue: string): void => { const onSelectHandler = (selectedValue: string): void => {
onSelect(findCategoryByName(selectedValue)?.id); onSelect(findCategoryByName(selectedValue)?.id || '');
}; };
const options = flattenedCategories.map((options) => ({ const options = flattenedCategories.map((options) => ({
value: options.name, value: options.name,

View File

@ -1,4 +1,5 @@
import { StyledDiv } from 'components/Styled'; import { StyledDiv } from 'components/Styled';
import { ITraceMetaData } from 'container/GantChart';
import { IIntervalUnit, INTERVAL_UNITS } from 'container/TraceDetail/utils'; import { IIntervalUnit, INTERVAL_UNITS } from 'container/TraceDetail/utils';
import useThemeMode from 'hooks/useThemeMode'; import useThemeMode from 'hooks/useThemeMode';
import React, { useEffect, useRef, useState } from 'react'; import React, { useEffect, useRef, useState } from 'react';
@ -74,8 +75,7 @@ function Timeline({
{intervals && {intervals &&
intervals.map((interval, index) => ( intervals.map((interval, index) => (
<TimelineInterval <TimelineInterval
transform={`translate(${ transform={`translate(${TimelineHSpacing +
TimelineHSpacing +
(interval.percentage * (width - 2 * TimelineHSpacing)) / 100 (interval.percentage * (width - 2 * TimelineHSpacing)) / 100
},0)`} },0)`}
key={`${interval.label + interval.percentage + index}`} key={`${interval.label + interval.percentage + index}`}
@ -104,7 +104,7 @@ interface TimelineProps {
totalSpans: number; totalSpans: number;
levels: number; levels: number;
}; };
globalTraceMetadata: Record<string, number>; globalTraceMetadata: ITraceMetaData;
setIntervalUnit: React.Dispatch<React.SetStateAction<IIntervalUnit>>; setIntervalUnit: React.Dispatch<React.SetStateAction<IIntervalUnit>>;
} }

View File

@ -1,3 +1,4 @@
import { ITraceMetaData } from 'container/GantChart';
import { import {
IIntervalUnit, IIntervalUnit,
resolveTimeFromInterval, resolveTimeFromInterval,
@ -7,14 +8,12 @@ import { toFixed } from 'utils/toFixed';
import { Interval } from './types'; import { Interval } from './types';
type TMetaDataType = Record<string, never>;
export const getIntervalSpread = ({ export const getIntervalSpread = ({
localTraceMetaData, localTraceMetaData,
globalTraceMetadata, globalTraceMetadata,
}: { }: {
localTraceMetaData: TMetaDataType; localTraceMetaData: ITraceMetaData;
globalTraceMetadata: TMetaDataType; globalTraceMetadata: ITraceMetaData;
}): { }): {
baseInterval: number; baseInterval: number;
baseSpread: number; baseSpread: number;

View File

@ -9,7 +9,7 @@ import {
StyledTypography, StyledTypography,
} from 'components/Styled'; } from 'components/Styled';
import * as StyledStyles from 'components/Styled/styles'; import * as StyledStyles from 'components/Styled/styles';
import GanttChart from 'container/GantChart'; import GanttChart, { ITraceMetaData } from 'container/GantChart';
import { getNodeById } from 'container/GantChart/utils'; import { getNodeById } from 'container/GantChart/utils';
import Timeline from 'container/Timeline'; import Timeline from 'container/Timeline';
import TraceFlameGraph from 'container/TraceFlameGraph'; import TraceFlameGraph from 'container/TraceFlameGraph';
@ -55,7 +55,7 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element {
/* eslint-enable */ /* eslint-enable */
}, [treeData, spanServiceColors]); }, [treeData, spanServiceColors]);
const [globalTraceMetadata] = useState<Record<string, number>>({ const [globalTraceMetadata] = useState<ITraceMetaData>({
...traceMetaData, ...traceMetaData,
}); });
@ -129,7 +129,6 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element {
<Timeline <Timeline
globalTraceMetadata={globalTraceMetadata} globalTraceMetadata={globalTraceMetadata}
traceMetaData={traceMetaData} traceMetaData={traceMetaData}
intervalUnit={intervalUnit}
setIntervalUnit={setIntervalUnit} setIntervalUnit={setIntervalUnit}
/> />
</StyledCol> </StyledCol>

View File

@ -173,6 +173,8 @@ function TraceFlameGraph(props: {
onSpanSelect={onSpanSelect} onSpanSelect={onSpanSelect}
hoveredSpanId={hoveredSpanId} hoveredSpanId={hoveredSpanId}
selectedSpanId={selectedSpanId} selectedSpanId={selectedSpanId}
level={0}
parentLeftOffset={0}
/> />
</TraceFlameGraphContainer> </TraceFlameGraphContainer>
); );

View File

@ -31,7 +31,8 @@ export const DeleteDashboard = ({
dispatch({ dispatch({
type: 'DELETE_DASHBOARD_ERROR', type: 'DELETE_DASHBOARD_ERROR',
payload: { payload: {
errorMessage: error.toString() || 'Something went wrong', errorMessage:
error instanceof Error ? error.toString() : 'Something went wrong',
}, },
}); });
} }

View File

@ -64,7 +64,8 @@ export const GetDashboard = ({
dispatch({ dispatch({
type: 'GET_DASHBOARD_ERROR', type: 'GET_DASHBOARD_ERROR',
payload: { payload: {
errorMessage: error.toString() || 'Something went wrong', errorMessage:
error instanceof Error ? error.toString() : 'Something went wrong',
}, },
}); });
} }

View File

@ -42,7 +42,8 @@ export const UpdateDashboardTitleDescriptionTags = ({
dispatch({ dispatch({
type: 'UPDATE_TITLE_DESCRIPTION_TAGS_ERROR', type: 'UPDATE_TITLE_DESCRIPTION_TAGS_ERROR',
payload: { payload: {
errorMessage: error.toString() || 'Something went wrong', errorMessage:
error instanceof Error ? error.toString() : 'Something went wrong',
}, },
}); });
} }

View File

@ -19,7 +19,8 @@
"noEmit": true, "noEmit": true,
"baseUrl": "./src", "baseUrl": "./src",
"downlevelIteration": true, "downlevelIteration": true,
"plugins": [{ "name": "typescript-plugin-css-modules" }] "plugins": [{ "name": "typescript-plugin-css-modules" }],
"suppressImplicitAnyIndexErrors": true
}, },
"exclude": ["node_modules"], "exclude": ["node_modules"],
"include": ["./src"] "include": ["./src"]