GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-08-12 09:38:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: compare op outside bounds for anomaly alert (#6458)

Browse Source
This commit is contained in:
Srikanth Chekuri 2024-11-16 20:17:34 +05:30 committed by GitHub
parent 0acf39a532
commit cd1ec561b1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ee/query-service/rules/anomaly.go
View File

@ -61,6 +61,11 @@ func NewAnomalyRule(
zap.L().Info("creating new AnomalyRule", zap.String("id", id), zap.Any("opts", opts)) zap.L().Info("creating new AnomalyRule", zap.String("id", id), zap.Any("opts", opts))
if p.RuleCondition.CompareOp == baserules.ValueIsBelow {
target := -1 * *p.RuleCondition.Target
p.RuleCondition.Target = &target
}
baseRule, err := baserules.NewBaseRule(id, p, reader, opts...) baseRule, err := baserules.NewBaseRule(id, p, reader, opts...)
if err != nil { if err != nil {
return nil, err return nil, err

4
frontend/src/container/FormAlertRules/RuleOptions.tsx
View File

@ -102,9 +102,9 @@ function RuleOptions({
<Select.Option value="4">{t('option_notequal')}</Select.Option> <Select.Option value="4">{t('option_notequal')}</Select.Option>
</> </>
)} )}
{/* the value 5 and 6 are reserved for above or equal and below or equal */}
{ruleType === 'anomaly_rule' && ( {ruleType === 'anomaly_rule' && (
<Select.Option value="5">{t('option_above_below')}</Select.Option> <Select.Option value="7">{t('option_above_below')}</Select.Option>
)} )}
</InlineSelect> </InlineSelect>
); );

4
pkg/query-service/rules/base_rule.go
View File

@ -463,9 +463,9 @@ func (r *BaseRule) ShouldAlert(series v3.Series) (Sample, bool) {
} }
} else if r.compareOp() == ValueOutsideBounds { } else if r.compareOp() == ValueOutsideBounds {
for _, smpl := range series.Points { for _, smpl := range series.Points {
if math.Abs(smpl.Value) >= r.targetVal() { if math.Abs(smpl.Value) < r.targetVal() {
alertSmpl = Sample{Point: Point{V: smpl.Value}, Metric: lbls} alertSmpl = Sample{Point: Point{V: smpl.Value}, Metric: lbls}
shouldAlert = true shouldAlert = false
break break
} }
} }