bug: unused import is removed and two unwanted eslint rule is removed (#968)

This commit is contained in:
palash-signoz 2022-04-08 14:05:16 +05:30 committed by GitHub
parent 60288f7ba0
commit d102c94670
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 19 additions and 15 deletions

View File

@ -105,8 +105,6 @@ module.exports = {
// eslint rules need to remove
'no-shadow': 'off',
'@typescript-eslint/no-shadow': 'off',
'global-require': 'off',
'@typescript-eslint/no-var-requires': 'off',
'import/no-cycle': 'off',
'prettier/prettier': [

View File

@ -1,5 +1,4 @@
import { Select } from 'antd';
import { DefaultOptionType } from 'antd/lib/select';
import getTagValue from 'api/trace/getTagValue';
import useFetch from 'hooks/useFetch';
import React from 'react';
@ -9,7 +8,6 @@ import { PayloadProps, Props } from 'types/api/trace/getTagValue';
import { GlobalReducer } from 'types/reducer/globalTime';
import { TraceReducer } from 'types/reducer/trace';
import { Value } from '.';
import { SelectComponent } from './styles';
function TagValue(props: TagValueProps): JSX.Element {

View File

@ -25,7 +25,6 @@ function TraceTable(): JSX.Element {
selectedTags,
filterLoading,
userSelectedFilter,
filter,
isFilterExclude,
filterToFetchData,
} = useSelector<AppState, TraceReducer>((state) => state.traces);

View File

@ -2,7 +2,6 @@ import getTriggeredApi from 'api/alerts/getTriggered';
import Spinner from 'components/Spinner';
import { State } from 'hooks/useFetch';
import React, { useCallback, useEffect, useState } from 'react';
import { Alerts } from 'types/api/alerts/getAll';
import { PayloadProps } from 'types/api/alerts/getTriggered';
import TriggerComponent from './TriggeredAlert';

View File

@ -1,15 +1,17 @@
/* eslint-disable global-require */
/// <reference types="@welldone-software/why-did-you-render" />
// ^ https://github.com/welldone-software/why-did-you-render/issues/161
import React from 'react';
if (process.env.NODE_ENV === 'development') {
const whyDidYouRender = require('@welldone-software/why-did-you-render');
whyDidYouRender(React, {
trackAllPureComponents: false,
trackExtraHooks: [[require('react-redux/lib'), 'useSelector']],
include: [/^ConnectFunction/],
logOnDifferentValues: true,
import('@welldone-software/why-did-you-render').then((whyDidYouRender) => {
whyDidYouRender.default(React, {
trackAllPureComponents: true,
trackHooks: true,
// https://github.com/welldone-software/why-did-you-render/issues/85#issuecomment-596682587
trackExtraHooks: [require('react-redux/lib'), 'useSelector'],
include: [/^ConnectFunction/],
logOnDifferentValues: true,
});
});
}
export default '';

View File

@ -22,5 +22,13 @@
"plugins": [{ "name": "typescript-plugin-css-modules" }]
},
"exclude": ["node_modules"],
"include": ["./src", "./babel.config.js", "./jest.config.ts"]
"include": [
"./src",
"./babel.config.js",
"./jest.config.ts",
"./.eslintrc.js",
"./__mocks__",
"./conf/default.conf",
"./public"
]
}