From d62b1cf49f443da67fea67f8ff7e86e175c7d79e Mon Sep 17 00:00:00 2001 From: ahmadshaheer Date: Mon, 2 Jun 2025 09:15:20 +0430 Subject: [PATCH] chore: remove p99_latency references from funnel metrics --- frontend/src/api/traceFunnels/index.ts | 2 -- frontend/src/hooks/TracesFunnels/useFunnelMetrics.ts | 9 ++------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/frontend/src/api/traceFunnels/index.ts b/frontend/src/api/traceFunnels/index.ts index d4c3b8ccca..c93a3c058f 100644 --- a/frontend/src/api/traceFunnels/index.ts +++ b/frontend/src/api/traceFunnels/index.ts @@ -196,8 +196,6 @@ export interface FunnelOverviewResponse { avg_rate: number; conversion_rate: number | null; errors: number; - // TODO(shaheer): remove p99_latency once we have support for latency - p99_latency: number; latency: number; }; }>; diff --git a/frontend/src/hooks/TracesFunnels/useFunnelMetrics.ts b/frontend/src/hooks/TracesFunnels/useFunnelMetrics.ts index db4a13e446..566ded55b6 100644 --- a/frontend/src/hooks/TracesFunnels/useFunnelMetrics.ts +++ b/frontend/src/hooks/TracesFunnels/useFunnelMetrics.ts @@ -49,11 +49,7 @@ export function useFunnelMetrics({ }, { title: `P99 Latency`, - value: getYAxisFormattedValue( - // TODO(shaheer): remove p99_latency once we have support for latency - (sourceData.latency ?? sourceData.p99_latency).toString(), - 'ms', - ), + value: getYAxisFormattedValue(sourceData.latency.toString(), 'ms'), }, ]; }, [overviewData?.payload?.data]); @@ -119,8 +115,7 @@ export function useFunnelStepsMetrics({ { title: `${latencyType?.toUpperCase()} Latency`, value: getYAxisFormattedValue( - // TODO(shaheer): remove p99_latency once we have support for latency - ((sourceData.latency ?? sourceData.p99_latency) * 1_000_000).toString(), + (sourceData.latency * 1_000_000).toString(), 'ns', ), },