diff --git a/go.mod b/go.mod index 1563caae79..e127130b46 100644 --- a/go.mod +++ b/go.mod @@ -203,4 +203,4 @@ require ( k8s.io/utils v0.0.0-20230711102312-30195339c3c7 // indirect ) -replace github.com/prometheus/prometheus => github.com/SigNoz/prometheus v1.9.79-0.1 +replace github.com/prometheus/prometheus => github.com/SigNoz/prometheus v1.10.1 diff --git a/go.sum b/go.sum index 08debabfed..8bde7c4b6f 100644 --- a/go.sum +++ b/go.sum @@ -96,8 +96,8 @@ github.com/OneOfOne/xxhash v1.2.2 h1:KMrpdQIwFcEqXDklaen+P1axHaj9BSKzvpUUfnHldSE github.com/OneOfOne/xxhash v1.2.2/go.mod h1:HSdplMjZKSmBqAxg5vPj2TmRDmfkzw+cTzAElWljhcU= github.com/SigNoz/govaluate v0.0.0-20240203125216-988004ccc7fd h1:Bk43AsDYe0fhkbj57eGXx8H3ZJ4zhmQXBnrW523ktj8= github.com/SigNoz/govaluate v0.0.0-20240203125216-988004ccc7fd/go.mod h1:nxRcH/OEdM8QxzH37xkGzomr1O0JpYBRS6pwjsWW6Pc= -github.com/SigNoz/prometheus v1.9.79-0.1 h1:RjsOw7oXVKx7IDA+/sRXW2x5pnw60/tT9MMuEz3+8DU= -github.com/SigNoz/prometheus v1.9.79-0.1/go.mod h1:MffmFu2qFILQrOHehx3D0XjYtaZMVfI+Ppeiv98x4Ww= +github.com/SigNoz/prometheus v1.10.1 h1:2LKRtPDMgSJpgDRDy0GUQiXi+yhDNqcbptuEon4Wpls= +github.com/SigNoz/prometheus v1.10.1/go.mod h1:MffmFu2qFILQrOHehx3D0XjYtaZMVfI+Ppeiv98x4Ww= github.com/SigNoz/signoz-otel-collector v0.88.17 h1:XN3PwlI94LUOTXjXCPaVgQnGNdXnz7p40GKVWhOjlkQ= github.com/SigNoz/signoz-otel-collector v0.88.17/go.mod h1:PThU+A6SgzEotT3ngKN4WVGWW0+eS7F1a2Rnq11aZZA= github.com/SigNoz/zap_otlp v0.1.0 h1:T7rRcFN87GavY8lDGZj0Z3Xv6OhJA6Pj3I9dNPmqvRc= diff --git a/pkg/query-service/app/clickhouseReader/wrapper.go b/pkg/query-service/app/clickhouseReader/wrapper.go index 6c75fa4b20..2691d961eb 100644 --- a/pkg/query-service/app/clickhouseReader/wrapper.go +++ b/pkg/query-service/app/clickhouseReader/wrapper.go @@ -2,8 +2,7 @@ package clickhouseReader import ( "context" - "fmt" - "strings" + "encoding/json" "github.com/ClickHouse/clickhouse-go/v2" "github.com/ClickHouse/clickhouse-go/v2/lib/driver" @@ -37,11 +36,7 @@ func (c clickhouseConnWrapper) logComment(ctx context.Context) context.Context { return ctx } - logComment := "" - for k, v := range logCommentKVs { - logComment += fmt.Sprintf("%s=%s, ", k, v) - } - logComment = strings.TrimSuffix(logComment, ", ") + logComment, _ := json.Marshal(logCommentKVs) ctx = clickhouse.Context(ctx, clickhouse.WithSettings(clickhouse.Settings{ "log_comment": logComment, diff --git a/pkg/query-service/rules/promRuleTask.go b/pkg/query-service/rules/promRuleTask.go index af38488f7c..e74106266d 100644 --- a/pkg/query-service/rules/promRuleTask.go +++ b/pkg/query-service/rules/promRuleTask.go @@ -335,6 +335,13 @@ func (g *PromRuleTask) Eval(ctx context.Context, ts time.Time) { rule.SetEvaluationTimestamp(t) }(time.Now()) + kvs := map[string]string{ + "alertID": rule.ID(), + "source": "alerts", + "client": "query-service", + } + ctx = context.WithValue(ctx, "log_comment", kvs) + _, err := rule.Eval(ctx, ts, g.opts.Queriers) if err != nil { rule.SetHealth(HealthBad)