From dc7a55e8714f61a4c7ee7965760c0e09dc4fce0e Mon Sep 17 00:00:00 2001
From: Rajat Dabade <rajat@signoz.io>
Date: Thu, 16 Nov 2023 12:51:35 +0530
Subject: [PATCH] [Fix]: Threshold in dashboard fixes  (#3979)

* fix: the extra showcase for text and background

* fix: css issue for select
---
 .../RightContainer/Threshold/Threshold.tsx    | 23 +++++++++----------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/frontend/src/container/NewWidget/RightContainer/Threshold/Threshold.tsx b/frontend/src/container/NewWidget/RightContainer/Threshold/Threshold.tsx
index bc8fc60119..7117c33657 100644
--- a/frontend/src/container/NewWidget/RightContainer/Threshold/Threshold.tsx
+++ b/frontend/src/container/NewWidget/RightContainer/Threshold/Threshold.tsx
@@ -237,7 +237,7 @@ function Threshold({
 							)}
 							{isEditMode ? (
 								<Select
-									style={{ maxWidth: '200px', backgroundColor: '#141414' }}
+									style={{ minWidth: '200px', backgroundColor: '#141414' }}
 									bordered={false}
 									defaultValue={unit}
 									options={unitOptions}
@@ -253,22 +253,21 @@ function Threshold({
 						<Space direction="vertical">
 							<Typography.Text>Show with</Typography.Text>
 							<Space>
-								{isEditMode ? (
+								{isEditMode && selectedGraph === PANEL_TYPES.TIME_SERIES ? (
 									<ColorSelector setColor={setColor} thresholdColor={color} />
 								) : (
 									<ShowCaseValue width="100px" value={<CustomColor color={color} />} />
 								)}
 								{isEditMode && selectedGraph === PANEL_TYPES.VALUE ? (
-									<>
-										<Select
-											style={{ minWidth: '100px' }}
-											defaultValue={format}
-											options={showAsOptions}
-											onChange={handlerFormatChange}
-										/>
-										<ShowCaseValue width="100px" value={format} />
-									</>
-								) : null}
+									<Select
+										style={{ minWidth: '100px' }}
+										defaultValue={format}
+										options={showAsOptions}
+										onChange={handlerFormatChange}
+									/>
+								) : (
+									<ShowCaseValue width="100px" value={format} />
+								)}
 							</Space>
 						</Space>
 					</div>