feat: onClick in new tab is added (#842)

This commit is contained in:
palash-signoz 2022-03-16 23:26:45 +05:30 committed by GitHub
parent a238123eb2
commit e28733d246
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions

View File

@ -3,7 +3,6 @@ import localStorageGet from 'api/browser/localstorage/get';
import localStorageSet from 'api/browser/localstorage/set'; import localStorageSet from 'api/browser/localstorage/set';
import { SKIP_ONBOARDING } from 'constants/onboarding'; import { SKIP_ONBOARDING } from 'constants/onboarding';
import ROUTES from 'constants/routes'; import ROUTES from 'constants/routes';
import history from 'lib/history';
import React, { useState } from 'react'; import React, { useState } from 'react';
import { useSelector } from 'react-redux'; import { useSelector } from 'react-redux';
import { servicesListItem } from 'store/actions/MetricsActions/metricsInterfaces'; import { servicesListItem } from 'store/actions/MetricsActions/metricsInterfaces';
@ -28,7 +27,7 @@ const Metrics = (): JSX.Element => {
}; };
const onClickHandler = (to: string): void => { const onClickHandler = (to: string): void => {
history.push(to); window.open(to, '_blank');
}; };
if ( if (

View File

@ -119,10 +119,7 @@ const TraceTable = ({ getSpansAggregate }: TraceProps): JSX.Element => {
columns={columns} columns={columns}
onRow={(record) => ({ onRow={(record) => ({
onClick: (): void => { onClick: (): void => {
history.push({ window.open(`${ROUTES.TRACE}/${record.traceID}?spanId=${record.spanID}`);
pathname: ROUTES.TRACE + '/' + record.traceID,
search: '?' + 'spanId=' + record.spanID,
});
}, },
})} })}
size="middle" size="middle"