From 872c8adbbb3b6e61d4347f9dde5f3c4cff291aa0 Mon Sep 17 00:00:00 2001 From: Nidhi Tandon Date: Mon, 31 May 2021 21:06:39 +0530 Subject: [PATCH] feat: update response param p90 to p95 --- frontend/src/modules/Metrics/TopEndpointsTable.tsx | 8 ++++---- frontend/src/modules/Traces/TraceCustomVisualizations.tsx | 2 +- frontend/src/store/actions/metrics.ts | 2 +- frontend/src/store/reducers/metrics.ts | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/frontend/src/modules/Metrics/TopEndpointsTable.tsx b/frontend/src/modules/Metrics/TopEndpointsTable.tsx index 6ab2022574..ae0336b1b0 100644 --- a/frontend/src/modules/Metrics/TopEndpointsTable.tsx +++ b/frontend/src/modules/Metrics/TopEndpointsTable.tsx @@ -85,10 +85,10 @@ const _TopEndpointsTable = (props: TopEndpointsTableProps) => { render: (value: number) => (value / 1000000).toFixed(2), }, { - title: "P90 (in ms)", - dataIndex: "p90", - key: "p90", - sorter: (a: any, b: any) => a.p90 - b.p90, + title: "P95 (in ms)", + dataIndex: "p95", + key: "p95", + sorter: (a: any, b: any) => a.p95 - b.p95, // sortDirections: ['descend', 'ascend'], render: (value: number) => (value / 1000000).toFixed(2), }, diff --git a/frontend/src/modules/Traces/TraceCustomVisualizations.tsx b/frontend/src/modules/Traces/TraceCustomVisualizations.tsx index baf3271c64..728fa3e741 100644 --- a/frontend/src/modules/Traces/TraceCustomVisualizations.tsx +++ b/frontend/src/modules/Traces/TraceCustomVisualizations.tsx @@ -52,7 +52,7 @@ const aggregation_options = [ // options_available: [ {title:'Avg', dataindex:'avg'}, {title:'Max', dataindex:'max'},{title:'Min', dataindex:'min'}, {title:'p50', dataindex:'p50'},{title:'p90', dataindex:'p90'}, {title:'p95', dataindex:'p95'}] options_available: [ { title: "p50", dataindex: "p50" }, - { title: "p90", dataindex: "p90" }, + { title: "p95", dataindex: "p95" }, { title: "p99", dataindex: "p99" }, ], }, diff --git a/frontend/src/store/actions/metrics.ts b/frontend/src/store/actions/metrics.ts index 2643f9028f..c4d8bc0676 100644 --- a/frontend/src/store/actions/metrics.ts +++ b/frontend/src/store/actions/metrics.ts @@ -40,7 +40,7 @@ export interface externalErrCodeMetricsItem { } export interface topEndpointListItem { p50: number; - p90: number; + p95: number; p99: number; numCalls: number; name: string; diff --git a/frontend/src/store/reducers/metrics.ts b/frontend/src/store/reducers/metrics.ts index f1afd73738..4e45077448 100644 --- a/frontend/src/store/reducers/metrics.ts +++ b/frontend/src/store/reducers/metrics.ts @@ -38,7 +38,7 @@ export const serviceMetricsReducer = ( { timestamp: 0, p50: 0, - p90: 0, + p95: 0, p99: 0, numCalls: 0, callRate: 0.0, @@ -58,7 +58,7 @@ export const serviceMetricsReducer = ( export const topEndpointsReducer = ( state: topEndpointListItem[] = [ - { p50: 0, p90: 0, p99: 0, numCalls: 0, name: "" }, + { p50: 0, p95: 0, p99: 0, numCalls: 0, name: "" }, ], action: Action, ) => {