chore: limit is enabled (#3159)

* chore: limit is enabled

* chore: tooltip is updated

---------

Co-authored-by: Vishal Sharma <makeavish786@gmail.com>
This commit is contained in:
Palash Gupta 2023-07-17 22:31:30 +05:30 committed by GitHub
parent fea8a71f51
commit f3817d7335
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,8 +1,8 @@
import { InputNumber, Tooltip } from 'antd'; import { InputNumber } from 'antd';
// import { useMemo } from 'react'; import { useMemo } from 'react';
import { IBuilderQuery } from 'types/api/queryBuilder/queryBuilderData'; import { IBuilderQuery } from 'types/api/queryBuilder/queryBuilderData';
import { DataSource } from 'types/common/queryBuilder';
// import { DataSource } from 'types/common/queryBuilder';
import { selectStyle } from '../QueryBuilderSearch/config'; import { selectStyle } from '../QueryBuilderSearch/config';
function LimitFilter({ onChange, query }: LimitFilterProps): JSX.Element { function LimitFilter({ onChange, query }: LimitFilterProps): JSX.Element {
@ -21,25 +21,23 @@ function LimitFilter({ onChange, query }: LimitFilterProps): JSX.Element {
} }
}; };
// const isMetricsDataSource = useMemo( const isMetricsDataSource = useMemo(
// () => query.dataSource === DataSource.METRICS, () => query.dataSource === DataSource.METRICS,
// [query.dataSource], [query.dataSource],
// ); );
// const isDisabled = isMetricsDataSource && !query.aggregateAttribute.key; const isDisabled = isMetricsDataSource && !query.aggregateAttribute.key;
return ( return (
<Tooltip placement="top" title="coming soon"> <InputNumber
<InputNumber min={1}
min={1} type="number"
type="number" value={query.limit}
readOnly style={selectStyle}
value={query.limit} disabled={isDisabled}
style={selectStyle} onChange={onChange}
onChange={onChange} onKeyDown={handleKeyDown}
onKeyDown={handleKeyDown} />
/>
</Tooltip>
); );
} }