From f4d029bd120595ab659d1eddeb129a48cfec7885 Mon Sep 17 00:00:00 2001 From: Shivanshu Raj Shrivastava Date: Mon, 5 May 2025 13:57:09 +0530 Subject: [PATCH] fix: correctly populate response_status (#7822) Signed-off-by: Shivanshu Raj Shrivastava --- .../src/container/ApiMonitoring/APIMonitoringUtils.test.tsx | 2 +- .../Explorer/Domains/DomainDetails/constants.ts | 1 - frontend/src/container/ApiMonitoring/utils.tsx | 6 +++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/frontend/src/container/ApiMonitoring/APIMonitoringUtils.test.tsx b/frontend/src/container/ApiMonitoring/APIMonitoringUtils.test.tsx index eec8c2fbab..4632e02938 100644 --- a/frontend/src/container/ApiMonitoring/APIMonitoringUtils.test.tsx +++ b/frontend/src/container/ApiMonitoring/APIMonitoringUtils.test.tsx @@ -411,7 +411,7 @@ describe('API Monitoring Utils', () => { const statusFilter = result.items.find( (item) => item.key && - item.key.key === SPAN_ATTRIBUTES.STATUS_CODE && + item.key.key === SPAN_ATTRIBUTES.RESPONSE_STATUS_CODE && item.value === statusCode, ); expect(statusFilter).toBeDefined(); diff --git a/frontend/src/container/ApiMonitoring/Explorer/Domains/DomainDetails/constants.ts b/frontend/src/container/ApiMonitoring/Explorer/Domains/DomainDetails/constants.ts index 8b5b433bed..da6a7dd4c7 100644 --- a/frontend/src/container/ApiMonitoring/Explorer/Domains/DomainDetails/constants.ts +++ b/frontend/src/container/ApiMonitoring/Explorer/Domains/DomainDetails/constants.ts @@ -13,7 +13,6 @@ export const VIEW_TYPES = { // Span attribute keys - these are the source of truth for all attribute keys export const SPAN_ATTRIBUTES = { URL_PATH: 'http.url', - STATUS_CODE: 'status_code', RESPONSE_STATUS_CODE: 'response_status_code', SERVER_NAME: 'net.peer.name', SERVER_PORT: 'net.peer.port', diff --git a/frontend/src/container/ApiMonitoring/utils.tsx b/frontend/src/container/ApiMonitoring/utils.tsx index 594dedb276..22b74aa7e4 100644 --- a/frontend/src/container/ApiMonitoring/utils.tsx +++ b/frontend/src/container/ApiMonitoring/utils.tsx @@ -1438,12 +1438,12 @@ export const getTopErrorsCoRelationQueryFilters = ( { id: 'f6891e27', key: { - key: 'status_code', - dataType: DataTypes.Float64, + key: 'response_status_code', + dataType: DataTypes.String, type: '', isColumn: true, isJSON: false, - id: 'status_code--float64----true', + id: 'response_status_code--string----true', }, op: '=', value: statusCode,