diff --git a/frontend/src/container/TraceDetail/Missingtrace.tsx b/frontend/src/container/TraceDetail/Missingtrace.tsx index eb0620a4ed..0d2e91b5d7 100644 --- a/frontend/src/container/TraceDetail/Missingtrace.tsx +++ b/frontend/src/container/TraceDetail/Missingtrace.tsx @@ -1,6 +1,6 @@ import { volcano } from '@ant-design/colors'; import { InfoCircleOutlined } from '@ant-design/icons'; -import { Popover } from 'antd'; +import { Popover, Typography } from 'antd'; import React from 'react'; function PopOverContent(): JSX.Element { @@ -21,19 +21,10 @@ function PopOverContent(): JSX.Element { function MissingSpansMessage(): JSX.Element { return ( -
- {' '} + + This trace has missing spans -
+
); } diff --git a/frontend/src/container/TraceDetail/SelectedSpanDetails/index.tsx b/frontend/src/container/TraceDetail/SelectedSpanDetails/index.tsx index c39346d315..d6c37783a1 100644 --- a/frontend/src/container/TraceDetail/SelectedSpanDetails/index.tsx +++ b/frontend/src/container/TraceDetail/SelectedSpanDetails/index.tsx @@ -1,4 +1,4 @@ -import { Modal, Tabs, Tooltip } from 'antd'; +import { Modal, Tabs, Tooltip, Typography } from 'antd'; import Editor from 'components/Editor'; import { StyledSpace } from 'components/Styled'; import { useIsDarkMode } from 'hooks/useDarkMode'; @@ -49,9 +49,8 @@ function SelectedSpanDetails(props: SelectedSpanDetailsProps): JSX.Element { - Details for selected Span + Details for selected Span Service diff --git a/frontend/src/container/TraceDetail/index.tsx b/frontend/src/container/TraceDetail/index.tsx index efcf406cd2..d433a12913 100644 --- a/frontend/src/container/TraceDetail/index.tsx +++ b/frontend/src/container/TraceDetail/index.tsx @@ -1,5 +1,5 @@ import { FilterOutlined } from '@ant-design/icons'; -import { Button, Col } from 'antd'; +import { Button, Col, Typography } from 'antd'; import { StyledCol, StyledDiv, @@ -95,14 +95,10 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element { } }, [activeSelectedId, levelDown, levelUp]); - const getSelectedNode = useMemo(() => { - return getNodeById(activeSelectedId, treesData); - }, [activeSelectedId, treesData]); - - // const onSearchHandler = (value: string) => { - // setSearchSpanString(value); - // setTreeData(spanToTreeUtil(response[0].events)); - // }; + const getSelectedNode = useMemo( + () => getNodeById(activeSelectedId, treesData), + [activeSelectedId, treesData], + ); const onFocusSelectedSpanHandler = (): void => { const treeNode = getNodeById(activeSelectedId, tree); @@ -124,6 +120,8 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element { [tree], ); + const isGlobalTimeVisible = tree && traceMetaData.globalStart; + return ( @@ -141,57 +139,49 @@ function TraceDetail({ response }: TraceDetailProps): JSX.Element { {hasMissingSpans && } - {map(tree.spanTree, (tree) => { - return ( - - ); - })} + {map(tree.spanTree, (tree) => ( + + ))} {hasMissingSpans && ( - {map(tree.missingSpanTree, (tree) => { - return ( - - ); - })} + {map(tree.missingSpanTree, (tree) => ( + + ))} )} - - {tree && - traceMetaData.globalStart && - dayjs(traceMetaData.globalStart).format('hh:mm:ss a MM/DD')} - + {isGlobalTimeVisible && ( + + + {dayjs(traceMetaData.globalStart).format('hh:mm:ss a MM/DD')} + + + )} + ))} - {/* {map(tree.missingSpanTree, (tree) => ( - - ))} */} diff --git a/frontend/src/container/TraceDetail/styles.ts b/frontend/src/container/TraceDetail/styles.ts index b69b27bb26..83dd9864e1 100644 --- a/frontend/src/container/TraceDetail/styles.ts +++ b/frontend/src/container/TraceDetail/styles.ts @@ -1,4 +1,5 @@ import { volcano } from '@ant-design/colors'; +import { Col } from 'antd'; import styled, { css } from 'styled-components'; /** @@ -113,3 +114,9 @@ export const FlameGraphMissingSpansContainer = styled.div` margin-top: 1rem; border-radius: 0.25rem; `; + +export const TimeStampContainer = styled(Col)` + display: flex; + align-items: center; + justify-content: center; +`;