From ffae767fabb044fa0623603aa595cb0e91ffd698 Mon Sep 17 00:00:00 2001
From: palash-signoz <palash@signoz.io>
Date: Wed, 4 May 2022 19:16:30 +0530
Subject: [PATCH] chore: edit widget is allowed for admin and editor (#1074)

---
 .../GridGraphLayout/WidgetHeader/index.tsx     | 18 ++++++++++++------
 frontend/src/utils/permission/index.ts         |  4 +++-
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/frontend/src/container/GridGraphLayout/WidgetHeader/index.tsx b/frontend/src/container/GridGraphLayout/WidgetHeader/index.tsx
index 617ad45f81..a627bac3e1 100644
--- a/frontend/src/container/GridGraphLayout/WidgetHeader/index.tsx
+++ b/frontend/src/container/GridGraphLayout/WidgetHeader/index.tsx
@@ -65,7 +65,10 @@ function WidgetHeader({
 	};
 	const { role } = useSelector<AppState, AppReducer>((state) => state.app);
 
-	const [deleteWidget] = useComponentPermission(['delete_widget'], role);
+	const [deleteWidget, editWidget] = useComponentPermission(
+		['delete_widget', 'edit_widget'],
+		role,
+	);
 
 	const menu = (
 		<Menu onClick={onMenuItemSelectHandler}>
@@ -74,11 +77,14 @@ function WidgetHeader({
 					<span>View</span> <FullscreenOutlined />
 				</MenuItemContainer>
 			</Menu.Item>
-			<Menu.Item key={keyMethodMapping.edit.key}>
-				<MenuItemContainer>
-					<span>Edit</span> <EditFilled />
-				</MenuItemContainer>
-			</Menu.Item>
+
+			{editWidget && (
+				<Menu.Item key={keyMethodMapping.edit.key}>
+					<MenuItemContainer>
+						<span>Edit</span> <EditFilled />
+					</MenuItemContainer>
+				</Menu.Item>
+			)}
 
 			{deleteWidget && (
 				<>
diff --git a/frontend/src/utils/permission/index.ts b/frontend/src/utils/permission/index.ts
index 742fc8f66b..71d8b09c39 100644
--- a/frontend/src/utils/permission/index.ts
+++ b/frontend/src/utils/permission/index.ts
@@ -13,7 +13,8 @@ export type ComponentTypes =
 	| 'action'
 	| 'save_layout'
 	| 'edit_dashboard'
-	| 'delete_widget';
+	| 'delete_widget'
+	| 'edit_widget';
 
 export const componentPermission: Record<ComponentTypes, ROLES[]> = {
 	current_org_settings: ['ADMIN'],
@@ -28,6 +29,7 @@ export const componentPermission: Record<ComponentTypes, ROLES[]> = {
 	save_layout: ['ADMIN', 'EDITOR'],
 	edit_dashboard: ['ADMIN', 'EDITOR'],
 	delete_widget: ['ADMIN', 'EDITOR'],
+	edit_widget: ['ADMIN', 'EDITOR'],
 };
 
 export const routePermission: Record<keyof typeof ROUTES, ROLES[]> = {