GitHub-Proxy/signoz
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz synced 2025-07-31 19:52:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1118 from palash-signoz/application-metrics-error-handling

Browse Source 
fix: error is now handled and displayed as antd notification message in /application
This commit is contained in:
palash-signoz 2022-05-19 15:19:25 +05:30 committed by GitHub
commit ffd5621f09
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
frontend/src/pages/Metrics/index.tsx
View File

@ -1,3 +1,4 @@
import { notification } from 'antd';
import getLocalStorageKey from 'api/browser/localstorage/get'; import getLocalStorageKey from 'api/browser/localstorage/get';
import Spinner from 'components/Spinner'; import Spinner from 'components/Spinner';
import { SKIP_ONBOARDING } from 'constants/onboarding'; import { SKIP_ONBOARDING } from 'constants/onboarding';
@ -20,10 +21,20 @@ function Metrics({ getService }: MetricsProps): JSX.Element {
AppState, AppState,
GlobalReducer GlobalReducer
>((state) => state.globalTime); >((state) => state.globalTime);
const { services, resourceAttributeQueries } = useSelector< const {
AppState, services,
MetricReducer resourceAttributeQueries,
>((state) => state.metrics); error,
errorMessage,
} = useSelector<AppState, MetricReducer>((state) => state.metrics);
useEffect(() => {
if (error) {
notification.error({
message: errorMessage,
});
}
}, [error, errorMessage]);
const selectedTags = useMemo( const selectedTags = useMemo(
() => () =>