package rules import ( "bytes" "context" "encoding/json" "fmt" "math" "net/url" "regexp" "sort" "text/template" "time" "unicode" "go.uber.org/zap" "go.signoz.io/signoz/pkg/query-service/common" "go.signoz.io/signoz/pkg/query-service/model" "go.signoz.io/signoz/pkg/query-service/postprocess" "go.signoz.io/signoz/pkg/query-service/app/querier" querierV2 "go.signoz.io/signoz/pkg/query-service/app/querier/v2" "go.signoz.io/signoz/pkg/query-service/app/queryBuilder" "go.signoz.io/signoz/pkg/query-service/constants" "go.signoz.io/signoz/pkg/query-service/interfaces" v3 "go.signoz.io/signoz/pkg/query-service/model/v3" "go.signoz.io/signoz/pkg/query-service/utils/labels" querytemplate "go.signoz.io/signoz/pkg/query-service/utils/queryTemplate" "go.signoz.io/signoz/pkg/query-service/utils/times" "go.signoz.io/signoz/pkg/query-service/utils/timestamp" logsv3 "go.signoz.io/signoz/pkg/query-service/app/logs/v3" "go.signoz.io/signoz/pkg/query-service/formatter" yaml "gopkg.in/yaml.v2" ) type ThresholdRule struct { *BaseRule // Ever since we introduced the new metrics query builder, the version is "v4" // for all the rules // if the version is "v3", then we use the old querier // if the version is "v4", then we use the new querierV2 version string // temporalityMap is a map of metric name to temporality // to avoid fetching temporality for the same metric multiple times // querying the v4 table on low cardinal temporality column // should be fast but we can still avoid the query if we have the data in memory temporalityMap map[string]map[v3.Temporality]bool // querier is used for alerts created before the introduction of new metrics query builder querier interfaces.Querier // querierV2 is used for alerts created after the introduction of new metrics query builder querierV2 interfaces.Querier } func NewThresholdRule( id string, p *PostableRule, featureFlags interfaces.FeatureLookup, reader interfaces.Reader, useLogsNewSchema bool, opts ...RuleOption, ) (*ThresholdRule, error) { zap.L().Info("creating new ThresholdRule", zap.String("id", id), zap.Any("opts", opts)) baseRule, err := NewBaseRule(id, p, reader, opts...) if err != nil { return nil, err } t := ThresholdRule{ BaseRule: baseRule, version: p.Version, temporalityMap: make(map[string]map[v3.Temporality]bool), } querierOption := querier.QuerierOptions{ Reader: reader, Cache: nil, KeyGenerator: queryBuilder.NewKeyGenerator(), FeatureLookup: featureFlags, UseLogsNewSchema: useLogsNewSchema, } querierOptsV2 := querierV2.QuerierOptions{ Reader: reader, Cache: nil, KeyGenerator: queryBuilder.NewKeyGenerator(), FeatureLookup: featureFlags, UseLogsNewSchema: useLogsNewSchema, } t.querier = querier.NewQuerier(querierOption) t.querierV2 = querierV2.NewQuerier(querierOptsV2) t.reader = reader return &t, nil } func (r *ThresholdRule) Type() RuleType { return RuleTypeThreshold } // populateTemporality same as addTemporality but for v4 and better func (r *ThresholdRule) populateTemporality(ctx context.Context, qp *v3.QueryRangeParamsV3) error { missingTemporality := make([]string, 0) metricNameToTemporality := make(map[string]map[v3.Temporality]bool) if qp.CompositeQuery != nil && len(qp.CompositeQuery.BuilderQueries) > 0 { for _, query := range qp.CompositeQuery.BuilderQueries { // if there is no temporality specified in the query but we have it in the map // then use the value from the map if query.Temporality == "" && r.temporalityMap[query.AggregateAttribute.Key] != nil { // We prefer delta if it is available if r.temporalityMap[query.AggregateAttribute.Key][v3.Delta] { query.Temporality = v3.Delta } else if r.temporalityMap[query.AggregateAttribute.Key][v3.Cumulative] { query.Temporality = v3.Cumulative } else { query.Temporality = v3.Unspecified } } // we don't have temporality for this metric if query.DataSource == v3.DataSourceMetrics && query.Temporality == "" { missingTemporality = append(missingTemporality, query.AggregateAttribute.Key) } if _, ok := metricNameToTemporality[query.AggregateAttribute.Key]; !ok { metricNameToTemporality[query.AggregateAttribute.Key] = make(map[v3.Temporality]bool) } } } var nameToTemporality map[string]map[v3.Temporality]bool var err error if len(missingTemporality) > 0 { nameToTemporality, err = r.reader.FetchTemporality(ctx, missingTemporality) if err != nil { return err } } if qp.CompositeQuery != nil && len(qp.CompositeQuery.BuilderQueries) > 0 { for name := range qp.CompositeQuery.BuilderQueries { query := qp.CompositeQuery.BuilderQueries[name] if query.DataSource == v3.DataSourceMetrics && query.Temporality == "" { if nameToTemporality[query.AggregateAttribute.Key][v3.Delta] { query.Temporality = v3.Delta } else if nameToTemporality[query.AggregateAttribute.Key][v3.Cumulative] { query.Temporality = v3.Cumulative } else { query.Temporality = v3.Unspecified } r.temporalityMap[query.AggregateAttribute.Key] = nameToTemporality[query.AggregateAttribute.Key] } } } return nil } func (r *ThresholdRule) prepareQueryRange(ts time.Time) (*v3.QueryRangeParamsV3, error) { zap.L().Info("prepareQueryRange", zap.Int64("ts", ts.UnixMilli()), zap.Int64("evalWindow", r.evalWindow.Milliseconds()), zap.Int64("evalDelay", r.evalDelay.Milliseconds())) start := ts.Add(-time.Duration(r.evalWindow)).UnixMilli() end := ts.UnixMilli() if r.evalDelay > 0 { start = start - int64(r.evalDelay.Milliseconds()) end = end - int64(r.evalDelay.Milliseconds()) } // round to minute otherwise we could potentially miss data start = start - (start % (60 * 1000)) end = end - (end % (60 * 1000)) if r.ruleCondition.QueryType() == v3.QueryTypeClickHouseSQL { params := &v3.QueryRangeParamsV3{ Start: start, End: end, Step: int64(math.Max(float64(common.MinAllowedStepInterval(start, end)), 60)), CompositeQuery: &v3.CompositeQuery{ QueryType: r.ruleCondition.CompositeQuery.QueryType, PanelType: r.ruleCondition.CompositeQuery.PanelType, BuilderQueries: make(map[string]*v3.BuilderQuery), ClickHouseQueries: make(map[string]*v3.ClickHouseQuery), PromQueries: make(map[string]*v3.PromQuery), Unit: r.ruleCondition.CompositeQuery.Unit, }, Variables: make(map[string]interface{}, 0), NoCache: true, } querytemplate.AssignReservedVarsV3(params) for name, chQuery := range r.ruleCondition.CompositeQuery.ClickHouseQueries { if chQuery.Disabled { continue } tmpl := template.New("clickhouse-query") tmpl, err := tmpl.Parse(chQuery.Query) if err != nil { return nil, err } var query bytes.Buffer err = tmpl.Execute(&query, params.Variables) if err != nil { return nil, err } params.CompositeQuery.ClickHouseQueries[name] = &v3.ClickHouseQuery{ Query: query.String(), Disabled: chQuery.Disabled, Legend: chQuery.Legend, } } return params, nil } if r.ruleCondition.CompositeQuery != nil && r.ruleCondition.CompositeQuery.BuilderQueries != nil { for _, q := range r.ruleCondition.CompositeQuery.BuilderQueries { // If the step interval is less than the minimum allowed step interval, set it to the minimum allowed step interval if minStep := common.MinAllowedStepInterval(start, end); q.StepInterval < minStep { q.StepInterval = minStep } } } if r.ruleCondition.CompositeQuery.PanelType != v3.PanelTypeGraph { r.ruleCondition.CompositeQuery.PanelType = v3.PanelTypeGraph } // default mode return &v3.QueryRangeParamsV3{ Start: start, End: end, Step: int64(math.Max(float64(common.MinAllowedStepInterval(start, end)), 60)), CompositeQuery: r.ruleCondition.CompositeQuery, Variables: make(map[string]interface{}, 0), NoCache: true, }, nil } // The following function is used to prepare the where clause for the query // `lbls` contains the key value pairs of the labels from the result of the query // We iterate over the where clause and replace the labels with the actual values // There are two cases: // 1. The label is present in the where clause // 2. The label is not present in the where clause // // Example for case 2: // Latency by serviceName without any filter // In this case, for each service with latency > threshold we send a notification // The expectation will be that clicking on the related traces for service A, will // take us to the traces page with the filter serviceName=A // So for all the missing labels in the where clause, we add them as key = value // // Example for case 1: // Severity text IN (WARN, ERROR) // In this case, the Severity text will appear in the `lbls` if it were part of the group // by clause, in which case we replace it with the actual value for the notification // i.e Severity text = WARN // If the Severity text is not part of the group by clause, then we add it as it is func (r *ThresholdRule) fetchFilters(selectedQuery string, lbls labels.Labels) []v3.FilterItem { var filterItems []v3.FilterItem added := make(map[string]struct{}) if r.ruleCondition.CompositeQuery.QueryType == v3.QueryTypeBuilder && r.ruleCondition.CompositeQuery.BuilderQueries[selectedQuery] != nil && r.ruleCondition.CompositeQuery.BuilderQueries[selectedQuery].Filters != nil { for _, item := range r.ruleCondition.CompositeQuery.BuilderQueries[selectedQuery].Filters.Items { exists := false for _, label := range lbls { if item.Key.Key == label.Name { // if the label is present in the where clause, replace it with key = value filterItems = append(filterItems, v3.FilterItem{ Key: item.Key, Operator: v3.FilterOperatorEqual, Value: label.Value, }) exists = true added[label.Name] = struct{}{} break } } if !exists { // if the label is not present in the where clause, add it as it is filterItems = append(filterItems, item) } } } // add the labels which are not present in the where clause for _, label := range lbls { if _, ok := added[label.Name]; !ok { filterItems = append(filterItems, v3.FilterItem{ Key: v3.AttributeKey{Key: label.Name}, Operator: v3.FilterOperatorEqual, Value: label.Value, }) } } return filterItems } func (r *ThresholdRule) prepareLinksToLogs(ts time.Time, lbls labels.Labels) string { selectedQuery := r.GetSelectedQuery() // TODO(srikanthccv): handle formula queries if selectedQuery < "A" || selectedQuery > "Z" { return "" } q, err := r.prepareQueryRange(ts) if err != nil { return "" } // Logs list view expects time in milliseconds tr := v3.URLShareableTimeRange{ Start: q.Start, End: q.End, PageSize: 100, } options := v3.URLShareableOptions{ MaxLines: 2, Format: "list", SelectColumns: []v3.AttributeKey{}, } period, _ := json.Marshal(tr) urlEncodedTimeRange := url.QueryEscape(string(period)) filterItems := r.fetchFilters(selectedQuery, lbls) urlData := v3.URLShareableCompositeQuery{ QueryType: string(v3.QueryTypeBuilder), Builder: v3.URLShareableBuilderQuery{ QueryData: []v3.BuilderQuery{ { DataSource: v3.DataSourceLogs, QueryName: "A", AggregateOperator: v3.AggregateOperatorNoOp, AggregateAttribute: v3.AttributeKey{}, Filters: &v3.FilterSet{ Items: filterItems, Operator: "AND", }, Expression: "A", Disabled: false, Having: []v3.Having{}, StepInterval: 60, OrderBy: []v3.OrderBy{ { ColumnName: "timestamp", Order: "desc", }, }, }, }, QueryFormulas: make([]string, 0), }, } data, _ := json.Marshal(urlData) compositeQuery := url.QueryEscape(url.QueryEscape(string(data))) optionsData, _ := json.Marshal(options) urlEncodedOptions := url.QueryEscape(string(optionsData)) return fmt.Sprintf("compositeQuery=%s&timeRange=%s&startTime=%d&endTime=%d&options=%s", compositeQuery, urlEncodedTimeRange, tr.Start, tr.End, urlEncodedOptions) } func (r *ThresholdRule) prepareLinksToTraces(ts time.Time, lbls labels.Labels) string { selectedQuery := r.GetSelectedQuery() // TODO(srikanthccv): handle formula queries if selectedQuery < "A" || selectedQuery > "Z" { return "" } q, err := r.prepareQueryRange(ts) if err != nil { return "" } // Traces list view expects time in nanoseconds tr := v3.URLShareableTimeRange{ Start: q.Start * time.Second.Microseconds(), End: q.End * time.Second.Microseconds(), PageSize: 100, } options := v3.URLShareableOptions{ MaxLines: 2, Format: "list", SelectColumns: constants.TracesListViewDefaultSelectedColumns, } period, _ := json.Marshal(tr) urlEncodedTimeRange := url.QueryEscape(string(period)) filterItems := r.fetchFilters(selectedQuery, lbls) urlData := v3.URLShareableCompositeQuery{ QueryType: string(v3.QueryTypeBuilder), Builder: v3.URLShareableBuilderQuery{ QueryData: []v3.BuilderQuery{ { DataSource: v3.DataSourceTraces, QueryName: "A", AggregateOperator: v3.AggregateOperatorNoOp, AggregateAttribute: v3.AttributeKey{}, Filters: &v3.FilterSet{ Items: filterItems, Operator: "AND", }, Expression: "A", Disabled: false, Having: []v3.Having{}, StepInterval: 60, OrderBy: []v3.OrderBy{ { ColumnName: "timestamp", Order: "desc", }, }, }, }, QueryFormulas: make([]string, 0), }, } data, _ := json.Marshal(urlData) compositeQuery := url.QueryEscape(url.QueryEscape(string(data))) optionsData, _ := json.Marshal(options) urlEncodedOptions := url.QueryEscape(string(optionsData)) return fmt.Sprintf("compositeQuery=%s&timeRange=%s&startTime=%d&endTime=%d&options=%s", compositeQuery, urlEncodedTimeRange, tr.Start, tr.End, urlEncodedOptions) } func (r *ThresholdRule) GetSelectedQuery() string { if r.ruleCondition != nil { if r.ruleCondition.SelectedQuery != "" { return r.ruleCondition.SelectedQuery } queryNames := map[string]struct{}{} if r.ruleCondition.CompositeQuery != nil { if r.ruleCondition.QueryType() == v3.QueryTypeBuilder { for name := range r.ruleCondition.CompositeQuery.BuilderQueries { queryNames[name] = struct{}{} } } else if r.ruleCondition.QueryType() == v3.QueryTypeClickHouseSQL { for name := range r.ruleCondition.CompositeQuery.ClickHouseQueries { queryNames[name] = struct{}{} } } } // The following logic exists for backward compatibility // If there is no selected query, then // - check if F1 is present, if yes, return F1 // - else return the query with max ascii value // this logic is not really correct. we should be considering // whether the query is enabled or not. but this is a temporary // fix to support backward compatibility if _, ok := queryNames["F1"]; ok { return "F1" } keys := make([]string, 0, len(queryNames)) for k := range queryNames { keys = append(keys, k) } sort.Strings(keys) return keys[len(keys)-1] } // This should never happen return "" } func (r *ThresholdRule) buildAndRunQuery(ctx context.Context, ts time.Time) (Vector, error) { params, err := r.prepareQueryRange(ts) if err != nil { return nil, err } err = r.populateTemporality(ctx, params) if err != nil { return nil, fmt.Errorf("internal error while setting temporality") } if params.CompositeQuery.QueryType == v3.QueryTypeBuilder { // check if any enrichment is required for logs if yes then enrich them if logsv3.EnrichmentRequired(params) { // Note: Sending empty fields key because enrichment is only needed for json // TODO: Add support for attribute enrichment later logsv3.Enrich(params, map[string]v3.AttributeKey{}) } } var results []*v3.Result var queryErrors map[string]error if r.version == "v4" { results, queryErrors, err = r.querierV2.QueryRange(ctx, params, map[string]v3.AttributeKey{}) } else { results, queryErrors, err = r.querier.QueryRange(ctx, params, map[string]v3.AttributeKey{}) } if err != nil { zap.L().Error("failed to get alert query result", zap.String("rule", r.Name()), zap.Error(err), zap.Any("errors", queryErrors)) return nil, fmt.Errorf("internal error while querying") } if params.CompositeQuery.QueryType == v3.QueryTypeBuilder { results, err = postprocess.PostProcessResult(results, params) if err != nil { zap.L().Error("failed to post process result", zap.String("rule", r.Name()), zap.Error(err)) return nil, fmt.Errorf("internal error while post processing") } } selectedQuery := r.GetSelectedQuery() var queryResult *v3.Result for _, res := range results { if res.QueryName == selectedQuery { queryResult = res break } } if queryResult != nil && len(queryResult.Series) > 0 { r.lastTimestampWithDatapoints = time.Now() } var resultVector Vector // if the data is missing for `For` duration then we should send alert if r.ruleCondition.AlertOnAbsent && r.lastTimestampWithDatapoints.Add(time.Duration(r.Condition().AbsentFor)*time.Minute).Before(time.Now()) { zap.L().Info("no data found for rule condition", zap.String("ruleid", r.ID())) lbls := labels.NewBuilder(labels.Labels{}) if !r.lastTimestampWithDatapoints.IsZero() { lbls.Set("lastSeen", r.lastTimestampWithDatapoints.Format(constants.AlertTimeFormat)) } resultVector = append(resultVector, Sample{ Metric: lbls.Labels(), IsMissing: true, }) return resultVector, nil } for _, series := range queryResult.Series { smpl, shouldAlert := r.shouldAlert(*series) if shouldAlert { resultVector = append(resultVector, smpl) } } return resultVector, nil } func normalizeLabelName(name string) string { // See https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels // Regular expression to match non-alphanumeric characters except underscores reg := regexp.MustCompile(`[^a-zA-Z0-9_]`) // Replace all non-alphanumeric characters except underscores with underscores normalized := reg.ReplaceAllString(name, "_") // If the first character is not a letter or an underscore, prepend an underscore if len(normalized) > 0 && !unicode.IsLetter(rune(normalized[0])) && normalized[0] != '_' { normalized = "_" + normalized } return normalized } func (r *ThresholdRule) Eval(ctx context.Context, ts time.Time) (interface{}, error) { prevState := r.State() valueFormatter := formatter.FromUnit(r.Unit()) res, err := r.buildAndRunQuery(ctx, ts) if err != nil { return nil, err } r.mtx.Lock() defer r.mtx.Unlock() resultFPs := map[uint64]struct{}{} var alerts = make(map[uint64]*Alert, len(res)) for _, smpl := range res { l := make(map[string]string, len(smpl.Metric)) for _, lbl := range smpl.Metric { l[lbl.Name] = lbl.Value } value := valueFormatter.Format(smpl.V, r.Unit()) threshold := valueFormatter.Format(r.targetVal(), r.Unit()) zap.L().Debug("Alert template data for rule", zap.String("name", r.Name()), zap.String("formatter", valueFormatter.Name()), zap.String("value", value), zap.String("threshold", threshold)) tmplData := AlertTemplateData(l, value, threshold) // Inject some convenience variables that are easier to remember for users // who are not used to Go's templating system. defs := "{{$labels := .Labels}}{{$value := .Value}}{{$threshold := .Threshold}}" // utility function to apply go template on labels and annotations expand := func(text string) string { tmpl := NewTemplateExpander( ctx, defs+text, "__alert_"+r.Name(), tmplData, times.Time(timestamp.FromTime(ts)), nil, ) result, err := tmpl.Expand() if err != nil { result = fmt.Sprintf("", err) zap.L().Error("Expanding alert template failed", zap.Error(err), zap.Any("data", tmplData)) } return result } lb := labels.NewBuilder(smpl.Metric).Del(labels.MetricNameLabel).Del(labels.TemporalityLabel) resultLabels := labels.NewBuilder(smpl.MetricOrig).Del(labels.MetricNameLabel).Del(labels.TemporalityLabel).Labels() for name, value := range r.labels.Map() { lb.Set(name, expand(value)) } lb.Set(labels.AlertNameLabel, r.Name()) lb.Set(labels.AlertRuleIdLabel, r.ID()) lb.Set(labels.RuleSourceLabel, r.GeneratorURL()) annotations := make(labels.Labels, 0, len(r.annotations.Map())) for name, value := range r.annotations.Map() { annotations = append(annotations, labels.Label{Name: normalizeLabelName(name), Value: expand(value)}) } if smpl.IsMissing { lb.Set(labels.AlertNameLabel, "[No data] "+r.Name()) } // Links with timestamps should go in annotations since labels // is used alert grouping, and we want to group alerts with the same // label set, but different timestamps, together. if r.typ == AlertTypeTraces { link := r.prepareLinksToTraces(ts, smpl.MetricOrig) if link != "" && r.hostFromSource() != "" { annotations = append(annotations, labels.Label{Name: "related_traces", Value: fmt.Sprintf("%s/traces-explorer?%s", r.hostFromSource(), link)}) } } else if r.typ == AlertTypeLogs { link := r.prepareLinksToLogs(ts, smpl.MetricOrig) if link != "" && r.hostFromSource() != "" { annotations = append(annotations, labels.Label{Name: "related_logs", Value: fmt.Sprintf("%s/logs/logs-explorer?%s", r.hostFromSource(), link)}) } } lbs := lb.Labels() h := lbs.Hash() resultFPs[h] = struct{}{} if _, ok := alerts[h]; ok { zap.L().Error("the alert query returns duplicate records", zap.String("ruleid", r.ID()), zap.Any("alert", alerts[h])) err = fmt.Errorf("duplicate alert found, vector contains metrics with the same labelset after applying alert labels") return nil, err } alerts[h] = &Alert{ Labels: lbs, QueryResultLables: resultLabels, Annotations: annotations, ActiveAt: ts, State: model.StatePending, Value: smpl.V, GeneratorURL: r.GeneratorURL(), Receivers: r.preferredChannels, Missing: smpl.IsMissing, } } zap.L().Info("number of alerts found", zap.String("name", r.Name()), zap.Int("count", len(alerts))) // alerts[h] is ready, add or update active list now for h, a := range alerts { // Check whether we already have alerting state for the identifying label set. // Update the last value and annotations if so, create a new alert entry otherwise. if alert, ok := r.active[h]; ok && alert.State != model.StateInactive { alert.Value = a.Value alert.Annotations = a.Annotations alert.Receivers = r.preferredChannels continue } r.active[h] = a } itemsToAdd := []v3.RuleStateHistory{} // Check if any pending alerts should be removed or fire now. Write out alert timeseries. for fp, a := range r.active { labelsJSON, err := json.Marshal(a.QueryResultLables) if err != nil { zap.L().Error("error marshaling labels", zap.Error(err), zap.Any("labels", a.Labels)) } if _, ok := resultFPs[fp]; !ok { // If the alert was previously firing, keep it around for a given // retention time so it is reported as resolved to the AlertManager. if a.State == model.StatePending || (!a.ResolvedAt.IsZero() && ts.Sub(a.ResolvedAt) > resolvedRetention) { delete(r.active, fp) } if a.State != model.StateInactive { a.State = model.StateInactive a.ResolvedAt = ts itemsToAdd = append(itemsToAdd, v3.RuleStateHistory{ RuleID: r.ID(), RuleName: r.Name(), State: model.StateInactive, StateChanged: true, UnixMilli: ts.UnixMilli(), Labels: v3.LabelsString(labelsJSON), Fingerprint: a.QueryResultLables.Hash(), Value: a.Value, }) } continue } if a.State == model.StatePending && ts.Sub(a.ActiveAt) >= r.holdDuration { a.State = model.StateFiring a.FiredAt = ts state := model.StateFiring if a.Missing { state = model.StateNoData } itemsToAdd = append(itemsToAdd, v3.RuleStateHistory{ RuleID: r.ID(), RuleName: r.Name(), State: state, StateChanged: true, UnixMilli: ts.UnixMilli(), Labels: v3.LabelsString(labelsJSON), Fingerprint: a.QueryResultLables.Hash(), Value: a.Value, }) } } currentState := r.State() overallStateChanged := currentState != prevState for idx, item := range itemsToAdd { item.OverallStateChanged = overallStateChanged item.OverallState = currentState itemsToAdd[idx] = item } r.RecordRuleStateHistory(ctx, prevState, currentState, itemsToAdd) r.health = HealthGood r.lastError = err return len(r.active), nil } func (r *ThresholdRule) String() string { ar := PostableRule{ AlertName: r.name, RuleCondition: r.ruleCondition, EvalWindow: Duration(r.evalWindow), Labels: r.labels.Map(), Annotations: r.annotations.Map(), PreferredChannels: r.preferredChannels, } byt, err := yaml.Marshal(ar) if err != nil { return fmt.Sprintf("error marshaling alerting rule: %s", err.Error()) } return string(byt) } func removeGroupinSetPoints(series v3.Series) []v3.Point { var result []v3.Point for _, s := range series.Points { if s.Timestamp >= 0 && !math.IsNaN(s.Value) && !math.IsInf(s.Value, 0) { result = append(result, s) } } return result }