mirror of
https://git.mirrors.martin98.com/https://github.com/SigNoz/signoz
synced 2025-06-04 11:25:52 +08:00
48936bed9b
* chore: multitenancy in integrations * chore: multitenancy in cloud integration accounts * chore: changes to cloudintegrationservice * chore: rename migration * chore: update scan function * chore: update scan function * chore: fix migration * chore: fix struct * chore: remove unwanted code * chore: update scan function * chore: migrate user and pat for integrations * fix: changes to the user for integrations * fix: address comments * fix: copy created_at * fix: update non revoked token * chore: don't allow deleting pat and user for integrations * fix: address comments * chore: address comments * chore: add checks for fk in dialect * fix: service migration * fix: don't update user if user is already migrated * fix: update correct service config * fix: remove unwanted code * fix: remove migration for multiple same services which is not required * fix: fix migration and disable disaboard if metrics disabled * fix: don't use ee types --------- Co-authored-by: Vikrant Gupta <vikrant@signoz.io>
320 lines
9.6 KiB
Go
320 lines
9.6 KiB
Go
package cloudintegrations
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/SigNoz/signoz/pkg/query-service/auth"
|
|
"github.com/SigNoz/signoz/pkg/query-service/constants"
|
|
"github.com/SigNoz/signoz/pkg/query-service/dao"
|
|
"github.com/SigNoz/signoz/pkg/query-service/model"
|
|
"github.com/SigNoz/signoz/pkg/query-service/utils"
|
|
"github.com/SigNoz/signoz/pkg/types"
|
|
"github.com/google/uuid"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestRegenerateConnectionUrlWithUpdatedConfig(t *testing.T) {
|
|
require := require.New(t)
|
|
sqlStore := utils.NewQueryServiceDBForTests(t)
|
|
controller, err := NewController(sqlStore)
|
|
require.NoError(err)
|
|
|
|
user, apiErr := createTestUser()
|
|
require.Nil(apiErr)
|
|
|
|
// should be able to generate connection url for
|
|
// same account id again with updated config
|
|
testAccountConfig1 := types.AccountConfig{EnabledRegions: []string{"us-east-1", "us-west-1"}}
|
|
resp1, apiErr := controller.GenerateConnectionUrl(
|
|
context.TODO(), user.OrgID, "aws", GenerateConnectionUrlRequest{
|
|
AccountConfig: testAccountConfig1,
|
|
AgentConfig: SigNozAgentConfig{Region: "us-east-2"},
|
|
},
|
|
)
|
|
require.Nil(apiErr)
|
|
require.NotEmpty(resp1.ConnectionUrl)
|
|
require.NotEmpty(resp1.AccountId)
|
|
|
|
testAccountId := resp1.AccountId
|
|
account, apiErr := controller.accountsRepo.get(
|
|
context.TODO(), user.OrgID, "aws", testAccountId,
|
|
)
|
|
require.Nil(apiErr)
|
|
require.Equal(testAccountConfig1, *account.Config)
|
|
|
|
testAccountConfig2 := types.AccountConfig{EnabledRegions: []string{"us-east-2", "us-west-2"}}
|
|
resp2, apiErr := controller.GenerateConnectionUrl(
|
|
context.TODO(), user.OrgID, "aws", GenerateConnectionUrlRequest{
|
|
AccountId: &testAccountId,
|
|
AccountConfig: testAccountConfig2,
|
|
AgentConfig: SigNozAgentConfig{Region: "us-east-2"},
|
|
},
|
|
)
|
|
require.Nil(apiErr)
|
|
require.Equal(testAccountId, resp2.AccountId)
|
|
|
|
account, apiErr = controller.accountsRepo.get(
|
|
context.TODO(), user.OrgID, "aws", testAccountId,
|
|
)
|
|
require.Nil(apiErr)
|
|
require.Equal(testAccountConfig2, *account.Config)
|
|
}
|
|
|
|
func TestAgentCheckIns(t *testing.T) {
|
|
require := require.New(t)
|
|
sqlStore := utils.NewQueryServiceDBForTests(t)
|
|
controller, err := NewController(sqlStore)
|
|
require.NoError(err)
|
|
|
|
user, apiErr := createTestUser()
|
|
require.Nil(apiErr)
|
|
|
|
// An agent should be able to check in from a cloud account even
|
|
// if no connection url was requested (no account with agent's account id exists)
|
|
testAccountId1 := uuid.NewString()
|
|
testCloudAccountId1 := "546311234"
|
|
resp1, apiErr := controller.CheckInAsAgent(
|
|
context.TODO(), user.OrgID, "aws", AgentCheckInRequest{
|
|
ID: testAccountId1,
|
|
AccountID: testCloudAccountId1,
|
|
},
|
|
)
|
|
require.Nil(apiErr)
|
|
require.Equal(testAccountId1, resp1.AccountId)
|
|
require.Equal(testCloudAccountId1, resp1.CloudAccountId)
|
|
|
|
// The agent should not be able to check in with a different
|
|
// cloud account id for the same account.
|
|
testCloudAccountId2 := "99999999"
|
|
_, apiErr = controller.CheckInAsAgent(
|
|
context.TODO(), user.OrgID, "aws", AgentCheckInRequest{
|
|
ID: testAccountId1,
|
|
AccountID: testCloudAccountId2,
|
|
},
|
|
)
|
|
require.NotNil(apiErr)
|
|
|
|
// The agent should not be able to check-in with a particular cloud account id
|
|
// if another connected AccountRecord exists for same cloud account
|
|
// i.e. there can't be 2 connected account records for the same cloud account id
|
|
// at any point in time.
|
|
existingConnected, apiErr := controller.accountsRepo.getConnectedCloudAccount(
|
|
context.TODO(), user.OrgID, "aws", testCloudAccountId1,
|
|
)
|
|
require.Nil(apiErr)
|
|
require.NotNil(existingConnected)
|
|
require.Equal(testCloudAccountId1, *existingConnected.AccountID)
|
|
require.Nil(existingConnected.RemovedAt)
|
|
|
|
testAccountId2 := uuid.NewString()
|
|
_, apiErr = controller.CheckInAsAgent(
|
|
context.TODO(), user.OrgID, "aws", AgentCheckInRequest{
|
|
ID: testAccountId2,
|
|
AccountID: testCloudAccountId1,
|
|
},
|
|
)
|
|
require.NotNil(apiErr)
|
|
|
|
// After disconnecting existing account record, the agent should be able to
|
|
// connected for a particular cloud account id
|
|
_, apiErr = controller.DisconnectAccount(
|
|
context.TODO(), user.OrgID, "aws", testAccountId1,
|
|
)
|
|
|
|
existingConnected, apiErr = controller.accountsRepo.getConnectedCloudAccount(
|
|
context.TODO(), user.OrgID, "aws", testCloudAccountId1,
|
|
)
|
|
require.Nil(existingConnected)
|
|
require.NotNil(apiErr)
|
|
require.Equal(model.ErrorNotFound, apiErr.Type())
|
|
|
|
_, apiErr = controller.CheckInAsAgent(
|
|
context.TODO(), user.OrgID, "aws", AgentCheckInRequest{
|
|
ID: testAccountId2,
|
|
AccountID: testCloudAccountId1,
|
|
},
|
|
)
|
|
require.Nil(apiErr)
|
|
|
|
// should be able to keep checking in
|
|
_, apiErr = controller.CheckInAsAgent(
|
|
context.TODO(), user.OrgID, "aws", AgentCheckInRequest{
|
|
ID: testAccountId2,
|
|
AccountID: testCloudAccountId1,
|
|
},
|
|
)
|
|
require.Nil(apiErr)
|
|
}
|
|
|
|
func TestCantDisconnectNonExistentAccount(t *testing.T) {
|
|
require := require.New(t)
|
|
sqlStore := utils.NewQueryServiceDBForTests(t)
|
|
controller, err := NewController(sqlStore)
|
|
require.NoError(err)
|
|
|
|
user, apiErr := createTestUser()
|
|
require.Nil(apiErr)
|
|
|
|
// Attempting to disconnect a non-existent account should return error
|
|
account, apiErr := controller.DisconnectAccount(
|
|
context.TODO(), user.OrgID, "aws", uuid.NewString(),
|
|
)
|
|
require.NotNil(apiErr)
|
|
require.Equal(model.ErrorNotFound, apiErr.Type())
|
|
require.Nil(account)
|
|
}
|
|
|
|
func TestConfigureService(t *testing.T) {
|
|
require := require.New(t)
|
|
sqlStore := utils.NewQueryServiceDBForTests(t)
|
|
controller, err := NewController(sqlStore)
|
|
require.NoError(err)
|
|
|
|
user, apiErr := createTestUser()
|
|
require.Nil(apiErr)
|
|
|
|
// create a connected account
|
|
testCloudAccountId := "546311234"
|
|
testConnectedAccount := makeTestConnectedAccount(t, user.OrgID, controller, testCloudAccountId)
|
|
require.Nil(testConnectedAccount.RemovedAt)
|
|
require.NotEmpty(testConnectedAccount.AccountID)
|
|
require.Equal(testCloudAccountId, *testConnectedAccount.AccountID)
|
|
|
|
// should start out without any service config
|
|
svcListResp, apiErr := controller.ListServices(
|
|
context.TODO(), user.OrgID, "aws", &testCloudAccountId,
|
|
)
|
|
require.Nil(apiErr)
|
|
|
|
testSvcId := svcListResp.Services[0].Id
|
|
require.Nil(svcListResp.Services[0].Config)
|
|
|
|
svcDetails, apiErr := controller.GetServiceDetails(
|
|
context.TODO(), user.OrgID, "aws", testSvcId, &testCloudAccountId,
|
|
)
|
|
require.Nil(apiErr)
|
|
require.Equal(testSvcId, svcDetails.Id)
|
|
require.Nil(svcDetails.Config)
|
|
|
|
// should be able to configure a service for a connected account
|
|
testSvcConfig := types.CloudServiceConfig{
|
|
Metrics: &types.CloudServiceMetricsConfig{
|
|
Enabled: true,
|
|
},
|
|
}
|
|
updateSvcConfigResp, apiErr := controller.UpdateServiceConfig(
|
|
context.TODO(), user.OrgID, "aws", testSvcId, UpdateServiceConfigRequest{
|
|
CloudAccountId: testCloudAccountId,
|
|
Config: testSvcConfig,
|
|
},
|
|
)
|
|
require.Nil(apiErr)
|
|
require.Equal(testSvcId, updateSvcConfigResp.Id)
|
|
require.Equal(testSvcConfig, updateSvcConfigResp.Config)
|
|
|
|
svcDetails, apiErr = controller.GetServiceDetails(
|
|
context.TODO(), user.OrgID, "aws", testSvcId, &testCloudAccountId,
|
|
)
|
|
require.Nil(apiErr)
|
|
require.Equal(testSvcId, svcDetails.Id)
|
|
require.Equal(testSvcConfig, *svcDetails.Config)
|
|
|
|
svcListResp, apiErr = controller.ListServices(
|
|
context.TODO(), user.OrgID, "aws", &testCloudAccountId,
|
|
)
|
|
require.Nil(apiErr)
|
|
for _, svc := range svcListResp.Services {
|
|
if svc.Id == testSvcId {
|
|
require.Equal(testSvcConfig, *svc.Config)
|
|
}
|
|
}
|
|
|
|
// should not be able to configure service after cloud account has been disconnected
|
|
_, apiErr = controller.DisconnectAccount(
|
|
context.TODO(), user.OrgID, "aws", testConnectedAccount.ID.StringValue(),
|
|
)
|
|
require.Nil(apiErr)
|
|
|
|
_, apiErr = controller.UpdateServiceConfig(
|
|
context.TODO(), user.OrgID, "aws", testSvcId,
|
|
UpdateServiceConfigRequest{
|
|
CloudAccountId: testCloudAccountId,
|
|
Config: testSvcConfig,
|
|
},
|
|
)
|
|
require.NotNil(apiErr)
|
|
|
|
// should not be able to configure a service for a cloud account id that is not connected yet
|
|
_, apiErr = controller.UpdateServiceConfig(
|
|
context.TODO(), user.OrgID, "aws", testSvcId,
|
|
UpdateServiceConfigRequest{
|
|
CloudAccountId: "9999999999",
|
|
Config: testSvcConfig,
|
|
},
|
|
)
|
|
require.NotNil(apiErr)
|
|
|
|
// should not be able to set config for an unsupported service
|
|
_, apiErr = controller.UpdateServiceConfig(
|
|
context.TODO(), user.OrgID, "aws", "bad-service", UpdateServiceConfigRequest{
|
|
CloudAccountId: testCloudAccountId,
|
|
Config: testSvcConfig,
|
|
},
|
|
)
|
|
require.NotNil(apiErr)
|
|
|
|
}
|
|
|
|
func makeTestConnectedAccount(t *testing.T, orgId string, controller *Controller, cloudAccountId string) *types.CloudIntegration {
|
|
require := require.New(t)
|
|
|
|
// a check in from SigNoz agent creates or updates a connected account.
|
|
testAccountId := uuid.NewString()
|
|
resp, apiErr := controller.CheckInAsAgent(
|
|
context.TODO(), orgId, "aws", AgentCheckInRequest{
|
|
ID: testAccountId,
|
|
AccountID: cloudAccountId,
|
|
},
|
|
)
|
|
require.Nil(apiErr)
|
|
require.Equal(testAccountId, resp.AccountId)
|
|
require.Equal(cloudAccountId, resp.CloudAccountId)
|
|
|
|
acc, err := controller.accountsRepo.get(context.TODO(), orgId, "aws", resp.AccountId)
|
|
require.Nil(err)
|
|
return acc
|
|
}
|
|
|
|
func createTestUser() (*types.User, *model.ApiError) {
|
|
// Create a test user for auth
|
|
ctx := context.Background()
|
|
org, apiErr := dao.DB().CreateOrg(ctx, &types.Organization{
|
|
Name: "test",
|
|
})
|
|
if apiErr != nil {
|
|
return nil, apiErr
|
|
}
|
|
|
|
group, apiErr := dao.DB().GetGroupByName(ctx, constants.AdminGroup)
|
|
if apiErr != nil {
|
|
return nil, apiErr
|
|
}
|
|
|
|
auth.InitAuthCache(ctx)
|
|
|
|
userId := uuid.NewString()
|
|
return dao.DB().CreateUser(
|
|
ctx,
|
|
&types.User{
|
|
ID: userId,
|
|
Name: "test",
|
|
Email: userId[:8] + "test@test.com",
|
|
Password: "test",
|
|
OrgID: org.ID,
|
|
GroupID: group.ID,
|
|
},
|
|
true,
|
|
)
|
|
}
|