GitHub-Proxy/sqlmodel-fix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🐛 Fix Select and SelectOfScalar to inherit cache to avoid warning: SAWarning: Class SelectOfScalar will not make use of SQL compilation caching (#234)

Browse Source 
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
This commit is contained in:
Rabin Adhikari 2022-08-28 05:02:37 +05:45 committed by GitHub
parent 5e0ac5b56c
commit 475578757f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sqlmodel/sql/expression.py.jinja2
View File

@ -27,14 +27,14 @@ _TSelect = TypeVar("_TSelect")
if sys.version_info.minor >= 7: if sys.version_info.minor >= 7:
class Select(_Select, Generic[_TSelect]): class Select(_Select, Generic[_TSelect]):
pass inherit_cache = True
# This is not comparable to sqlalchemy.sql.selectable.ScalarSelect, that has a different # This is not comparable to sqlalchemy.sql.selectable.ScalarSelect, that has a different
# purpose. This is the same as a normal SQLAlchemy Select class where there's only one # purpose. This is the same as a normal SQLAlchemy Select class where there's only one
# entity, so the result will be converted to a scalar by default. This way writing # entity, so the result will be converted to a scalar by default. This way writing
# for loops on the results will feel natural. # for loops on the results will feel natural.
class SelectOfScalar(_Select, Generic[_TSelect]): class SelectOfScalar(_Select, Generic[_TSelect]):
pass inherit_cache = True
else: else:
from typing import GenericMeta # type: ignore from typing import GenericMeta # type: ignore
@ -43,10 +43,10 @@ else:
pass pass
class _Py36Select(_Select, Generic[_TSelect], metaclass=GenericSelectMeta): class _Py36Select(_Select, Generic[_TSelect], metaclass=GenericSelectMeta):
pass inherit_cache = True
class _Py36SelectOfScalar(_Select, Generic[_TSelect], metaclass=GenericSelectMeta): class _Py36SelectOfScalar(_Select, Generic[_TSelect], metaclass=GenericSelectMeta):
pass inherit_cache = True
# Cast them for editors to work correctly, from several tricks tried, this works # Cast them for editors to work correctly, from several tricks tried, this works
# for both VS Code and PyCharm # for both VS Code and PyCharm