- always check Parameter::number_value to catch user errors, e.g. setting number_value without setting has_number_value, which will cause it to serialize as a bool but read back in as a float anyway

This commit is contained in:
Selmar Kok 2018-10-05 14:36:05 +02:00
parent 13b6402388
commit 2bda71c8fb

View File

@ -1245,9 +1245,8 @@ bool Parameter::operator==(const Parameter &other) const {
this->has_number_value != other.has_number_value) this->has_number_value != other.has_number_value)
return false; return false;
if (this->has_number_value) if (!TINYGLTF_DOUBLE_EQUAL(this->number_value, other.number_value))
if (!TINYGLTF_DOUBLE_EQUAL(this->number_value, other.number_value)) return false;
return false;
if (this->json_double_value.size() != other.json_double_value.size()) if (this->json_double_value.size() != other.json_double_value.size())
return false; return false;