GitHub-Proxy/tinygltf
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/syoyo/tinygltf.git synced 2025-07-05 03:45:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not serialize pbrMetallicRoughness when they have all default values. Fixes #204

Browse Source
This commit is contained in:
Syoyo Fujita 2019-09-13 15:32:22 +09:00
parent 14977937c2
commit 7e009041e3
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tiny_gltf.h
View File

@ -6314,8 +6314,16 @@ static void SerializeGltfMaterial(Material &material, json &o) {
json pbrMetallicRoughness; json pbrMetallicRoughness;
SerializeGltfPbrMetallicRoughness(material.pbrMetallicRoughness, SerializeGltfPbrMetallicRoughness(material.pbrMetallicRoughness,
pbrMetallicRoughness); pbrMetallicRoughness);
// Issue 204
// Do not serialize `pbrMetallicRoughness` if pbrMetallicRoughness has all
// default values(json is null). Otherwise it will serialize to
// `pbrMetallicRoughness : null`, which cannot be read by other glTF
// importers(and validators).
//
if (!JsonIsNull(pbrMetallicRoughness)) {
JsonAddMember(o, "pbrMetallicRoughness", std::move(pbrMetallicRoughness)); JsonAddMember(o, "pbrMetallicRoughness", std::move(pbrMetallicRoughness));
} }
}
#if 0 // legacy way. just for the record. #if 0 // legacy way. just for the record.
if (material.values.size()) { if (material.values.size()) {