diff --git a/tiny_gltf.h b/tiny_gltf.h index 01a5278..f80ee84 100644 --- a/tiny_gltf.h +++ b/tiny_gltf.h @@ -739,7 +739,7 @@ struct PbrMetallicRoughness { Value extras; ExtensionMap extensions; - PbrMetallicRoughness() : metallicFactor(1.0), roughnessFactor(1.0) {} + PbrMetallicRoughness() : baseColorFactor(std::vector{ 1.0,1.0,1.0,1.0 }), metallicFactor(1.0), roughnessFactor(1.0) {} PbrMetallicRoughness(const PbrMetallicRoughness &) = default; PbrMetallicRoughness &operator=(const PbrMetallicRoughness &) = default; PbrMetallicRoughness(PbrMetallicRoughness &&rhs) noexcept @@ -4412,11 +4412,8 @@ static bool ParsePbrMetallicRoughness(PbrMetallicRoughness *pbr, } return false; } - } else { - // fill with default values - baseColorFactor = {1.0, 1.0, 1.0, 1.0}; + pbr->baseColorFactor = baseColorFactor; } - pbr->baseColorFactor = baseColorFactor; { json_const_iterator it;