actions/toolkit
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/actions/toolkit synced 2026-04-01 07:13:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

update test case and handling

Browse Source
This commit is contained in:
bethanyj28
2024-02-23 13:41:40 -05:00
parent 76489f433b
commit 4256ea99c5
3 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
packages/artifact/src/internal/download/download-artifact.ts
View File

@@ -46,6 +46,9 @@ async function streamExtract(url: string, directory: string): Promise<void> {
await streamExtractExternal(url, directory)
return
} catch (error) {
if (error.message.includes('Malformed extraction path')) {
throw new Error(`Artifact download failed with unretryable error: ${error.message}`)
}
retryCount++
core.debug(
`Failed to download artifact after ${retryCount} retries due to ${error.message}. Retrying in 5 seconds...`
@@ -81,6 +84,7 @@ export async function streamExtractExternal(
const timer = setTimeout(timerFn, timeout)
const promises: Promise<void>[] = []
const createdDirectories = new Set<string>()
response.message
.on('data', () => {
timer.refresh()
@@ -94,20 +98,25 @@ export async function streamExtractExternal(
})
.pipe(unzip.Parse())
.on('entry', (entry: unzip.Entry) => {
console.log(`entryPath: ${entry.path}`)
const fullPath = path.normalize(path.join(directory, entry.path))
console.log(`fullPath: ${fullPath}`)
if (fullPath.indexOf(directory) != 0) {
reject(new Error(`Invalid file path: ${fullPath}`))
if (fullPath.indexOf(directory) !== 0) {
reject(new Error(`Malformed extraction path: ${fullPath}`))
}
core.debug(`Extracting artifact entry: ${fullPath}`)
if (entry.type === 'Directory') {
promises.push(resolveOrCreateDirectory(fullPath).then(() => {}))
if (!createdDirectories.has(fullPath)) {
promises.push(resolveOrCreateDirectory(fullPath).then(() => {}))
createdDirectories.add(fullPath)
}
entry.autodrain()
} else {
promises.push(
resolveOrCreateDirectory(path.dirname(fullPath)).then(() => {})
)
if (!createdDirectories.has(path.dirname(fullPath))) {
promises.push(
resolveOrCreateDirectory(path.dirname(fullPath)).then(() => {})
)
createdDirectories.add(path.dirname(fullPath))
}
const writeStream = createWriteStream(fullPath)
promises.push(
new Promise((resolve, reject) => {