actions/toolkit
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/actions/toolkit synced 2026-04-01 18:23:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Correctly reset chunk during artifact upload on retry (#458)

Browse Source 
* Correctly reset chunk during artifact upload on retry

* Update workflow

* Implementation details around the passthrough stream
This commit is contained in:
Konrad Pabjan
2020-05-14 22:18:21 +02:00
committed by GitHub
parent 6d83c79964
commit 628f82f221
3 changed files with 34 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/artifact/docs/implementation-details.md
View File

@@ -6,6 +6,10 @@ Warning: Implementation details may change at any time without notice. This is m
![image](https://user-images.githubusercontent.com/16109154/79765587-19522b00-8327-11ea-9679-410bb10e1b13.png)
During artifact upload, gzip is used to compress individual files that then get uploaded. This is used to minimize the amount of data that gets uploaded which reduces the total amount of HTTP calls (upload happens in 4MB chunks). This results in considerably faster uploads with huge performance implications especially on self-hosted runners.
If a file is less than 64KB in size, a passthrough stream (readable and writable) is used to convert an in-memory buffer into a readable stream without any extra streams or pipping.
## Retry Logic when downloading an individual file
![image](https://user-images.githubusercontent.com/16109154/78555461-5be71400-780d-11ea-9abd-b05b77a95a3f.png)