add md5 and use b64 for digest encodings

packages/artifact/src/internal/crc64.ts

@@ -269,6 +269,8 @@ const PREGEN_POLY_TABLE = [
   BigInt('0x2ADA5047EFEC8728')
 ]
 
+export type CRC64DigestEncoding = 'hex' | 'base64' | 'buffer'
+
 class CRC64 {
   private _crc: bigint
 
@@ -288,8 +290,23 @@ class CRC64 {
     this._crc = CRC64.flip64Bits(crc)
   }
 
-  digest(): string {
-    return this._crc.toString(16).toUpperCase()
+  digest(encoding?: CRC64DigestEncoding): string | Buffer {
+    switch (encoding) {
+      case 'hex':
+        return this._crc.toString(16).toUpperCase()
+      case 'base64':
+        return this.toBuffer().toString('base64')
+      default:
+        return this.toBuffer()
+    }
+  }
+
+  private toBuffer(): Buffer {
+    return Buffer.from(
+      [0, 8, 16, 24, 32, 40, 48, 56].map(s =>
+        Number((this._crc >> BigInt(s)) & BigInt(0xff))
+      )
+    )
   }
 
   static flip64Bits(n: bigint): bigint {

packages/artifact/src/internal/utils.ts

@@ -1,3 +1,4 @@
+import crypto from 'crypto'
 import {promises as fs} from 'fs'
 import {IncomingHttpHeaders} from 'http'
 import {debug, info, warning} from '@actions/core'
@@ -182,7 +183,7 @@ export function getUploadHeaders(
   uncompressedLength?: number,
   contentLength?: number,
   contentRange?: string,
-  digest?: string
+  digest?: StreamDigest
 ): IHeaders {
   const requestOptions: IHeaders = {}
   requestOptions['Accept'] = `application/json;api-version=${getApiVersion()}`
@@ -205,7 +206,8 @@ export function getUploadHeaders(
     requestOptions['Content-Range'] = contentRange
   }
   if (digest) {
-    requestOptions['x-actions-result-crc64'] = digest
+    requestOptions['x-actions-results-crc64'] = digest.crc64
+    requestOptions['x-actions-results-md5'] = digest.md5
   }
 
   return requestOptions
@@ -297,13 +299,28 @@ export async function sleep(milliseconds: number): Promise<void> {
   return new Promise(resolve => setTimeout(resolve, milliseconds))
 }
 
+export interface StreamDigest {
+  crc64: string
+  md5: string
+}
+
 export async function digestForStream(
   stream: NodeJS.ReadableStream
-): Promise<string> {
+): Promise<StreamDigest> {
   return new Promise((resolve, reject) => {
-    const hasher = new CRC64()
-    stream.on('data', data => hasher.update(data))
-    stream.on('end', () => resolve(hasher.digest()))
-    stream.on('error', reject)
+    const crc64 = new CRC64()
+    const md5 = crypto.createHash('sha256')
+    stream
+      .on('data', data => {
+        crc64.update(data)
+        md5.update(data)
+      })
+      .on('end', () =>
+        resolve({
+          crc64: crc64.digest('base64') as string,
+          md5: md5.digest('base64')
+        })
+      )
+      .on('error', reject)
   })
 }