From e6fb8f1c5dd2ecf0a8b92dcc3a3607efcddb56c1 Mon Sep 17 00:00:00 2001 From: Rob Herley Date: Fri, 14 Feb 2025 09:28:01 -0500 Subject: [PATCH 1/2] cache miss as debug, not warning annotation --- packages/cache/src/cache.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cache/src/cache.ts b/packages/cache/src/cache.ts index 9b02489f..5f2102cb 100644 --- a/packages/cache/src/cache.ts +++ b/packages/cache/src/cache.ts @@ -256,7 +256,7 @@ async function restoreCacheV2( const response = await twirpClient.GetCacheEntryDownloadURL(request) if (!response.ok) { - core.warning(`Cache not found for keys: ${keys.join(', ')}`) + core.debug(`Cache not found for keys: ${keys.join(', ')}`) return undefined } From 7fe619c58c7277e3aba885ab038a7b7c57705b29 Mon Sep 17 00:00:00 2001 From: Rob Herley Date: Fri, 14 Feb 2025 09:42:41 -0500 Subject: [PATCH 2/2] update mocks --- packages/cache/__tests__/restoreCacheV2.test.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/cache/__tests__/restoreCacheV2.test.ts b/packages/cache/__tests__/restoreCacheV2.test.ts index d4edc2a4..64e9df15 100644 --- a/packages/cache/__tests__/restoreCacheV2.test.ts +++ b/packages/cache/__tests__/restoreCacheV2.test.ts @@ -115,7 +115,6 @@ test('restore with restore keys and no cache found', async () => { const paths = ['node_modules'] const key = 'node-test' const restoreKeys = ['node-'] - const logWarningMock = jest.spyOn(core, 'warning') jest .spyOn(CacheServiceClientJSON.prototype, 'GetCacheEntryDownloadURL') @@ -130,7 +129,7 @@ test('restore with restore keys and no cache found', async () => { const cacheKey = await restoreCache(paths, key, restoreKeys) expect(cacheKey).toBe(undefined) - expect(logWarningMock).toHaveBeenCalledWith( + expect(logDebugMock).toHaveBeenCalledWith( `Cache not found for keys: ${[key, ...restoreKeys].join(', ')}` ) })