GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-08-13 03:59:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review.

Browse Source 
part of CURA-9347

Co-authored-by: Joey de l'Arago <joeydelarago@gmail.com>
This commit is contained in:
Remco Burema 2022-12-02 19:07:41 +01:00 committed by GitHub
parent 3bc955fe8f
commit 9fe261ff58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
resources/qml/Dialogs/DiscardOrKeepProfileChangesDialog.qml
View File

@ -178,15 +178,15 @@ UM.Dialog
{ {
id: overwriteButton id: overwriteButton
text: catalog.i18nc("@action:button", "Save as new custom profile") text: catalog.i18nc("@action:button", "Save as new custom profile")
onClicked: base.accept()
visible: alternateStates.state != "" visible: alternateStates.state != ""
onClicked: base.accept()
}, },
Cura.PrimaryButton Cura.PrimaryButton
{ {
id: saveButton id: saveButton
text: catalog.i18nc("@action:button", "Save changes") text: catalog.i18nc("@action:button", "Save changes")
onClicked: base.reject()
visible: alternateStates.state == "saveFromCustom" visible: alternateStates.state == "saveFromCustom"
onClicked: base.reject()
} }
] ]
} }

3
resources/qml/Dialogs/RenameDialog.qml
View File

@ -67,9 +67,8 @@ UM.Dialog
} }
// spacer // spacer
Rectangle Item
{ {
color: base.backgroundColor
height: UM.Theme.getSize("wide_margin").height height: UM.Theme.getSize("wide_margin").height
width: height width: height
} }

4
resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml
View File

@ -155,9 +155,9 @@ Item
ProfileWarningReset ProfileWarningReset
{ {
id: profileWarningReset id: profileWarningReset
fullWarning: false
anchors.right: parent.right
width: childrenRect.width width: childrenRect.width
anchors.right: parent.right
fullWarning: false
} }
QualitiesWithIntentMenu QualitiesWithIntentMenu