GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-06-04 11:14:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Minor codestyle issues

CURA-8683

Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
This commit is contained in:
Jaime van Kessel 2022-01-12 15:57:20 +01:00 committed by GitHub
parent 59479ee223
commit f44d4d341f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
resources/qml/Menus/NozzleMenu.qml
View File

@ -46,13 +46,10 @@ UM.Menu
var extruder = activeMachine.extruderList[extruderIndex] var extruder = activeMachine.extruderList[extruderIndex]
return (extruder === undefined) ? false : extruder.isEnabled return (extruder === undefined) ? false : extruder.isEnabled
} }
onTriggered:Cura.MachineManager.setVariant(nozzleMenu.extruderIndex, model.container_node) onTriggered: Cura.MachineManager.setVariant(nozzleMenu.extruderIndex, model.container_node)
} }
onObjectAdded: onObjectAdded: nozzleMenu.insertItem(index, object)
{
nozzleMenu.insertItem(index, object)
}
onObjectRemoved: nozzleMenu.removeItem(object) onObjectRemoved: nozzleMenu.removeItem(object)
} }

2
resources/qml/Menus/ViewMenu.qml
View File

@ -27,7 +27,7 @@ Menu
{ {
id: cameraViewMenu id: cameraViewMenu
title: catalog.i18nc("@action:inmenu menubar:view","Camera view") title: catalog.i18nc("@action:inmenu menubar:view", "Camera view")
property string cameraMode: UM.Preferences.getValue("general/camera_perspective_mode") property string cameraMode: UM.Preferences.getValue("general/camera_perspective_mode")
Connections Connections

2
resources/qml/Widgets/MenuItem.qml
View File

@ -15,7 +15,7 @@ MenuItem
implicitHeight: UM.Theme.getSize("setting_control").height + UM.Theme.getSize("narrow_margin").height implicitHeight: UM.Theme.getSize("setting_control").height + UM.Theme.getSize("narrow_margin").height
opacity: enabled ? 1.0 : 0.5 opacity: enabled ? 1.0 : 0.5
height: visible ? implicitHeight: 0 height: visible ? implicitHeight : 0
arrow: UM.RecolorImage arrow: UM.RecolorImage
{ {