Conflicts:
plugins/Marketplace/resources/qml/Marketplace.qml -> Whole layout changed, while the onboarding banner got added. I re-added the onboarding banner item and the new search link at locations where I thought it was appropriate.
plugins/Marketplace/resources/qml/Packages.qml -> A small conflict where new properties got added while I moved the width property up a bit for consistency. Easy enough to fix.
Previously, this would cause the Marketplace to freeze. We're still not entirely sure why. It seems to be a bug in Qt, but it's rather hard to deal with.
This new solution is nicer in some ways but not as neat in others.
- We're no longer clearing the content of the loader, so the QML and the package data remains in memory while the Marketplace is closed. We deem this to not be a problem, because the memory usage of this package data is only a couple of kB, nothing compared to the memory used by the slicer when it loads a model.
- On the other hand, it's now possible to programmatically change the tab there, instead of manually having to click the buttons.
- Fixes a bug where the highlighted tab of of the tab bar doesn't update when closing and re-opening the Marketplace. And a bug where there was a search bar for the manage page while it didn't work.
Contributes to issue CURA-8565.
Rich Text is rendered a bit like HTML, where all of the whitespace gets changed into a single space. This is normally not so bad, but with newlines it's annoying. This preserves the newlines from the description.
Contributes to issue CURA-8565.
These are typically visually smaller buttons, since they don't have an outline. It makes more sense to use the size of the text then, or something thereabouts.
Contributes to issue CURA-8565.
I considered rewriting the section title property to be QML-only and translate it from the QML, but this is a bit simpler in the end, even though there is data duplication now.
Contributes to issue CURA-8565.
Apparently Qt marks it as 'truncated' then, even though it's not really. Don't show the ... nor the 'read more' button if there is nothing more to read.
Contributes to issue CURA-8565.
We can't show rich text in the package list, because the we use the onLineLaidOut signal there, which doesn't work with Rich Text. So for the package list we should NOT use the formatted version of the description because that will contain ugly HTML tags that the user wouldn't want to see. Show the original description there. Use the formatted description only in the detail page where we don't use onLineLaidOut.
Contributes to issue CURA-8565.
Some plug-ins could have very long descriptions now. We show all of it, but that could go off the screen in theory.
This makes the content scrollable if it goes off the screen.
Contributes to issue CURA-8565.
There are a lot of buttons leading to websites now: An arrow leading to the author website. An author name leading to the author website. A 'read more' label leading to the plug-in website and this new button leading to the plug-in website. Maybe we should raise this with the designer.
Contributes to issue CURA-8565.
Quite easy. It turned out the model already had this information, due to foresight when the card itself got implemented.
Contributes to issue CURA-8565.
It used to be fine, but the font of the button got made different from the font of the description. It should be the same as the description, so this should remain correct even if the fonts change again.
Contributes to issue CURA-8565.
This is necessary because we can't anchor to the bottom of the card here, and because we want to swap out the description for a download count in the extended detail card.
Contributes to issue CURA-8565.
If it is detailed, it currently hides the short description. That is not quite enough, but we'll expand that behaviour.
Contributes to issue CURA-8565.
This is already set by the StackView, which (logically) requires that the children fill the entire space taken by the StackView.
Contributes to issue CURA-8565.
