190 Commits

Author SHA1 Message Date
David Fries
38695d9572 Fix RecommendedSupportSelector.qml assign undefined to int
share/cura/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml:60:17:
Unable to assign [undefined] to int

If undefined use Widgets/SingleSettingComboBox.qml
default of Cura.ExtruderManager.activeExtruderIndex
2024-08-31 12:11:59 -05:00
Saumya Jain
f2b2048b51 Update support extruder settings behavior
Changed the settings in RecommendedSupportSelector.qml so that now all extruders will not be updated by default. However, when a user changes the selected index, a temporary update to all extruders will be triggered. This allows for specific user-directed changes to propagate correctly across all extruders.

CURA-11776
2024-03-27 11:58:55 +01:00
Remco Burema
bc64d8fa4e Fetch support extruder instead of the default.
The (main) problem here was that the 'active extruder' was queried for the value, which isn't the same as the support-extruder.

CURA-11725
2024-03-20 13:51:09 +01:00
c.lamboo
efe43325ae Fix intent display in darkmode 2023-11-27 17:21:20 +01:00
saumya.jain
ebf58aa972 propertyvalue update was not successful because of _remove_unused_value in propertyProvider
CURA-10967
2023-10-05 11:42:28 +02:00
saumya.jain
35528202b6 Fixes to improve update all extruder setting
CURA-10967
2023-09-29 14:44:34 +02:00
saumya.jain
a8f7e8636c CURA-10967
set property value updated to take into account if resolve is present or not.
2023-09-28 16:43:24 +02:00
c.lamboo
19c6c68b0a Fix cura recommended mode crashing
CURA-11051
2023-09-25 13:38:03 +02:00
Casper Lamboo
23d79de4b9
Make show custom button more visible in darkmode
CURA-10782
2023-07-25 13:34:29 +02:00
saumya.jain
4d99dabefc Discription added in the tooltip about skirt presence even after disabling it
CURA-10758
2023-07-17 10:42:07 +02:00
Jaime van Kessel
cd3e45c7c4
Merge branch '5.4' of github.com:Ultimaker/Cura 2023-06-12 15:34:54 +02:00
Jaime van Kessel
1c0be9c5ed
Also prevent warning spam if icon isn't set 2023-06-12 15:33:08 +02:00
Jaime van Kessel
7103b9b333
Prevent qml warning spam if custom_icon isn't set 2023-06-12 14:48:31 +02:00
Jelle Spijker
0f0d729549
Merge branch '5.4'
# Conflicts:
#	conanfile.py
#	resources/i18n/cs_CZ/fdmprinter.def.json.po
#	resources/i18n/de_DE/fdmprinter.def.json.po
#	resources/i18n/es_ES/fdmprinter.def.json.po
#	resources/i18n/fdmprinter.def.json.pot
#	resources/i18n/fi_FI/fdmprinter.def.json.po
#	resources/i18n/fr_FR/fdmprinter.def.json.po
#	resources/i18n/hu_HU/fdmprinter.def.json.po
#	resources/i18n/it_IT/fdmprinter.def.json.po
#	resources/i18n/ja_JP/fdmprinter.def.json.po
#	resources/i18n/ko_KR/fdmprinter.def.json.po
#	resources/i18n/nl_NL/fdmprinter.def.json.po
#	resources/i18n/pl_PL/fdmprinter.def.json.po
#	resources/i18n/pt_BR/fdmprinter.def.json.po
#	resources/i18n/pt_PT/fdmprinter.def.json.po
#	resources/i18n/ru_RU/fdmprinter.def.json.po
#	resources/i18n/tr_TR/fdmprinter.def.json.po
#	resources/i18n/zh_CN/fdmprinter.def.json.po
#	resources/i18n/zh_TW/fdmprinter.def.json.po
2023-06-08 12:36:46 +02:00
c.lamboo
57bece831f Don't scroll beyond bounds in recommended menu
CURA-10650
2023-06-06 16:31:36 +02:00
c.lamboo
27cc89ff89 Allow for custom descriptions/icons in packaged intents
CURA-9709
2023-05-31 12:54:56 +02:00
c.lamboo
62812393b0 Fix typos in translations
CURA-10369
2023-03-07 10:29:37 +01:00
c.lamboo
2c7bd7883a Make recommended mode-window scrollable
CURA-9793
2022-12-13 17:05:51 +01:00
Joey de l'Arago
e05c70ae38 Refactor ComponentWithIcon to use contents instead of loader.
CURA-9793
2022-12-12 14:22:38 +01:00
Joey de l'Arago
1e6184448c
Apply suggestions from code review
Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-12 11:44:21 +01:00
c.lamboo
e03b4e07f9 Simplify rounding
Use sliders stepSize and snapMode properties

CURA-9793
2022-12-08 17:11:04 +01:00
Jelle Spijker
91170e0aef
Apply suggestions from code review 2022-12-08 07:43:57 +01:00
Joey de l'Arago
bcdfa808a8 Switch to checking enabled extruder count for showing print with Component. This is because we want the SingleSettingExtruderBar to be hidden when there are 1 or less extruders, but also when there are 1 or less enabled extruders.
CURA-9793
2022-12-07 17:33:13 +01:00
Joey de l'Arago
f601229390 Move Validators to UM, so they can be used in UM components.
Update all TextFieldWithUnit to use our FloatValidator. This component now has proper styling when the input is invalid. The DoubleValidator was flagging numbers with a "." in them as an incorrect input (I assume this is because the region was set to europe on the OS where "," is common). The workaround is to use our FloatValidator which validates both "." and ","

CURA-9793
2022-12-07 16:27:42 +01:00
Joey de l'Arago
362877dee1 Add new recommended mode tooltips and remove extra margin at the bottom of tooltips.
CURA-9793
2022-12-06 10:50:04 +01:00
Joey de l'Arago
3ddebe7a84 The extrudersCHanged signal was incorrectly being emitted before the global stack had updated. This was causing the extruderIds to always return the old extruderIds to connected qml components.
The setting slider was incorrectly setting the slider value when updating the model.

CURA-9793
2022-12-06 10:37:06 +01:00
Joey de l'Arago
c495f0de3f Hide extruder selector when there is only one extruder.
CURA-9793
2022-12-05 17:11:05 +01:00
jspijker
8058c16f00 Merge branch 'main' into CURA-9793_extend_recommended_print_settings 2022-12-05 16:45:33 +01:00
Joey de l'Arago
ce5691c12d
Apply suggestions from code review
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-05 14:42:35 +01:00
Joey de l'Arago
741a112282 Remove recommended adhesion selector.
CURA-9793
2022-12-05 14:05:22 +01:00
Joey de l'Arago
d7e1aa08ac Update the single setting components to optionally update all extruders when a setting is settable per extruder or limited to extruder.
This forces all extruders to have their settings updated but only displays the value from a single extruder.

CURA-9793
2022-12-05 11:32:24 +01:00
Joey de l'Arago
540d810293 The slider was not forcing its setting value to stay the same when changes were made in the "Advanced" menu. This is because the slider updating and setting updating functions were intertwined. I've seperated them so that the slider no longer interferes with changes to the setting.
The Shell thickness settings were not being read or set correctly. I fixed this by setting the value to all extruders and reading from extruder 1. This setting is not set per machine but for all extruders. Not sure why.

CURA-9793
2022-12-05 10:23:40 +01:00
Joey de l'Arago
02572311bf Components were clickable when hidden.
CURA-9793
2022-12-02 16:19:29 +01:00
Joey de l'Arago
5b76e3dd7c Add component with icon generic component.
Add print walls and print top/bottom settings to recommended menu

CURA-9793
2022-12-02 12:41:04 +01:00
Joey de l'Arago
dfb6c04d00 Add SingleSettingTextField.qml
Added a workaround for states of inheriting components. See comments for details.

CURA-9793
2022-12-02 11:48:50 +01:00
Joey de l'Arago
62bae7df19 Collapse the setting section when the switch for the section is disabled.
Add collapse animation for setting items and setting section.

Swap out ColumnLayout for Layout. Animating the Layouts does not seem to be possible.

I had to put spacer back into the Column but it is the lesser of two evils.

CURA-9793
2022-12-01 14:03:11 +01:00
Joey de l'Arago
574b1000f6 Add tooltips
CURA-9793
2022-11-30 17:44:58 +01:00
Joey de l'Arago
522bf60e81 Adjust left margins
CURA-9793
2022-11-30 15:43:14 +01:00
Joey de l'Arago
d617566db4 Move show custom button next to setting section title.
CURA-9793
2022-11-30 15:36:15 +01:00
Joey de l'Arago
b356335f4f Correct spelling mistake
CURA-9793
2022-11-30 15:10:19 +01:00
Joey de l'Arago
dbf2ae4f60 Fix spacing vertical between Recommended sections and setting items.
CURA-9793
2022-11-30 15:09:05 +01:00
Joey de l'Arago
0514c62b3e Remove bad height assignment to dynamic layout
CURA-9793
2022-11-30 14:51:45 +01:00
Joey de l'Arago
dbf27a432f Change confusing naming of section enable switch.
CURA-9793
2022-11-30 12:12:41 +01:00
Joey de l'Arago
69af593d8c Make Slider generic component in UM. Make Infill slider into generic SingleSettinSlider which will work for any setting now.
Change slider theme slighly.

CURA-9793
2022-11-30 11:45:27 +01:00
Remco Burema
40b7233125 Also add save/reset buttons to custom profile.
part of CURA-9347
2022-11-29 23:18:15 +01:00
Remco Burema
0ea2830108 Add the 'safe to profile' button itself.
Currently only works for creating a new profile from current changes (when on top of a built-in profile). Only does the compare (not the safe yet) in the other circumstance. Also already anticipate the next commits by being able to hide the text and icon (because this will be added to the custom mode view as well).

part of CURA-9347
2022-11-29 22:54:30 +01:00
Joey de l'Arago
7ba0281136 Move required settingPropertyProvider into InfillSlider.
Use new RecommendedSetting components for Strength section of recommended.

CURA-9793
2022-11-29 17:50:40 +01:00
Joey de l'Arago
1224f076c3 Fix switch alignment
CURA-9793
2022-11-29 17:20:34 +01:00
Joey de l'Arago
c356b9d46f Rename ExtruderSelectorBar -> SingleSettingExtruderSelectorBar to be inline with new single setting widgets.
Move common functionality into SingleSettingExtruderSelectorBar

Add adhesion settings

CURA-9793
2022-11-29 17:00:55 +01:00
Joey de l'Arago
c240833868 Add Support type settings
CURA-9793
2022-11-29 16:23:49 +01:00