17119 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Ghostkeeper	a401c1d64f	Disambiguate between list of metadatas and metadata ... Because MyPy doesn't allow a variable to change its type later. Contributes to issue CURA-5330.	2018-06-15 17:03:04 +02:00
Ghostkeeper	79c6b2dad8	Use CuraApplication instead of Application ... Because UM.Application doesn't have any getPrintJobInformation function or anything like that. Contributes to issue CURA-5330.	2018-06-15 16:55:30 +02:00
Ghostkeeper	e717abf499	Fix typing related to Network Printing ... Contributes to issue CURA-5330.	2018-06-15 16:53:45 +02:00
Ghostkeeper	b07db74011	Fix more typing errors ... It never ends. Contributes to issue CURA-5330.	2018-06-15 15:44:29 +02:00
Ghostkeeper	cfd0bde6b1	Use CuraApplication instead of Application ... Because UM.Application has no function getMultiBuildPlateModel. Contributes to issue CURA-5330.	2018-06-15 15:32:44 +02:00
Ghostkeeper	797d05947c	Fix type errors ... Contributes to issue CURA-5330.	2018-06-15 15:20:41 +02:00
Ghostkeeper	9821793b46	Don't override boundingbox of SceneNode ... Whatever was intended here, it didn't work. Because when a method is called it is called on the class of the object. Methods are not attributes of instances but attributes of the class. The attribute of the class was never changed, so this had no effect. Contributes to issue CURA-5330.	2018-06-15 15:16:55 +02:00
Ghostkeeper	10f22f9c25	Cast result of getPluginObject to the plug-in type it implements ... We know for sure what the type of that plug-in is, only we can't import that type because it's a plug-in. We can (and did) import the plug-in type object MeshWriter though. Contributes to issue CURA-5330.	2018-06-15 15:09:19 +02:00
Ghostkeeper	e957f7b650	Fix typing errors ... Contributes to issue CURA-5330.	2018-06-15 15:07:08 +02:00
Ghostkeeper	2b33a1f1b6	Fix broken import with DefinitionContainerInterface ... And the ensuing type error that can then be found. Contributes to issue CURA-5330.	2018-06-15 14:31:29 +02:00
Ghostkeeper	0d52b03716	Fix the wrong types in this class ... These mistakes were found by MyPy. Contributes to issue CURA-5330.	2018-06-15 14:25:25 +02:00
Ghostkeeper	4c3d28709b	Add typing for all functions and fields ... Lots of typing so that MyPy can then check whether the functions are safe to call. Contributes to issue CURA-5330.	2018-06-15 14:07:33 +02:00
Ghostkeeper	8256788ed8	Use CuraApplication instead of Application ... Because we need to call getExtruderManager which is only in CuraApplication. Contributes to issue CURA-5330.	2018-06-15 13:40:43 +02:00
Ghostkeeper	a021820031	Fix call to getIdAtPosition ... I fixed the typing in the wrong way here. Sorry. Contributes to issue CURA-5330.	2018-06-15 13:34:39 +02:00
Ghostkeeper	7a33a8f212	Always import CuraVersion ... I don't know why there was this check around it because it is always necessary to start the application. Contributes to issue CURA-5330.	2018-06-15 13:28:55 +02:00
Ghostkeeper	1789a8f33e	Fix type of SelectionPass ... Contributes to issue CURA-5330.	2018-06-15 13:20:20 +02:00
Ghostkeeper	fe43219e34	Fix minor type mistakes ... Contributes to issue CURA-5330.	2018-06-15 13:14:56 +02:00
Ghostkeeper	75e5a185d9	Don't unnecessarily cast to a set ... The InstanceContainer version of getAllKeys was first casting to a list but I removed that, because everywhere where we were using it we were casting it directly to a set. Contributes to issue CURA-5330.	2018-06-15 13:07:55 +02:00
Ghostkeeper	b9727a33c6	Fix type of QtRenderer ... Because we're calling getWindowSize on it so it must be the QtRenderer, not the Renderer. Contributes to issue CURA-5330.	2018-06-15 11:38:11 +02:00
Ghostkeeper	ab32d64c01	Add types for ShaderPrograms ... Otherwise it'll think that this variable can only have None in it. Contributes to issue CURA-5330.	2018-06-15 11:34:35 +02:00
Ghostkeeper	7d98167383	Ignore type errors arising from misinterpretation of DepthFirstIterator type ... MyPy requests that this needs to have a __next__ function, but actually Python calls the __iter__ function first and then calls the __next__ function on the result of that. MyPy is wrong here. Contributes to issue CURA-5330.	2018-06-15 11:30:49 +02:00
Ghostkeeper	105f6d4271	Fix type of self._shader ... MyPy was thinking that this variable has type None, which is nonsense because no variable should always have type None. Contributes to issue CURA-5330.	2018-06-15 11:25:16 +02:00
Ghostkeeper	eda0d34fd9	Call from QtApplication instead of Application ... Because we're using createQmlComponent which is only in QtApplication. Contributes to issue CURA-5330.	2018-06-15 11:21:59 +02:00
Ghostkeeper	6e663ac6f5	Don't call getMachineManager on Uranium's application ... It is a function of CuraApplication. Contributes to issue CURA-5330.	2018-06-15 11:15:31 +02:00
Ghostkeeper	c3d4d5eba7	Ignore MyPy errors caused by DepthFirstIterator not being detected as iterator ... MyPy is wrong in this case. Contributes to issue CURA-5330.	2018-06-15 11:02:15 +02:00
Ghostkeeper	4418cf3aac	Prevent accessing private _instances variable ... We can get at this via the getProperty function. Contributes to issue CURA-5330.	2018-06-15 10:59:41 +02:00
Ghostkeeper	01a645e726	Use only CuraApplication ... It was complaining that getMachineManager doesn't exist, because that is in CuraApplication instead of UM.Application. I removed all references to UM.Application so that the imports are a bit simpler. Contributes to issue CURA-5330.	2018-06-15 10:28:07 +02:00
nean	3065023271	Create tevo_tornado.def.json	2018-06-14 23:38:47 +02:00
Diego Prado Gesto	b309e93767	CURA-5330 Fix typing in the VersionUpgrade plugin	2018-06-14 16:54:22 +02:00
Diego Prado Gesto	dc4556647a	CURA-5330 Fix code style in XmlMaterialProfile plugin	2018-06-14 16:49:26 +02:00
Diego Prado Gesto	a184fad8ee	CURA-5330 Add typing to the USBPrinting plugin	2018-06-14 15:57:30 +02:00
Diego Prado Gesto	7eba868574	CURA-5330 Fix typing and code style in the UM3NetworkPrinting plugin	2018-06-14 15:41:12 +02:00
Ghostkeeper	e0699a0997	Merge branch '3.4'	2018-06-14 14:57:20 +02:00
Ghostkeeper	7b82421751	Don't disable E steppers when pausing ... There is no such command to disable only the E stepper drivers. This command M84 gets interpreted as disabling ALL stepper drivers, which on some printers would cause the print bed to fall down.	2018-06-14 14:57:03 +02:00
Diego Prado Gesto	dfd20e1362	CURA-5335 Looking for the actual line number in the gcode when using the filament change script.	2018-06-14 14:35:46 +02:00
Diego Prado Gesto	77c7839bfe	CURA-5334 Remove material_diameter value in definition file in favor of ... the setting in the extruder definition.	2018-06-14 14:19:52 +02:00
Diego Prado Gesto	49abf38210	CURA-5334 Ensure the material manager is fetched before call	2018-06-14 13:24:07 +02:00
Mark	49a3444b13	Unhide label for master	2018-06-14 10:59:05 +02:00
Jack Ha	f5dd7f6e92	CURA-5456 fixed typo, fixed multi objects with disabled extruders in message	2018-06-14 10:27:24 +02:00
Ghostkeeper	b331736cb2	Let _findInstanceContainerDefinitionId work with DefinitionContainerInterface ... But where it needs the .id field it needs to ignore this type because this works with getattr weirdness. Contributes to issue CURA-5330.	2018-06-14 09:58:16 +02:00
Ghostkeeper	eac3c759cd	Cast each container in their stack to actual types ... We know for sure that these containers have those types. We'll accept the risk here that this assumption was wrong. Contributes to issue CURA-5330.	2018-06-14 09:58:07 +02:00
Diego Prado Gesto	2c7c167fe0	CURA-5335 Looking for the actual line number in the gcode when using the filament change script.	2018-06-13 20:41:56 +02:00
Diego Prado Gesto	eb65a11e18	CURA-5330 Fix code style and typing in Toolbox plugin	2018-06-13 18:22:27 +02:00
Diego Prado Gesto	0a21ce44b0	CURA-5330 Fix code style and typing in GCodeReader plugin	2018-06-13 17:36:04 +02:00
Diego Prado Gesto	51888d86fe	CURA-5330 Fix typing check	2018-06-13 17:13:33 +02:00
Ghostkeeper	5bf553c63c	Merge branch 'mypy_fixes' of ssh://github.com/Ultimaker/Cura into mypy_fixes	2018-06-13 17:03:31 +02:00
Ghostkeeper	bb366afc2b	Merge branch 'master' into feature_send_material_profiles	2018-06-13 16:57:16 +02:00
jack	06f73ac798	Merge pull request #3920 from Ultimaker/CURA-5450_remove_concentric_3d ... CURA-5450 remove concentric 3d	2018-06-13 16:55:44 +02:00
Jack Ha	5b688fceb1	CURA-5450 update comment	2018-06-13 16:54:55 +02:00
Diego Prado Gesto	eca23e5b5d	CURA-5330 Fix typing in 3MFReader plugin	2018-06-13 16:48:08 +02:00