Jaime van Kessel
73ca50d958
Handle exception when adhesion extruder could not be found
...
This should be pretty rare; the crash would only happen due to a race condition
cura-8584
2021-11-09 10:17:32 +01:00
Jaime van Kessel
a613a70758
Don't disable group nodes if it's extruder is disabled
...
Group nodes don't really have an extruder, so exclude them from that check
CURA-7710
Fixes #8336
2021-11-05 16:31:35 +01:00
Ghostkeeper
4aa10ba42f
Use initial layer line width factor from adhesion extruder
...
This is a per-extruder setting. So get it from the proper extruder.
2021-10-11 10:08:11 +02:00
Ghostkeeper
ff7b2a673f
Add experimental warning and error message types to two messages
...
These are for our testers to be able to test the new message types. Later they will be added to all messages that need them.
Contributes to issue CURA-7278.
2021-07-26 15:17:54 +02:00
Ghostkeeper
cf7e1af99d
Don't create disallowed areas for areas without any points
...
It seems people edit definitions to remove all vertices. This causes Cura to crash because of the calculation of disallowed areas.
Fixes Sentry issue CURA-2FY.
2021-06-17 14:56:49 +02:00
Jaime van Kessel
037b5d5b44
Ensure that the skirt_brim_line_width is selected from right extruder
...
This fixes CURA-7835 and Fixes #8716
2020-12-18 11:31:55 +01:00
Jaime van Kessel
7096f64ca2
Fix crash when extruder could not be found
...
Fixes #8891
2020-12-07 16:45:28 +01:00
Jaime van Kessel
99c12de6b0
Merge branch 'master' of github.com:Ultimaker/Cura into fix_grouping_below_build_plate
2020-11-25 15:42:15 +01:00
Jaime van Kessel
e13ffb597d
Increase resolution of prime tower shadow and use doulbe brim size
...
It needs to use the double brim size, as it needs to ensure that
it has enough room for it's own brim and any object brim.
The resolution of the circle is increased so that the shadow matches
more with what is actually being printed
CURA-7643
2020-10-20 13:41:35 +02:00
Jaime van Kessel
c33c025a6c
Add getters for Width/height/depth to build volume
...
CURA-7440
2020-10-02 10:04:46 +02:00
Jaime van Kessel
09066f2744
Don't mark children nodes in a group below the buildplate
...
Fixes #8268
2020-09-02 14:19:38 +02:00
Nino van Hooff
8464121001
Fix prime tower adhesion size
...
CURA-6980
2020-07-16 13:04:06 +02:00
Nino van Hooff
e39f004202
Do not increase diallowed area margin when tower brim is used
...
CURA-6980
2020-07-13 13:38:20 +02:00
Jaime van Kessel
9014fa79e2
Cache result of getEdgeDisallowedSize
...
CURA-7106
2020-06-23 11:01:43 +02:00
Jaime van Kessel
ea568f4ad5
Make the updating of the buildvolume a bit trigger happy
...
CURA-7106
2020-06-23 10:52:39 +02:00
Nino van Hooff
89f0970a88
Remove trailing whitespace from Python files
2020-05-29 14:30:33 +02:00
Jelle Spijker
679739d09d
Applied requested changes proposed by @ninovanhooff
...
Fixed a couple of missed double quotes, trailing and leading spaces, to long comment lines
2020-04-27 20:09:00 +02:00
Jelle Spijker
6aedab78dc
Converted comments in dir Cura/cura to rst style
...
Converted doxygen style comments to reStructuredText style in the files found in Cura/cura directory using the script dox_2_rst.py (provided in the Uranium repo). Comments were manually checked and changed if needed.
2020-04-21 16:58:45 +02:00
Ghostkeeper
f6479840f6
Fix calculation of infill wipe distance starting from infill location
...
Subtract the thickness of the walls from this setting. This most likely ends up negative and thus not counting because it's maxed with something that starts at 0.
I've also simplified this algorithm a bit. Easier to follow if you ask me.
Done as a 5 minute fix.
2020-04-14 17:59:00 +02:00
Ghostkeeper
54b6c2a54e
Merge branch '4.6'
2020-04-09 12:55:50 +02:00
Ghostkeeper
953630ad0b
Be robust against some objects not having an extruder assigned
...
This could happen for instance when a plug-in adds a model.
Fixes Sentry issue CURA-GR.
2020-04-09 12:55:07 +02:00
Ghostkeeper
de220a74bc
Don't update build volume when prime Z position is changed
...
It doesn't affect the build volume, since we don't need to move the prime blob disallowed area. It is projected onto the build plate after all.
Most likely this won't affect anyone since the prime Z position is a machine setting that can't normally be modified. But hey, it's a bit more precise anyway.
Found during work on the Settings Guide.
2020-04-06 00:29:48 +02:00
Jaime van Kessel
e74f049142
Fix bunch of issues found by pylint
2020-01-10 16:37:46 +01:00
Nino van Hooff
dd8993e88c
revert 0 buildvolume edgedisallowedsize for one_at_a_time
...
Turns out that the artificial disallowed area around the inside of the
build volume was necessary to take the brim into account when deciding
whether a model was outside the buildvolume.
The issue for which I removed this in the first place seems not to be
an issue anymore due to other commits
Reverts and e5fb9fb8 and e5c9bca
CURA-6522
2019-12-06 12:17:21 +01:00
Jaime van Kessel
50d72692d8
Merge branch 'master' of github.com:Ultimaker/Cura into CURA-6522_one_at_a_time_overlapping_build_area
2019-11-20 16:48:00 +01:00
Jaime van Kessel
00078fd659
Remove a bunch of unused imports
2019-11-08 13:38:42 +01:00
Nino van Hooff
e5fb9fb8cf
Remove hack used to draw some build area edge border
...
This disallowed area should not exist and caused difference in behavior
between all-at-once and one-at-a-time printing for a single object
CURA-6522
2019-10-31 14:59:54 +01:00
Ghostkeeper
ce4c5a1c93
Remove unnecessary listening to switching extruder tabs
...
Also fix unnecessary emitting of switching extruder tabs.
This should improve performance a lot. I tested a lot of things and am convinced that it didn't break anything. But the automated GUI tests and QA team should be the final arbiters of that...
Contributes to issue CURA-6793.
2019-10-15 15:01:45 +02:00
Jaime van Kessel
241ca56e6e
Fix stupid derp issue
...
I really need coffee before coding
2019-09-26 09:46:02 +02:00
Jaime van Kessel
dbbeeef9a5
Don't render buildvolume if it's set to invisible
2019-09-26 09:11:54 +02:00
Jaime van Kessel
0f8dfeafc1
fix typo
2019-09-16 09:26:12 +02:00
Jaime van Kessel
0ff9d72c4c
Remove use of deprecated extruders property
2019-09-13 17:27:16 +02:00
Jaime van Kessel
0cfaac3940
Set the BuildVolume node to disabled
...
This prevents accidental modification of the node
2019-08-29 11:23:01 +02:00
Lipu Fei
bb34e0da39
Increase axis line width
2019-08-05 10:44:43 +02:00
Jaime van Kessel
9ceb9ce18b
Fix typing issues
...
They were caused by upgrading to a higher mypy version, which found more mistakes
2019-07-23 12:58:46 +02:00
Jaime van Kessel
6bb9e6097a
Rename "collideWithArea" to "collideWithAreas"
...
This better reflects what it does (eg; it is checking for multiple colissions, not just one)
2019-07-19 16:23:57 +02:00
Remco Burema
f5b0cae554
Prime-brim calculation needs adhesion extruder, not just any.
2019-07-02 07:46:21 +02:00
Jaime van Kessel
6136f5a2f2
Further simplify the build volume code
2019-06-28 15:22:58 +02:00
Jaime van Kessel
691d106719
Remove old unused code
2019-06-28 15:09:08 +02:00
Jaime van Kessel
2133fc78e0
Remove unused code
2019-06-28 15:01:09 +02:00
Jaime van Kessel
efc6ef2905
Add missing typing
2019-06-28 13:44:47 +02:00
Lipu Fei
1d85e60a6b
Merge remote-tracking branch 'origin/master' into CURA-6460_remove_square_tower
2019-06-17 13:11:07 +02:00
Jaime van Kessel
f842769c1d
Fix situation where _calculateMoveFromWallRadius could cause exception
2019-06-07 17:21:28 +02:00
Jaime van Kessel
4018c24b4c
Split out all the individual steps for getting the edgeDisallowedSize
...
This makes it so much easier to write tests for it
2019-06-07 17:14:51 +02:00
Jaime van Kessel
3967c995f1
Split out updating the machine size properties so it can be tested easily
2019-06-07 16:42:51 +02:00
Jaime van Kessel
2f83fa1a42
Small code simplification
2019-06-07 16:34:38 +02:00
Jaime van Kessel
887f50dee4
Add tests for calculating the extra z clearance
2019-06-07 16:30:29 +02:00
Jaime van Kessel
54740dd486
Add some unhappy flow tests for rebuild
2019-06-07 16:09:18 +02:00
Jaime van Kessel
090b7ac225
Refactor the rebuild function to cut it up in smaller bits
2019-06-07 16:08:47 +02:00
Jaime van Kessel
06aaf40d06
Add test for computation of prime blob
2019-06-07 14:29:15 +02:00