22896 Commits

Author SHA1 Message Date
fieldOfView
d00ec619f5 Remove unused imports 2020-03-22 18:58:16 +01:00
fieldOfView
138dbddb10 Restore the SettingDefinition relations without killing a puppy 2020-03-22 18:51:43 +01:00
fieldOfView
4600ee9355 Change wording for clarity 2020-03-22 18:35:01 +01:00
fieldOfView
6e09e9821f Show support settings when support meshes are present in the scene 2020-03-22 18:23:32 +01:00
Ghostkeeper
485e37e7f5
Extruders can be undefined, not null
This happens when the printer is changed, such as when changing the Machine Width in the machine settings dialogue. It updates these menus then and if not all extruders are defined it'll give the following errors:
2020-03-20 16:56:57,839 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/Menus/SettingsMenu.qml:51: TypeError: Cannot read property 'isEnabled' of undefined
2020-03-20 16:56:57,840 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/Menus/SettingsMenu.qml:44: TypeError: Cannot read property 'isEnabled' of undefined
2020-03-20 16:56:57,841 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/Menus/MaterialMenu.qml:26: TypeError: Cannot read property 'isEnabled' of undefined
2020-03-20 16:56:57,841 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/Menus/MaterialMenu.qml:28: TypeError: Cannot read property 'material' of undefined

Done during Turbo Testing and Tooling.
2020-03-20 17:03:08 +01:00
Ghostkeeper
2f3462203c
Fix QML errors due to property providers not being initialised yet
This then updates in a fraction of a millisecond later before things even appear on the screen, so it's not so bad to not have a tooltip or to have it show 0 then.

Done during Turbo Testing and Tooling.
2020-03-20 16:58:18 +01:00
Ghostkeeper
31aee866f4
Check if options are available before matching on them
This prevents a QML warning when the ListModel is created before the property provider is. This QML warning looked like this:
2020-03-20 15:04:30,012 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/cura/../resources/qml/MachineSettings/ComboBoxWithOptions.qml:74: TypeError: Cannot call method 'match' of undefined

Done during Turbo Testing and Tooling.
2020-03-20 15:09:46 +01:00
Ghostkeeper
5cfe71e516
Fix binding loop in action panel widget
This widget can't set its width to the width of its children, since its children anchor to its right-hand side which depends on the width.
This fixes the following warning in the log:
2020-03-20 14:25:20,351 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/plugins/PrepareStage/PrepareMain.qml:16:5: QML ActionPanelWidget: Binding loop detected for property width

Done during Turbo Testing and Tooling.
2020-03-20 14:52:33 +01:00
Ghostkeeper
3af91bfca7
Fix QML warning assigning undefined to an integer field
Fixes the following QML warning in the logs:
2020-03-20 14:02:13,482 - WARNING - [MainThread] UM.Qt.QtApplication.__onQmlWarning [406]: file:///home/trin/Gedeeld/Projects/Cura/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml:125:13: Unable to assign [undefined] to int

Instead it now assigns the first extruder before a printer has been created. The first extruder also doesn't exist yet at this point, but this doesn't really matter because there is no interface to show yet at this point.

Done during Turbo Testing and Tooling.
2020-03-20 14:17:24 +01:00
Ghostkeeper
c44f82c44f
Add placeholder header pattern
This removes a warning from our log that this image couldn't be found. Instead it now draws a completely transparent image there.
The warning that is no longer in the log now looked like this:
2020-03-20 13:52:27,980 - WARNING - [MainThread] UM.Qt.Bindings.Theme.getImage [133]: No image header_pattern defined in Theme

Done during Turbo Testing and Tooling.
2020-03-20 14:05:42 +01:00
Ghostkeeper
c7e6553dbf
Disallow printers larger than 2km
To do this, I'm giving more power to the NumericTextFieldWithUnit QML element, to allow an arbitrary minimum and maximum. Enforcing this minimum and maximum is fairly simple with a JavaScript hook. This hook is necessary because the DoubleValidator allows intermediary values which defeats the purpose, essentially allowing any number as long as it has the correct number of digits.
Printers larger than 2km would start to give overflow errors in its X and Y coordinates. Z is okay up to about 9 billion kilometres in theory, since we don't need to do any squaring math on those coordinates afaik. In practice I'm doing this because at very high values the Arranger also gives errors because Numpy can't handle those extremely big arrays (since the arranger creates a 2mm grid).

Fixes Sentry issue CURA-CB.
2020-03-20 11:16:16 +01:00
Remco Burema
3f69e11d90
Merge pull request #7311 from fieldOfView/fix_project_comments
Fix loading comments in gcode snippets from 3mf projects
2020-03-20 11:13:23 +01:00
Jaime van Kessel
49949acdf2
Merge branch 'master' of github.com:Ultimaker/Cura 2020-03-20 11:05:08 +01:00
Jaime van Kessel
decf96e99e
Set verticalAlignment of numericTextField
Contributes to #7300
2020-03-20 11:04:24 +01:00
Nino van Hooff
65336d84e5 Add pytest to requirements 2020-03-20 10:57:23 +01:00
fieldOfView
7f6a39d7d0 Fix loading comments in gcode snippets from 3mf projects
Fixes #7304
2020-03-20 09:26:31 +01:00
Ghostkeeper
44b61d370f
Merge branch 'master' of github.com:Ultimaker/Cura 2020-03-19 14:48:45 +01:00
Ghostkeeper
df0a3143d2
Merge branch 'master' of https://github.com/Magicfirm/Cura into Magicfirm-master 2020-03-19 14:43:47 +01:00
konskarm
90ed7ac184
Merge pull request #7298 from Ultimaker/CURA-7311_stair_step_height_0_for_pva
Reduce stair step height to 0 for PVA
2020-03-19 14:12:28 +01:00
konskarm
7d2391c4ed
Merge pull request #7101 from yyh1002/master
Add DXU machine profile
2020-03-18 16:12:50 +01:00
Ghostkeeper
fdd1cef11a
Reduce stair step height to 0 for PVA
Given that:
* stair stepping is intended to be used to reduce the adhesion between support and the model, where the support rests on the model, and to reduce scarring, and
* PVA doesn't suffer from scarring or adhesion issues due to its water-solubility, and
* our current stair stepping algorithm has some bugs, causing support to disappear sometimes

we've decided to set stair stepping to 0 for all PVA profiles for UM3, UMS5 and UMS3.

Contributes to issue CURA-7311.
2020-03-18 15:50:27 +01:00
Jaime van Kessel
8a7823e49b
Merge branch 'fix_3mf_file_watcher' of https://github.com/fieldOfView/Cura 2020-03-18 12:51:53 +01:00
Jaime van Kessel
a26de5ce79
Gracefully handle the sitation if the changelog was not found
CURA-4R
2020-03-18 11:17:23 +01:00
Jaime van Kessel
ced25adc2b
Merge branch 'CURA-7017_link_to_help' of github.com:Ultimaker/Cura 2020-03-18 10:49:35 +01:00
Kostas Karmas
34f81ed0b0 Add link then the printer is not found
CURA-7017
2020-03-18 09:31:13 +01:00
konskarm
39f41e8e74
Merge pull request #7112 from mehmetsutas/master
Update Rigid3D Printer Profiles
2020-03-17 16:37:58 +01:00
jeffkyjin
aea8dc4856 remove has_machine_quality for grid 2+ 2020-03-17 23:27:00 +08:00
Nino van Hooff
04af203bb4 Revert "Ensure the default Trust violation handler is always called"
This debug change should never have been committed.

CURA-7016
2020-03-17 13:51:39 +01:00
Ghostkeeper
afe8158a3c
Merge branch 'master' of github.com:Ultimaker/Cura 2020-03-17 12:52:20 +01:00
Jaime van Kessel
56c387502a
Strip extension from file_name when printing via the cloud
ST-2880
2020-03-16 15:54:41 +01:00
konskarm
c19a0c24a2
Merge pull request #7243 from oducceu/master
Add Flying Bear Printers
2020-03-16 09:08:18 +01:00
Ghostkeeper
ca65aa4112
Add missing setting descriptions
These are summarised from the Settings Guide articles I wrote a month ago.
2020-03-15 19:33:53 +01:00
ODUCCEU
a5bdea75e0 Reduce redundant variants 2020-03-13 13:45:35 +03:00
ODUCCEU
68988c1d7b Change file names according to naming convention 2020-03-13 12:52:51 +03:00
Nino van Hooff
656c60452c
Merge pull request #7182 from Ultimaker/CURA-7016
[CURA-7016] Add actual public key instead of dummy.
2020-03-13 10:50:21 +01:00
Jaime van Kessel
34a2c7ca0f
Merge branch 'master' of github.com:Ultimaker/Cura 2020-03-13 10:37:31 +01:00
Jaime van Kessel
2fc8c0e5b5
Fix variant from extruder not restoring correctly 2020-03-13 10:37:08 +01:00
konskarm
3d054a9400
Merge pull request #7223 from Ultimaker/CURA-7255_infill_only_dropdown
CURA-7255_infill_only_dropdown
2020-03-13 10:30:09 +01:00
konskarm
a591ca157f
Merge pull request #7268 from Ultimaker/CURA-7211_pos_infill_defaults_0
CURA-7211_pos_infill_defaults_0
2020-03-13 10:27:11 +01:00
Nino van Hooff
2625bbef44 Changed pos infill only label per suggestions by Tim and Yi-An
CURA-7255
2020-03-12 14:01:03 +01:00
Jaime van Kessel
e54e41644e
Merge branch 'master' of github.com:Ultimaker/Cura 2020-03-12 13:39:48 +01:00
Nino van Hooff
5923f408d0 Add mypy==0.740 to requirements 2020-03-12 13:39:15 +01:00
Jaime van Kessel
78bbc4c955
Add work around to prevent setting not updating 2020-03-12 13:38:36 +01:00
Nino van Hooff
ce12827879 Fix infill mesh defaults not visible when changing per object settings
The problem: When infill mesh is set, wall_thickness and
top_bottom_thickness are added to the settings. Then these settings are
set to visible on the visibility_handler.
It appears however, that the visibility_handler considers all added
settings to be visible. It thus concludes that no UI update is necessary
because the settings are already added.
2020-03-12 13:25:29 +01:00
Jaime van Kessel
d01286a340
Remove all duplicate entries from dark theme 2020-03-10 11:57:30 +01:00
Jaime van Kessel
1a24e9a04a
Remove unneeded overrides from dark theme 2020-03-10 11:35:07 +01:00
Jaime van Kessel
9f8b882452
Merge branch 'transparent_support' of https://github.com/Ghostkeeper/Cura 2020-03-10 11:26:05 +01:00
Ghostkeeper
d7d91d2fec
Don't translate 'Language:' string
This should make it easier to find the language drop-down again if you can't read the current language.

Done as a 5 minute fix.
2020-03-10 11:19:32 +01:00
Matt Jani
43ab23439b Fixed small typo in nothing to slice
CURA-7277
2020-03-10 11:05:30 +01:00
Matt Jani
3887814660 Update the nothing to slice message
The message didn't list all the cases that it could pop up.

CURA-7277
2020-03-10 10:59:33 +01:00