25054 Commits

Author SHA1 Message Date
Ghostkeeper
593cd516ce
Fix typo in variable name
Otherwise you can't open any files any more. How did we not see this earlier?

Contributes to issue CURA-7996.
2021-02-09 14:24:09 +01:00
Ghostkeeper
ec986990a2
Merge branch 'master' into CURA-7996_Fix_trying_to_open_deleted_files_from_the_recent_files_list 2021-02-09 14:20:53 +01:00
Ghostkeeper
596d1570fb
Show error code if MyPy failed
This makes debugging it slightly easier.
2021-02-09 13:48:57 +01:00
Remco Burema
929149bf4e
Merge pull request #9232 from Ultimaker/CURA-7615_store_metadata
Retain metadata from 3MF files through save/load loops
2021-02-09 11:44:13 +01:00
Ghostkeeper
d8fba53952
Document addToRecent property
Contributes to issue CURA-7996.
2021-02-09 10:07:23 +01:00
Ghostkeeper
b815d63096
Add cura: namespace before setting keys, and store the rest in um_node.metadata
This retains per-node metadata entries.

Contributes to issue CURA-7615.
2021-02-08 17:37:38 +01:00
Ghostkeeper
c89a397e59
Merge branch 'master' into CURA-7615_store_metadata 2021-02-08 16:27:38 +01:00
Ghostkeeper
06086dfaaf
Fix reading per-object settings from 3MF object resources
This metadata has been changed to contain other information. Readers of information from 3MF need to adjust their stance too to filter out the information they need from the metadata of the metadata.

Contributes to issue CURA-7615.
2021-02-08 15:07:33 +01:00
Kostas Karmas
7be67f43f8 Let the FileNotFound error be handled later in the read file process
An error will pop up by the ReadFileJob if the file cannot be found. If we also handle the File
NotFound error in the checkIsValidProjectFile, then two error message will pop up in the user's
screen, which is not desired. So, let only the ReadFileJob show it's error instead.

CURA-7996
2021-02-08 11:59:32 +01:00
Kostas Karmas
56b3cc5fe5 Don't stop the readLocalFile process if there is no workspace reader
Or else the non-project files, which do not get a workspace reader by definition, won't be opened
in Cura.

CURA-7996
2021-02-08 11:58:12 +01:00
Kostas Karmas
f8a9e7f2d2 Pass the "add to recent" as an input var to dialogs that open projects
This way it is clear before to the dialog whether it should add the file to the recent files list,
before the dialog opens.

CURA-7996
2021-02-08 11:55:28 +01:00
Ghostkeeper
b54f792561
More appropriate error message
Project files can't be a directory.

Contributes to issue CURA-7996.
2021-02-05 15:29:56 +01:00
Ghostkeeper
79ec71ca4c
Move top/bottom settings to separate category
Implements CURA-8006.
2021-02-05 14:59:38 +01:00
Kostas Karmas
ee22be74b9 Properly check whether the file should be added to recent
When importing only the models of a project file, Cura wasn't checking whether the file should
be added to the recent files list. This commit fixes that.

CURA-7996
2021-02-05 12:14:01 +01:00
Kostas Karmas
e2699a5ab8 Display the correct message when opening deleted files from Recent
If a file that existed in the Recent Files list was deleted, Cura was still trying to open the file
on user's request without properly displaying an error if the file was not found.

This is now fixed by popping up a message to indicate that the file doesn't exist.

CURA-7996
2021-02-05 12:10:23 +01:00
Ghostkeeper
ba5b033499
Don't crash when not able to read maximum file name length
Just use a safe-ish maximum then.

Fixes Sentry issue CURA-1QY.
2021-02-04 17:10:03 +01:00
Ghostkeeper
577e45595e
Don't crash when cloud response is invalid JSON
Perhaps if the connection is interrupted this could happen.

Fixes Sentry issue CURA-1QX.
2021-02-04 17:05:55 +01:00
Jaime van Kessel
adacb95dc6
Merge pull request #9229 from onitake/fix/appstream
Fix upstream metadata
2021-02-04 15:43:57 +01:00
Ghostkeeper
5138466fea
Merge branch 'feature/thumbnail' of https://github.com/Gravedigger7789/Cura into Gravedigger7789-feature/thumbnail 2021-02-04 15:19:07 +01:00
Jaime van Kessel
b30bacc9f8
Merge branch 'master' of https://github.com/RFBomb/Cura 2021-02-04 14:46:29 +01:00
Remco Burema
b97b7d6fa9
Set empty project hint back to false before reading.
CURA-7996
2021-02-04 13:04:00 +01:00
Konstantinos Karmas
6d3ea283d1
Merge pull request #9233 from Ultimaker/CURA-7502_Overview_documentation_for_3D_scene
CURA-7502: Overview documentation for the 3D scene
2021-02-04 11:37:42 +01:00
Jelle Spijker
ef8e5a52c1
Merge pull request #9231 from Ultimaker/CURA-7996_add_empty_file_hint
[CURA-7996] Possible to distinguish between empty and corrupt 3MF.
2021-02-04 10:50:47 +01:00
Kostas Karmas
d2c1dc6f6c Fix review comments
CURA-7502
2021-02-04 09:46:03 +01:00
Kostas Karmas
e23c1799b0 Add the Operations markdown page
It includes information about the OperationStack and all the individual operations that are
available in Cura.

CURA-7502
2021-02-03 17:25:17 +01:00
Kostas Karmas
a9eeaa9419 Mention the layFlat operation in the RotateTool
CURA-7502
2021-02-03 17:18:05 +01:00
Kostas Karmas
2d1a0cd47f Add documentation about the Tools and ToolHandles
CURA-7502
2021-02-03 10:54:12 +01:00
Remco Burema
6256bf3a4d
Possible to distinguish between empty and corrupt 3MF.
Otherwise the user could infer valid, but empty workspace is corrupt.

CURA-7996
2021-02-03 09:27:58 +01:00
Gregor Riepl
0c382e0433 Fix screenshot spec in appstream file 2021-02-03 00:29:59 +01:00
Gregor Riepl
5a89620bd1 Update appstream file to point to renamed desktop file 2021-02-03 00:28:50 +01:00
Gregor Riepl
6d5822375a Update cmakelists to install renamed metadata 2021-02-03 00:28:26 +01:00
Gregor Riepl
a972648f67 Rename metadata files to conform with appstream spec 2021-02-03 00:27:16 +01:00
Remco Burema
1e155662d9
Only show line-starts in non-legacy OpenGL mode.
CURA-7981
2021-02-02 15:14:54 +01:00
Kostas Karmas
49330f3e62 Fix the description of the SliceableObjectDecorator
CURA-7502
2021-02-02 14:22:06 +01:00
Kostas Karmas
f7f331d8a2 Add information on the rest of the decorators
* ZOffsetDecorator
  * BlockSlicingDecorator
  * GCodeListDecorator

CURA-7502
2021-02-02 14:15:08 +01:00
Kostas Karmas
7826e89299 Transfer the LayerData information in the LayerDataDecorator section
CURA-7502
2021-02-02 09:58:23 +01:00
Kostas Karmas
ec9d692a68 Fix inline code to point to the correct function
CURA-7502
2021-02-01 17:37:16 +01:00
Kostas Karmas
6ff6fa4af0 Add information about the (legacy) BuildPlateDecorator
CURA-7502
2021-02-01 17:33:08 +01:00
Kostas Karmas
c8c795e573 Add ConvexHull-, SettingOverride-, and SliceableObject-Decorator info
CURA-7502
2021-02-01 17:03:19 +01:00
Kostas Karmas
dce6c1c871 Add information on the GroupDecorator
CURA-7502
2021-02-01 15:54:55 +01:00
Kostas Karmas
85dea31e04 Fix images to contain the SceneNodeDecorator
CURA-7502
2021-02-01 09:40:44 +01:00
Kostas Karmas
383e599f4e Add notes under the scene_example_scene_graph.jpg
CURA-7502
2021-02-01 09:34:35 +01:00
Robert B
8c85902c5f Update comment before Pull Request
Functionality has been tested.
2021-01-31 12:29:38 -05:00
Kostas Karmas
48d4488eb1 Mention the Scene Graph before the class diagram
CURA-7502
2021-01-29 17:49:49 +01:00
Kostas Karmas
6b194a8193 Fix image not showing up correctly
CURA-7502
2021-01-29 17:33:39 +01:00
Kostas Karmas
1db4cbe5f0 Add images and text about the 3D scene graph
CURA-7502
2021-01-29 17:22:49 +01:00
Remco Burema
06666bddca
Fix recent files hint when file opens via dialoges. 2021-01-29 14:49:32 +01:00
Remco Burema
f2088d7fc8
Don't take snapshot if no main window present.
You'll need the Uranium branch of the same (fix_is_visible) name if you don't want this to crash on slicing!
2021-01-29 07:59:54 +01:00
Ghostkeeper
a9bf3ed934
Revert "Small fix for slice before main window visible."
This reverts commit 35d6aad6cd7e8a16fbb829dcf8f0b70db12d0028.
This is causing a very weird crash when autoslice is enabled:
2021-01-28 12:12:35,379 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [66]: An uncaught error has occurred!
2021-01-28 12:12:35,379 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]: Traceback (most recent call last):
2021-01-28 12:12:35,379 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:   File "/home/trin/Gedeeld/Projects/Cura/plugins/CuraEngineBackend/CuraEngineBackend.py", line 270, in slice
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:     self._createSnapshot()
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:   File "/home/trin/Gedeeld/Projects/Cura/cura/Utils/Threading.py", line 31, in _call_on_qt_thread_wrapper
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:     return func(*args, **kwargs)
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:   File "/home/trin/Gedeeld/Projects/Cura/plugins/CuraEngineBackend/CuraEngineBackend.py", line 254, in _createSnapshot
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]:     if not CuraApplication.getInstance().isVisible:
2021-01-28 12:12:35,380 - CRITICAL - [MainThread] cura.CrashHandler.__init__ [69]: AttributeError: 'CuraApplication' object has no attribute 'isVisible'

The property exists all right. It's in the dir() of the CuraApplication instance. PyCharm's debug mode also gives a traceback when trying to evaluate the property. It clearly thinks it's there, but then it's not or something. Very weird. We need to take a better look at this than this quick fix.
2021-01-28 12:23:01 +01:00
Ghostkeeper
678516186e
Revert "Don't call @property function"
This reverts commit 3921cc86d1e3b9e86c5cd0a27cdc83be01b25106.
2021-01-28 12:22:47 +01:00