25054 Commits

Author SHA1 Message Date
Remco Burema
d033e066f7
Adopt code-review remark.
Use width instead of implicit width.

Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2021-03-24 15:58:44 +01:00
Remco Burema
b04bbfdee2
Adopt code-review remark.
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2021-03-24 15:57:41 +01:00
Remco Burema
5083db8d44
On new install or update, have highlights not just changelog.
Place images in resources/images/whats_new/N.format and texts in resources/texts/whats_new/N.format where N is the ordinal and format the respective allowed formats.

CURA-8014
2021-03-24 12:00:05 +01:00
Ghostkeeper
bcf180985d
Fix crash when adding USB device before global stack is created
Like when you plug in a 3D printer via USB while still in the welcome screen.

Fixes Sentry issue CURA-1ZR.
2021-03-18 16:17:09 +01:00
Ghostkeeper
1f9b4c3964
Handle deleting profiles better
When deleting profiles, the current item is set to null.
The Activate button was checking if the current profile was already active, and disabling the button if it was. But the button was still enabled if the current item is null because isCurrentItemActivated is only true if there is a current item. So to properly disable the button we need to check also if there is a current item.
The onItemsChanged signal can also trigger if the item that matches the toSelectItemName has no quality_changes_group, i.e. a built-in profile.

Probably fixes Sentry issue CURA-43.
2021-03-18 02:21:14 +01:00
Ghostkeeper
58369822fc
Clean up invalid quality changes robust to asynchronous changes
It's possible that a profile is no longer in the registry by the time it gets to that point in the list if this clean-up is triggered by the very action of deleting a profile.

Fixes Sentry issue CURA-1T5.
2021-03-16 16:36:01 +01:00
Ghostkeeper
f4b417883e
Merge branch 'patch-1' of https://github.com/TheTRCG/Cura into TheTRCG-patch-1 2021-03-15 17:47:49 +01:00
Ghostkeeper
87d3f6fd22
More consistent Initial Retracted Position setting
Contributes to issue CURA-8038.
2021-03-10 18:24:01 +01:00
Ghostkeeper
74ac7a4cea
Merge branch 'CURA-8148_extruders_switch_retraction_initialization' of https://github.com/sisu70/Cura into sisu70-CURA-8148_extruders_switch_retraction_initialization 2021-03-10 17:38:00 +01:00
Jelle Spijker
2e3d85b9d0
Merge pull request #9377 from Ultimaker/fix_layer_view_greyout_on_model_switch
Fix layer view being greyed out after reslicing gives same current layer
2021-03-10 07:49:24 +01:00
Tom Callaway
eb5baebd64
add Lulzbot TAZ Pro and Lulzbot Mini 2 profiles (#9335)
* add Lulzbot TAZ Pro and Lulzbot Mini 2 profiles

* Update resources/definitions/lulzbot_taz_pro_dual.def.json

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>
2021-03-09 09:27:46 +01:00
Ghostkeeper
fde9449358
Add test to ensure that no definitions define new settings
See the documentation of the test.
2021-03-08 16:53:48 +01:00
KeltE
cbafac6133
Cura Definition for Flasforge DreamerNX (#9303)
* Add files via upload

* Update resources/definitions/flashforge_base.def.json

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

* Update resources/definitions/flashforge_base.def.json

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

* Update resources/definitions/flashforge_dreamer_nx.def.json

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

* Update resources/definitions/flashforge_dreamer_nx.def.json

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

* Rename ff_dreamernx_extruder_0.def.json to flashforge_dreamernx_extruder_0.def.json

* Update flashforge_dreamer_nx.def.json

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>
2021-03-08 16:51:45 +01:00
Konstantinos Karmas
1459d2c462
Merge pull request #9371 from Ultimaker/CURA-8034_Prevent_saving_project_from_presliced_file
Set & use enabled property for saving projects when ufp/gcode is loaded
2021-03-08 14:46:46 +01:00
Ghostkeeper
a379e01f1d
Fix layer view being greyed out after reslicing gives same current layer
This fixes a very old bug in Cura where sometimes after re-slicing it would display the layer as if you've been going horizontal through the path slider, even if you never touched the horizontal path slider.
This was caused by a tracking flag in the SimulationPass, _switching_layers. This bit of state in the SimulationPass was tracking whether the user is going through the vertical layer slider (True) or the horizontal path slider (False). If False, the nozzle mesh is drawn and lower layers get drawn in a shadowy shader. The state of this flag was being updated on every render by looking at whether the previous render has the same current layer number but a different path index. If so, it changed to False, meaning that it assumes you're going through the paths on a layer and things get shadowy.
However if you slice a different object such that the number of layers stay the same (or at least the current layer) but the number of paths on a layer change (e.g. by reducing Maximum Resolution, or by loading a different model that happens to be equally tall) then it would falsely think you were going through the horizontal path slider.

This change effectively resets this state flag when any layer data is changed in the scene. So if you re-slice, it always goes back to _switching_layers = True.

The side effect is that if you were going through the paths of a layer and you re-slice, you won't end up on the same path even if the number of paths on your current layer didn't change due to the reslice. But I think that is more towards what the user would accept a re-slice to do anyway.

I decided to take a look into this bug because I'm making a script to automatically refresh the screenshots of the Settings Guide plug-in. This script frequently hits cases like this, and it's easier to fix this bug than to work around it in my script.
2021-03-06 15:48:32 +01:00
Jaime van Kessel
cc1aadde12
Set & use enabled property for saving projects when ufp/gcode is loaded
CURA-8034
2021-03-05 14:09:39 +01:00
Fenne
1193c197c2
Merge pull request #9367 from Ultimaker/new_issue_templates
Fixed typo and clarified message
2021-03-04 17:30:06 +01:00
fvrmr
6ef3e37fbd Fixed typo and clarified message
Fixed typo in featurerequest.yaml
Clarified message in bugreport.yaml about uploading project file
2021-03-04 17:28:09 +01:00
Jaime van Kessel
2b63fb1081
Add spaces between names of issue templates 2021-03-04 16:52:59 +01:00
Fenne
fdb957ecf2
Merge pull request #9365 from Ultimaker/new_issue_templates
New issue templates
2021-03-04 16:51:04 +01:00
Jaime van Kessel
258313d192
Swap out depricated tag 2021-03-04 16:49:25 +01:00
Jaime van Kessel
2583493638
CHange name of template so that it's unique 2021-03-04 16:47:49 +01:00
Jaime van Kessel
301a571a08
Remove old bug templates 2021-03-04 16:46:18 +01:00
Jaime van Kessel
d9bc0e1dea
Add new bugreport & template 2021-03-04 16:44:20 +01:00
Konstantinos Karmas
f7c45f6cb6
Merge pull request #9358 from Ultimaker/CURA-7820_reword_nonmanifold
[CURA-7820] Reword the non-manifold message, add link.
2021-03-04 09:49:19 +01:00
TheTRCG
650a195fab
Update Geeetech A10 definition
Removed overwriting temperature gcode in the definition
Removed repeated gcode
Added comments for the gcode
2021-03-04 14:16:36 +05:30
Remco Burema
62056f3b0a
Reword previous rewording ('import' -> 'open').
CURA-7820
2021-03-04 09:32:07 +01:00
Ghostkeeper
2c55c4a562
Merge branch 'master' into CURA-7871_lowest_print_height 2021-03-03 17:13:30 +01:00
Remco Burema
8bb57ac0e6
Reword the nonmanifold message, add link.
UX found that users where confused by the word nonmanifold. Reword the message and add an explanatory link.

CURA-7820
2021-03-03 17:13:08 +01:00
Ghostkeeper
b83193bc0f
Fix lowest slice height
Don't always divide by 2. Just for slicing tolerance: Middle. And then just once.

Contributes to issue CURA-7871.
2021-03-03 17:05:01 +01:00
Firedrops
e385ac9e50
Update ideagen3D_sapphire_plus.def.json (#9213)
* Update ideagen3D_sapphire_plus.def.json

Added Restore Bed Levelling after Homing to start G-Code.

* Update resources/definitions/ideagen3D_sapphire_plus.def.json

Co-authored-by: Ghostkeeper <Ghostkeeper@users.noreply.github.com>

* Update ideagen3D_sapphire_plus.def.json

Corrected machine_head_with_fans_polygon and gantry_height for "One at a time" printing.

* Update resources/definitions/ideagen3D_sapphire_plus.def.json

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

Co-authored-by: Ghostkeeper <Ghostkeeper@users.noreply.github.com>
Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>
2021-03-02 15:23:13 +01:00
Jaime van Kessel
2806dc6947
Merge branch 'fix_attr_addresses_not_found' of github.com:Ultimaker/Cura 2021-03-01 15:07:31 +01:00
Jaime van Kessel
a8f92e9900
Merge branch 'master' of github.com:Ultimaker/Cura 2021-03-01 14:32:54 +01:00
Jaime van Kessel
ad8e78c7f8
Remove unused import 2021-03-01 14:32:42 +01:00
Jaime van Kessel
a9c255284c
Merge pull request #9328 from Ultimaker/fix/cluster-print-job-constraints
Fix cluster print job constraints typing and optionality
2021-03-01 13:31:24 +01:00
Remco Burema
2b88a2dc87
Fix error log spam.
The code is clearly written to take into account that 'addresses' may be null. But not that the whole 'addresses' attribute may not exist. And then instead of printing one warning (Could not get information about XX) it instead printed a stacktrace and retried and printed a stacktrace and retried and printed a stacktrace and.... It ended up driving me a bit nuts when looking at the logs for unrelated reasons. So Ifinallay fixed it. Could end up as a speedup in some cases as well I suppose?
2021-02-26 21:56:33 +01:00
Jaime van Kessel
fa4d1ba1fb
Don't strip accents from job name
No idea why this was there in the first place. Our archeology attempts couldn't
find out as to why it was introduced. We suspect an issue with other Qt versions.

At least now ロボット.stl will not be mangled into ロホット.gcode upon saving (and
german bears into bars)
2021-02-26 14:56:27 +01:00
Ghostkeeper
5c58df3c73
Minor corrections to Sri Vignan printers
Found during testing. I think it's pretty safe to say what they intended to write here.

Contributes to issue CURA-8051.
2021-02-25 17:46:46 +01:00
Ghostkeeper
642fee9904
Merge branch 'master' of https://github.com/venkatkamesh/Cura into venkatkamesh-master 2021-02-25 17:32:45 +01:00
Chris ter Beke
aac004cd2b
Fix case where constraints is None 2021-02-25 12:20:32 +01:00
Chris ter Beke
d2c4dd0f65
Fix cluster print job constraints typing and optionality 2021-02-25 12:12:38 +01:00
Eryone
2b024ab390
Merge pull request #9202
* Adding Eryone Thinker profile to Cura
2021-02-24 15:10:28 +01:00
Hellbot Development Team
c7e238c7c7
Update definition files for Hellbot Magna 1 and Hellbot Magna dual (#8509)
* Update in Definition file for Hellbot Magna 1 
* Change the Author name and version number. 
* Added Heated bed.
* Added specific Gcode for purging the 2 in 1 hotend.
* Add bed images for Hellbot Hidra and Hidra Plus
* Add meshes files for Hellbot Hidra and Hidra plus
* Add extruder files for new Hellbot printers 
* Add extruder files for new Hellbot Printers: Hellbot Hidra and Hellbot Hidra Plus
* Add New Hellbot printers 
* Add definition files for the new Hellbot printers: Hidra and Hidra Plus

CURA-8047
2021-02-24 14:55:26 +01:00
Jaime van Kessel
f73320602d
Revert "Add stub for new bug template"
This reverts commit f60ad6f3093c44d0b3beacee987605dacc64ba99.
2021-02-24 14:09:44 +01:00
Jaime van Kessel
f60ad6f309
Add stub for new bug template 2021-02-24 14:07:36 +01:00
Ghostkeeper
dc68fbc94a
Add colour scheme for line width
Implements CURA-7741.
2021-02-19 10:10:16 +01:00
Ghostkeeper
0c9175d7f7
Lower camera default position by 70mm
The previous default position was aimed at 100mm above the build plate. This is taller than most models that people load into Cura. It's now aimed at 30mm. Models up to 50mm are way more common to print, so this brings it right in the butter zone for most people, hopefully.

Fixes #9251.
2021-02-15 11:31:28 +01:00
Jaime van Kessel
d24bbc4071
Merge branch 'fix_postprocessing_script_roots' of https://github.com/fieldOfView/Cura 2021-02-12 16:29:28 +01:00
Kostas Karmas
d9cf7aeb8e Replace tabs with spaces in trimaker printer profiles
CURA-8016
2021-02-09 15:32:56 +01:00
tomasbaldi
9052e2dae3
adding profiles for Trimaker printers (#8537)
* adding profiles for Trimaker printers

* adding profiles for Trimaker printers v2

* Update resources/extruders/trimaker_nebula_extruder.def.json

Co-authored-by: Jaime van Kessel <nallath@gmail.com>

* Update resources/extruders/trimaker_cosmosII_extruder.def.json

Co-authored-by: Jaime van Kessel <nallath@gmail.com>

* Delete trimaker_cosmosII_platform.STL

* correction extension of trimaker_cosmosII_platform.stl and modification in trimaker_cosmosII.def.json and trimaker_nebula.def.json

* Update trimaker_nebula_platform.stl

* move the STL up

* Update resources/definitions/trimaker_nebula.def.json

"grid" -> "'grid'"

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

* Update resources/definitions/trimaker_cosmosII.def.json

"grid" -> "'grid'"

Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>

* 220x220x260 -> 230x230x260 (nebula)

* change the name of the qualities directory

* translate quality names from spanish to english

* change nebula platform_offset

* change nebula platform_offset 2

Co-authored-by: Jaime van Kessel <nallath@gmail.com>
Co-authored-by: Konstantinos Karmas <konskarm@gmail.com>
2021-02-09 15:28:04 +01:00