34745 Commits

Author SHA1 Message Date
Saumya Jain
1457569aeb Fix handling of undefined printer items in AddLocalPrinterScrollView
This commit addresses an issue wherein undefined current items were not properly handled in the AddLocalPrinterScrollView module. We've changed the code so that it now checks if currentItem and currentItem.name exist before attempting to assign. If they don't exist, we now set default values to avoid null or undefined references. This prevents potential errors or inconsistent behaviors in the UI.

CURA-11003
2024-04-10 17:24:55 +02:00
Saumya Jain
3908db7696 Update search bar style and theme alteration
CURA-11003
2024-04-10 15:45:24 +02:00
Saumya Jain
8f09d35955
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-10 15:17:14 +02:00
Saumya Jain
8449d6d953
Merge branch 'main' into CURA-10901-warn-if-formulas-are-NOK 2024-04-10 15:03:53 +02:00
HellAholic
e37434abef
Merge pull request #18824 from Ultimaker/CURA-10903-warn-for-deleted-files
Add detection for deleted files in printer linter
2024-04-10 15:01:06 +02:00
Saumya Jain
84f90eadf8 Adding strip as the github actions were not picking up text with extra spaces
CURA-10901
2024-04-10 14:53:49 +02:00
Saumya Jain
c6ff0d3030 Enhance error reporting for deleted files
The code now checks if a requested file is present in the files list before diagnosing issues and generating error reports for it. It will help prevent attempting to diagnose or report on files that do not exist or deleted, thus enhancing efficiency and preventing possible error generation

CURA-10903
2024-04-10 14:50:26 +02:00
Saumya Jain
a965392559 Update method for getting PR number and modify output report
The code updates the way we fetch the Pull Request number in the Github action. Rather than using an external action, we directly make use of Github's CLI, which helps improve the speed and reliability of the workflow. Additionally, the output report's format in terminal.py, previously named as "Git Comment", has been changed to "Error Files" to better reflect the information it carries.

CURA-10903
2024-04-10 14:16:25 +02:00
Saumya Jain
d52cd78852 Update GitHub workflow to use create-or-update-comment action
In this update, the GitHub workflow now uses the 'create-or-update-comment' action instead of the 'find-comment' action for PR comments. Additionally, a step has been added to get the PR number. This change is expected to facilitate more efficient PR commenting and handling.

CURa-10903
2024-04-10 14:01:17 +02:00
Saumya Jain
3987969a22 Simplify and optimize Cura settings list retrieval
Related Task: CURA-10901
2024-04-10 11:37:19 +02:00
Saumya Jain
dcd673a605 Refactor and enhance formula linter in printer-linter module
The update improves formula linting by refining the identification and correction processes of formula typos. It establishes a list of standard formula names and delimiters for better match and replacement operations. Additionally, it enhances error reporting, providing users with more specific and instructive feedback. The Cura settings list retrieval method has been optimized as well.

Related Task: CURA-10901
2024-04-10 10:53:17 +02:00
Saumya Jain
db0e46b252 Improve formula checks and error messages in printer-linter
This update enhances the checking of formula correctness in printer settings and provides clearer error messages when formulas appear incorrect. By getting a list of Cura setting variables and typical formula names, it uses these to match and replace incorrect segments in formulas, if any. Related code for error handling and message reporting are also revised to give more useful feedback to users for necessary corrections.

CURA-10901
2024-04-10 10:42:17 +02:00
Saumya Jain
c1e5fe0a42 Update MaterialNode initialization and metadata retrieval
Although this is rare scenario.This allows for metadata retrieval from the container directly if one is provided, otherwise metadata is fetched using the container_id from the ContainerRegistry. Updated the MaterialNode creation in the VariantNode class(only one scenario) to pass the container.

CURA-11748
2024-04-10 09:27:37 +02:00
Saumya Jain
01552556d8 Fix formula check and correct error message
CURA-10901
2024-04-09 16:19:49 +02:00
Saumya Jain
9db52e3888 Adding the replacement text for the maybe corrected formula
CURA-10901
2024-04-09 16:10:27 +02:00
Saumya Jain
bb94ce9e75 fixing typo checks
CURA-10903
2024-04-09 11:37:42 +02:00
Saumya Jain
561a40d000 Implement GitComment class and update workflow files
A new GitComment class was implemented to replace Diagnostic for deleted file checks. As part of this change, both main workflow files (printer-linter-pr-diagnose.yml and printer-linter-pr-post.yml) have been updated to accommodate this new class. Also, reports now use 'comment.md' instead of 'fixes.yml'. All of this is ultimately geared at improving diagnostic functionality and allowing deleted file checks to output directly to a Git comment.

CURA-10903
2024-04-09 11:33:24 +02:00
Saumya Jain
8b0f208ee7
Merge branch 'main' into Cura_ankermake_august 2024-04-09 10:16:27 +02:00
Saumya Jain
eecf9cdebf Refactor formulas.py for improved formula handling
Imported difflib, re, and CuraFormulaFunctions for more efficient formula handling and error checking. This prevents crashes and improves the reliability of the application by suggesting the correct formula when an incorrect one is entered

CURA-10901
2024-04-08 17:56:14 +02:00
Saumya Jain
d017f0ec9c increased size of clear icon
CURA-11003
2024-04-08 15:37:48 +02:00
Saumya Jain
e15049f2e0 Update formulas handling
CURA-10901
2024-04-08 15:26:55 +02:00
Saumya Jain
78b7793cd4
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-08 14:08:38 +02:00
Saumya Jain
702f8573c3
Merge branch 'main' into CURA-10903-warn-for-deleted-files 2024-04-08 14:03:48 +02:00
Saumya Jain
388be81116
Merge branch 'main' into CURA-10901-warn-if-formulas-are-NOK 2024-04-08 14:02:00 +02:00
HellAholic
bb444a6eb4
Merge pull request #18822 from Ultimaker/CURA-10904-printer-linter-material-temperature
Cura 10904 printer linter material temperature
2024-04-08 13:38:24 +02:00
Saumya Jain
df4cc1ffd3
Merge branch 'main' into CURA-10901-warn-if-formulas-are-NOK 2024-04-08 12:53:23 +02:00
Saumya Jain
323a347248
Merge branch 'main' into CURA-10904-printer-linter-material-temperature 2024-04-08 12:50:52 +02:00
Saumya Jain
29617ea22f removed path with parent because it doesn't exist anymore 2024-04-08 12:42:33 +02:00
Saumya Jain
061a80deb4
Merge branch 'main' into CURA-10903-warn-for-deleted-files 2024-04-08 12:25:36 +02:00
Saumya Jain
b3a25893fc fix results to result
CURA-10903
2024-04-08 12:25:10 +02:00
Saumya Jain
c53e611c81 Update printer-linter workflow and fix file checks order
CURA-10903
2024-04-08 12:23:26 +02:00
HellAholic
d842d9c139
Merge pull request #18815 from Ultimaker/CURA-11748-crash-during-the-material-setting-load
Update MaterialNode initialization and metadata retrieval
2024-04-08 12:17:52 +02:00
Saumya Jain
13ad75a240 fixing command
CURA-10903
2024-04-08 10:52:17 +02:00
Saumya Jain
8b135b5562 Update command to retrieve deleted files
CURA-10903
2024-04-08 10:50:24 +02:00
Saumya Jain
2f8829c2d1 GIT_DIFF not necessarity have the info of deleted files
CURA-10903
2024-04-08 10:42:17 +02:00
Saumya Jain
8e9ebb6832 Consistent for naming convention
CURA-10901
2024-04-08 10:25:23 +02:00
GregValiant
54636c3421 Monitor Page Preheat values
Change the default preheat values to the Initial Layer values.
2024-04-05 13:32:28 -04:00
Saumya Jain
fe0120ef64 Add Formulas linter and integrate with factory
A new linter class, Formulas, has been added to check for issues in definition files, particularly with default parameters overrides. It has been integrated into the Linter factory to also check '.inst.cfg' and '.def.json' files for formulas-related issues. Additionally, a new 'diagnostic-incorrect-formula' check has been included in the .printer-linter configuration.

CURA-10901
2024-04-05 18:18:40 +02:00
Saumya Jain
7231c273a1 Refactor textChanged event
helps to increase code readability and maintainability.

CURA-11003
2024-04-05 16:26:33 +02:00
Saumya Jain
66754d837b Remove redundant printerSearchTimer
CURA-11003
2024-04-05 16:24:34 +02:00
Saumya Jain
38382eeec7 Add detection for deleted files in printer linter
This update adds a new check for deleted files in the printer linter. This will alert the user when a file has been deleted that could potentially disrupt upgrade scripts. An argument "--deleted" is also added to terminal.py to facilitate this new check. Additionally, the printer-linter version has been incremented to 0.1.2.

CURA-10903
2024-04-05 15:55:30 +02:00
Saumya Jain
794cdfd077 Same as before.
CURA-10904
2024-04-05 11:59:39 +02:00
Saumya Jain
0049271ae8
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-05 10:10:23 +02:00
Saumya Jain
6609741323 Fix potential key error in printer linter
CURA-10904
2024-04-05 10:06:28 +02:00
Saumya Jain
e5fb40b48c Add material temperature check in linter
CURA-10904
2024-04-05 10:02:08 +02:00
Saumya Jain
8efc5ece01
Merge branch 'main' into Cura_ankermake_august 2024-04-04 15:18:09 +02:00
Erwan MATHIEU
8020b9d97d Move back to testing packages on main 2024-04-04 15:05:13 +02:00
Saumya Jain
7a6f195b74 changed filter from "id" to "name" as both are different
CURA-11003
2024-04-04 14:37:51 +02:00
Saumya Jain
f35865e3c4 property name hasSearchFilter changed
CURA-11003
2024-04-04 14:13:58 +02:00
Saumya Jain
2ed0377a05 added column for removing the magic number
CURA-11003
2024-04-04 14:09:58 +02:00