34820 Commits

Author SHA1 Message Date
Jelle Spijker
e7717021d0
loosen pinned versions 2024-04-22 10:30:56 +02:00
Jelle Spijker
f6ec9f55d6
bump version to 5.7.1 2024-04-22 10:25:47 +02:00
Saumya Jain
039b6ed2c2 Remove 'upper' from available formula functions
CURA-10901
2024-04-19 17:32:40 +02:00
Saumya Jain
72bf639bea Remove unnecessary formulas from linter
These formulas or modules are not used in definition files , so removing them

CURA-10901
2024-04-19 17:31:08 +02:00
Saumya Jain
1f2e690809 Extend list of formula names in linter
The list of formula names in the printer-linter's formula linter has been expanded. New entries include various mathematical functions (e.g., "max", "min", "sqrt"), string manipulation functions ("lower", "upper", "startswith"), and cryptographic/hash functions ("hashlib", "md5").
2024-04-19 17:02:58 +02:00
saumyaj3
c517311171 Applied printer-linter format 2024-04-19 14:56:51 +00:00
Saumya Jain
ee85383699 Add support z seam settings to expert.cfg and fdmprinter.def.json
This update includes two new settings in the expert visibility profile: 'support_z_seam_away_from_model' and 'support_z_seam_min_distance'. These allow users more control over the spatial relationship between the z seam of the support structure and the actual 3D model, ensuring a smoother post-printing process

CURA-11227
2024-04-19 16:55:24 +02:00
Saumya Jain
37c177fe04
Merge branch 'main' into CURA-10901-warn-if-formulas-are-NOK 2024-04-18 11:55:26 +02:00
Saumya Jain
fd388b5cb3 Modify Formulas class description and simplify return statement
CURA-10901
2024-04-18 11:53:38 +02:00
HellAholic
549d107ab1
Merge pull request #18804 from Ultimaker/CURA-11003-add-searchbar-for-offlineprinter
Cura 11003 add searchbar for offlineprinter
2024-04-17 15:27:32 +02:00
Erwan MATHIEU
3648aff5c2
Merge pull request #14778 from tastyratz/patch-1
Update InsertAtLayerChange.py
2024-04-12 16:24:59 +02:00
Saumya Jain
597a871807
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-12 12:32:25 +02:00
Saumya Jain
fd01684a23
Update resources/qml/WelcomePages/AddLocalPrinterScrollView.qml
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2024-04-12 12:31:57 +02:00
Saumya Jain
17372064c7
Update resources/qml/WelcomePages/AddLocalPrinterScrollView.qml
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
2024-04-12 12:31:52 +02:00
Saumya Jain
a3911bdbfa PR comments
CURA-11003
2024-04-12 12:29:07 +02:00
Jaime van Kessel
7a5c773e90
Made printprocess reporting settings not settable per mesh 2024-04-12 11:08:35 +02:00
Erwan MATHIEU
1dc6289d89
Merge branch 'main' into patch-1 2024-04-12 10:44:46 +02:00
Saumya Jain
344221a083
Merge pull request #18828 from GregValiant/Monitor-Pre-Heat-default-values
Monitor Page Preheat values
2024-04-12 10:34:07 +02:00
Saumya Jain
74bf578691
Merge branch 'main' into Monitor-Pre-Heat-default-values 2024-04-12 10:21:54 +02:00
Erwan MATHIEU
4bd1c4c4e0
Merge branch 'main' into patch-1 2024-04-12 10:16:32 +02:00
Saumya Jain
c010b58dad
Merge branch 'main' into main 2024-04-11 13:45:00 +02:00
Saumya Jain
ebb97d4be5
Merge branch 'main' into CURA-10901-warn-if-formulas-are-NOK 2024-04-11 09:51:11 +02:00
Saumya Jain
3016820bee fixing printer linter PR post 2024-04-11 09:47:40 +02:00
Saumya Jain
b76ec32768
Merge branch 'main' into Cura_ankermake_august 2024-04-11 09:40:00 +02:00
Saumya Jain
1457569aeb Fix handling of undefined printer items in AddLocalPrinterScrollView
This commit addresses an issue wherein undefined current items were not properly handled in the AddLocalPrinterScrollView module. We've changed the code so that it now checks if currentItem and currentItem.name exist before attempting to assign. If they don't exist, we now set default values to avoid null or undefined references. This prevents potential errors or inconsistent behaviors in the UI.

CURA-11003
2024-04-10 17:24:55 +02:00
Saumya Jain
3908db7696 Update search bar style and theme alteration
CURA-11003
2024-04-10 15:45:24 +02:00
Saumya Jain
8f09d35955
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-10 15:17:14 +02:00
Saumya Jain
8449d6d953
Merge branch 'main' into CURA-10901-warn-if-formulas-are-NOK 2024-04-10 15:03:53 +02:00
HellAholic
e37434abef
Merge pull request #18824 from Ultimaker/CURA-10903-warn-for-deleted-files
Add detection for deleted files in printer linter
2024-04-10 15:01:06 +02:00
Saumya Jain
84f90eadf8 Adding strip as the github actions were not picking up text with extra spaces
CURA-10901
2024-04-10 14:53:49 +02:00
Saumya Jain
c6ff0d3030 Enhance error reporting for deleted files
The code now checks if a requested file is present in the files list before diagnosing issues and generating error reports for it. It will help prevent attempting to diagnose or report on files that do not exist or deleted, thus enhancing efficiency and preventing possible error generation

CURA-10903
2024-04-10 14:50:26 +02:00
Saumya Jain
a965392559 Update method for getting PR number and modify output report
The code updates the way we fetch the Pull Request number in the Github action. Rather than using an external action, we directly make use of Github's CLI, which helps improve the speed and reliability of the workflow. Additionally, the output report's format in terminal.py, previously named as "Git Comment", has been changed to "Error Files" to better reflect the information it carries.

CURA-10903
2024-04-10 14:16:25 +02:00
Saumya Jain
d52cd78852 Update GitHub workflow to use create-or-update-comment action
In this update, the GitHub workflow now uses the 'create-or-update-comment' action instead of the 'find-comment' action for PR comments. Additionally, a step has been added to get the PR number. This change is expected to facilitate more efficient PR commenting and handling.

CURa-10903
2024-04-10 14:01:17 +02:00
Saumya Jain
3987969a22 Simplify and optimize Cura settings list retrieval
Related Task: CURA-10901
2024-04-10 11:37:19 +02:00
Saumya Jain
dcd673a605 Refactor and enhance formula linter in printer-linter module
The update improves formula linting by refining the identification and correction processes of formula typos. It establishes a list of standard formula names and delimiters for better match and replacement operations. Additionally, it enhances error reporting, providing users with more specific and instructive feedback. The Cura settings list retrieval method has been optimized as well.

Related Task: CURA-10901
2024-04-10 10:53:17 +02:00
Saumya Jain
db0e46b252 Improve formula checks and error messages in printer-linter
This update enhances the checking of formula correctness in printer settings and provides clearer error messages when formulas appear incorrect. By getting a list of Cura setting variables and typical formula names, it uses these to match and replace incorrect segments in formulas, if any. Related code for error handling and message reporting are also revised to give more useful feedback to users for necessary corrections.

CURA-10901
2024-04-10 10:42:17 +02:00
Saumya Jain
c1e5fe0a42 Update MaterialNode initialization and metadata retrieval
Although this is rare scenario.This allows for metadata retrieval from the container directly if one is provided, otherwise metadata is fetched using the container_id from the ContainerRegistry. Updated the MaterialNode creation in the VariantNode class(only one scenario) to pass the container.

CURA-11748
2024-04-10 09:27:37 +02:00
Saumya Jain
01552556d8 Fix formula check and correct error message
CURA-10901
2024-04-09 16:19:49 +02:00
Saumya Jain
9db52e3888 Adding the replacement text for the maybe corrected formula
CURA-10901
2024-04-09 16:10:27 +02:00
Saumya Jain
bb94ce9e75 fixing typo checks
CURA-10903
2024-04-09 11:37:42 +02:00
Saumya Jain
561a40d000 Implement GitComment class and update workflow files
A new GitComment class was implemented to replace Diagnostic for deleted file checks. As part of this change, both main workflow files (printer-linter-pr-diagnose.yml and printer-linter-pr-post.yml) have been updated to accommodate this new class. Also, reports now use 'comment.md' instead of 'fixes.yml'. All of this is ultimately geared at improving diagnostic functionality and allowing deleted file checks to output directly to a Git comment.

CURA-10903
2024-04-09 11:33:24 +02:00
Saumya Jain
8b0f208ee7
Merge branch 'main' into Cura_ankermake_august 2024-04-09 10:16:27 +02:00
Saumya Jain
eecf9cdebf Refactor formulas.py for improved formula handling
Imported difflib, re, and CuraFormulaFunctions for more efficient formula handling and error checking. This prevents crashes and improves the reliability of the application by suggesting the correct formula when an incorrect one is entered

CURA-10901
2024-04-08 17:56:14 +02:00
Saumya Jain
d017f0ec9c increased size of clear icon
CURA-11003
2024-04-08 15:37:48 +02:00
Saumya Jain
e15049f2e0 Update formulas handling
CURA-10901
2024-04-08 15:26:55 +02:00
Saumya Jain
78b7793cd4
Merge branch 'main' into CURA-11003-add-searchbar-for-offlineprinter 2024-04-08 14:08:38 +02:00
Saumya Jain
702f8573c3
Merge branch 'main' into CURA-10903-warn-for-deleted-files 2024-04-08 14:03:48 +02:00
Saumya Jain
388be81116
Merge branch 'main' into CURA-10901-warn-if-formulas-are-NOK 2024-04-08 14:02:00 +02:00
HellAholic
bb444a6eb4
Merge pull request #18822 from Ultimaker/CURA-10904-printer-linter-material-temperature
Cura 10904 printer linter material temperature
2024-04-08 13:38:24 +02:00
Saumya Jain
df4cc1ffd3
Merge branch 'main' into CURA-10901-warn-if-formulas-are-NOK 2024-04-08 12:53:23 +02:00